From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2884C761A6 for ; Mon, 3 Apr 2023 13:52:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232721AbjDCNwq (ORCPT ); Mon, 3 Apr 2023 09:52:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232706AbjDCNwn (ORCPT ); Mon, 3 Apr 2023 09:52:43 -0400 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::223]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88071728D for ; Mon, 3 Apr 2023 06:52:41 -0700 (PDT) Received: (Authenticated sender: me@crly.cz) by mail.gandi.net (Postfix) with ESMTPSA id 02CD660007; Mon, 3 Apr 2023 13:52:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crly.cz; s=gm1; t=1680529959; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yjZVA2mMTeWzOtGqbKtDtJ1agsEpiSlCHKJk6KjuyTk=; b=a+axboIp+P2/EKx8WVgBZOoRoRb9hQH4yMUJKl/KYwTUXyWTHkrdOcsRBihMNMuo2dl3QV zWOf2kr4ADe3KnTUNknPdufaa+L4lsOwXiR2y7Gma3pvVwv3JpTkY8iVX7m5RtIHlWCqfj gtlXcAJzUSIjwDYnwLcdHWT6bi2HsK3G6cunNA5Ir3/fkY5mIBklap5LlA1PVfm27uqBIc RM2xnKgFFxAo/EPlKGKCWqf3BP+rWeYJXnEO5ARANwcYxyCRVZd058YKlxfLKQ5MLzUgC6 upc7FgQGmjHoLlWXZL9JaTEk2pbSI7L8GYt2tdTN6hhcXvidQ3OevjSfPQHwPA== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 03 Apr 2023 15:52:36 +0200 Message-Id: Subject: Re: [PATCH 3/3] drm: sun4i: calculate proper DCLK rate for DSI From: "Roman Beranek" To: "Frank Oltmanns" Cc: "Maxime Ripard" , "Chen-Yu Tsai" , "David Airlie" , "Daniel Vetter" , "Jernej Skrabec" , "Samuel Holland" , , , , X-Mailer: aerc 0.14.0 References: <20230331110245.43527-1-me@crly.cz> <20230331110245.43527-4-me@crly.cz> <87h6tya70h.fsf@oltmanns.dev> In-Reply-To: <87h6tya70h.fsf@oltmanns.dev> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun Apr 2, 2023 at 12:49 PM CEST, Frank Oltmanns wrote: > > When apply this to drm-next my panel stays dark. I haven't figured out > yet why, though. The other two patches in this series work fine, i.e. > they have no effect as they are just a refactoring. > > I'm testing this on my pinephone. It's the same with the patch I > submitted. For whatever reason, it no longer works on drm-next. I've reproduced the issue on my PinePhone and noticed that tcon0 had set pll-video0-2x as its parent instead of pll-mipi. Having tried a whole range of pll-video0 rates, I'm now convinced that DSI only works when tcon0 has pll-mipi as its parent. As little a change as setting .clock in the default mode of PP's panel to 73500 can fix it. Better yet, dropping pll-video0-2x from the set of acceptable parents for tcon0 fixes it universally. And that's what megi's kernel does, though the measure was introduced with a different rationale: Roman