From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932257AbdKORbk (ORCPT ); Wed, 15 Nov 2017 12:31:40 -0500 Received: from g4t3425.houston.hpe.com ([15.241.140.78]:18746 "EHLO g4t3425.houston.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753038AbdKORb3 (ORCPT ); Wed, 15 Nov 2017 12:31:29 -0500 From: "Sajjan, Vikas C" To: "Rafael J. Wysocki" CC: Linux PM , ACPI Devel Maling List , "Rafael J. Wysocki" , "Linux Kernel Mailing List" , Seunghun Han , Thomas Gleixner , Ingo Molnar , "Lakshminarasimha, Sunil Vishwanathpur" , "Attar, Abdul Lateef" Subject: RE: [PATCH] x86/acpi: Fix improper handling of SCI INT for platforms supporting only IOAPIC mode Thread-Topic: [PATCH] x86/acpi: Fix improper handling of SCI INT for platforms supporting only IOAPIC mode Thread-Index: AQHTWgs/LelhCHRuxU2UiB/+2YIBl6MVuAMAgAAA5JA= Date: Wed, 15 Nov 2017 17:30:46 +0000 Message-ID: References: <1510306686-18230-1-git-send-email-vikas.cha.sajjan@hpe.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=vikas.cha.sajjan@hpe.com; x-originating-ip: [116.75.127.246] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CS1PR8401MB0773;6:bLE3NshUbKAxwHY+g9SlzyomXSBkj2MHHWA9mAVekxbi9pEU+KvSJY0YRozGNaxcZRypbelkahPXmmNJtKP/0xIaaKXfDDa+GKBiYW71Egtz6jGNLjZcO5ydJpljK1UWD9uljOBdU9WPYDfZcREZeCacRQiczxAEsv8ZiWLBxXI9wHDD+VtMWxVRueoARd/ENTbd10XujNOi938wj/joMZnwn7nu9E+8s3hPoAe2E4QL8pdwIXdLtK7U1fA605UlkFgYuaRpg4fPeyFfdBy91ALFhhiIftrfj/RqQrgk8TIgMxlADaRgLHEJ4sVY82ZtvzQCghe7GYl7hqp00PtchX7fRBSNNY567zTojNPVTpo=;5:9T+7247MJZkYeWKpWfRKcqNdqibES5YwNEzuR+IXS/YGEXyJU0MVljqcoCMl9hyIw8zZUBHcTUf97i1S1SaTqJ1zDqm+vwhB67d/V9YkdW0ihpy3hZL5R0HoAmfD/RpqPep9SPoSdh87bws1nGBf6D6qKuG1fZGQocpDpElCYfU=;24:Zu3pBKtVcOvv5WJvtex88mFEoRQ3/vKxC02qBoC83vOgPMkHO0mosoms7hXyCLpGpQVViXoWdSvcGIzz9O2+M/dZGngEAX9Ym/+0dp8Coss=;7:6j29oV10nmhmMGWEb6jVfYiWB6T5UnL0tntlep4vFQsqe2cpmafL/K6OvMI89pWcTFu3uZbF0A+P0Rzw84YJ5/7IugA8qr9N9iTBOBbUfKApJrhAW5/HkdpdkaYgl4TS6rNfh+viL4ulSlTCRnbHnkB8Vb1o1NbJdWCtUi4Ame54a0TQJuBFUhCE+3iABr2u908OVAQHyyuJtPkjmL2etqCxd2jPHzsOiBBNcN7/8hdt8vobEwp035a3QNxqtzrb x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI;SCL:-1;SFV:NSPM;SFS:(10019020)(6009001)(346002)(376002)(39860400002)(199003)(24454002)(13464003)(189002)(478600001)(6116002)(102836003)(8676002)(106356001)(6436002)(66066001)(9686003)(7696004)(55016002)(2950100002)(5250100002)(3280700002)(3846002)(76176999)(68736007)(53546010)(3660700001)(229853002)(50986999)(6916009)(54356999)(316002)(81156014)(14454004)(33656002)(105586002)(81166006)(101416001)(189998001)(8936002)(6506006)(54906003)(39060400002)(53936002)(6246003)(99286004)(74316002)(86362001)(7736002)(2900100001)(5660300001)(305945005)(2906002)(25786009)(4326008)(97736004)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR8401MB0773;H:CS1PR8401MB0518.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; x-ms-office365-filtering-correlation-id: 1a3b6e16-f6bc-43c0-22e6-08d52c4e9b04 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603258);SRVR:CS1PR8401MB0773; x-ms-traffictypediagnostic: CS1PR8401MB0773: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(227479698468861)(9452136761055); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(3231022)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(20161123560025)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CS1PR8401MB0773;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CS1PR8401MB0773; x-forefront-prvs: 0492FD61DD spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 1a3b6e16-f6bc-43c0-22e6-08d52c4e9b04 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Nov 2017 17:30:46.0260 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB0773 X-OriginatorOrg: hpe.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vAFHVjn5017567 Hi Rafael, -----Original Message----- From: rjwysocki@gmail.com [mailto:rjwysocki@gmail.com] On Behalf Of Rafael J. Wysocki Sent: Wednesday, November 15, 2017 10:51 PM To: Sajjan, Vikas C Cc: Linux PM ; ACPI Devel Maling List ; Rafael J. Wysocki ; Linux Kernel Mailing List ; Seunghun Han ; Thomas Gleixner ; Ingo Molnar ; Lakshminarasimha, Sunil Vishwanathpur ; Attar, Abdul Lateef Subject: Re: [PATCH] x86/acpi: Fix improper handling of SCI INT for platforms supporting only IOAPIC mode On Fri, Nov 10, 2017 at 10:38 AM, Vikas C Sajjan wrote: > The platforms which support only IOAPIC mode and whose SCI INT is > greater than 16, passes SCI INT via FADT and not via MADT int src > override structure. In such cases current logic fails to handle it and > throws error "Invalid bus_irq %u for legacy override". This patch > handles the above mentioned case. While at it, also modify function > mp_override_legacy_irq() to use the newly introduced function mp_register_ioapic_irq(). Actually, is it necessary to make this extra change here? How complicated would it be to separate it out? I can move these extra changes into a separate patch and keep only the fix in this patch. Thanks, Rafael Thanks, Vikas Sajjan