From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964896AbdKQOBF convert rfc822-to-8bit (ORCPT ); Fri, 17 Nov 2017 09:01:05 -0500 Received: from g4t3427.houston.hpe.com ([15.241.140.73]:22617 "EHLO g4t3427.houston.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751135AbdKQOAy (ORCPT ); Fri, 17 Nov 2017 09:00:54 -0500 X-Greylist: delayed 95009 seconds by postgrey-1.27 at vger.kernel.org; Fri, 17 Nov 2017 09:00:53 EST From: "Sajjan, Vikas C" To: Thomas Gleixner CC: "rjw@rjwysocki.net" , "linux-pm@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kkamagui@gmail.com" , "mingo@kernel.org" Subject: RE: [PATCH v3 1/2] acpi/x86: Fix improper handling of SCI INT for platforms supporting only IOAPIC mode Thread-Topic: [PATCH v3 1/2] acpi/x86: Fix improper handling of SCI INT for platforms supporting only IOAPIC mode Thread-Index: AQHTXvmVV9M+fGdxAUWiXSQz+cdO86MYYlmAgAA2oUA= Date: Fri, 17 Nov 2017 14:00:14 +0000 Message-ID: References: <1510848825-21965-1-git-send-email-vikas.cha.sajjan@hpe.com> <1510848825-21965-2-git-send-email-vikas.cha.sajjan@hpe.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=vikas.cha.sajjan@hpe.com; x-originating-ip: [116.75.120.57] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CS1PR8401MB0520;6:MugoFPixu4M7+AwlfnM71G65GhzcOaYBzD6KtuEu/Gpzy8k3I8167IoOebv1qW36Bql9rhBFSASEptjtu0vky6TzOJA0IylzhfLUbNTGaSriIxFnnZH//gFBWrSXN8oS/SRDHgl8lwU+tbu4hVZu8h9eAK6R+3WWNVIchELNZiLVSThT5dbupd/AhDv1wBPSc9rRdB4K0egXBY24fqE0M9o3BnFZUDsh3IDxzMB+rn3adQC+kt8CQBo5DoZVQgRVFBOXn8zh/ApNs7T0BvljvCmfj3juwP9/KwnggvELz4L2G/LHRoho4WZ/n6R6BJfGmcnHWJaZKuQ2PLzcAyTII0h2iMs4M11gNHiX7kwN4HE=;5:UnKhWIe+gPpqgAWLNXHycU4KruU5JFjxk8ByZ0QSl4lxJR5QPLp/MFfteH7cZLwIx41qSQb4aAiajvsev4Uk3flcUadEEZv+jwq15hBY7Z8xwLPw9oLUUJjfr5zYYMDvj/kHurHWgfoNVcjOFb5Kha7/bosnuzRvAKILWM5yjkA=;24:FDhE/CdRed8D19yoeuP4Apn3i04MI+r9HjUBVRcdoXP3hJpG5d8Zn2FPhMW4LekhyLK8Zia8CgiC7/rMPLaqL/uvl3cRcFYOMQmZnJRDShE=;7:FAfKLuilqBEPU/JSAOI67yLzomyUzrJZRI0tADi2YLaFbY3mzXI0GYdcYJooHJQ2CSrlTeEKU3o9/f+APIJh692qSraf34ugcPXetW0Z+DvAm+5/YZtQrwYB9KizIKuiK2MU/Mz+6S7zaRLjczNlZ/mfG0PRWCIrLhXCq2GyM2JrqV97RqEzbWPAtMs59cIBIk/RpXBNTGi8qbsIWPF46lqiHz4cds7oY2/iAjfeSFST+Ym0VvEEE5oFopPSwmSj x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 64d315ca-b2dd-48ee-36d6-08d52dc38706 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:(222181515654134);BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(7168020)(4627115)(8989060)(201703031133081)(201702281549075)(8990040)(48565401081)(2017052603258)(7167020);SRVR:CS1PR8401MB0520; x-ms-traffictypediagnostic: CS1PR8401MB0520: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(227479698468861)(42068640409301)(222181515654134); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(3231022)(3002001)(6055026)(6041248)(20161123560025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CS1PR8401MB0520;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CS1PR8401MB0520; x-forefront-prvs: 049486C505 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(376002)(346002)(189002)(24454002)(199003)(2906002)(9686003)(2900100001)(68736007)(105586002)(54906003)(4326008)(101416001)(14454004)(6306002)(6506006)(3660700001)(55016002)(6436002)(81156014)(74316002)(66066001)(3280700002)(106356001)(8936002)(229853002)(33656002)(305945005)(5250100002)(8676002)(345774005)(6116002)(5660300001)(53936002)(966005)(81166006)(102836003)(478600001)(3846002)(7736002)(6246003)(99286004)(39060400002)(2950100002)(6916009)(97736004)(50986999)(7696004)(86362001)(25786009)(55236003)(76176999)(316002)(54356999)(189998001)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR8401MB0520;H:CS1PR8401MB0518.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 64d315ca-b2dd-48ee-36d6-08d52dc38706 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2017 14:00:14.8278 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB0520 X-OriginatorOrg: hpe.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Nov 2017, Vikas C Sajjan wrote: > The platforms which support only IOAPIC mode, pass the SCI information > above the legacy space (0-15) via the FADT mechanism and not via MADT. > In such cases the mp_override_legacy_irq() used by > acpi_sci_ioapic_setup() to register SCI interrupts fails for > interrupts >= 16, since it is meant to handle only legacy space and > throws error "Invalid bus_irq %u for legacy override". Hence add a new > function to handle SCI interrupts >= 16 and invoke it conditionally in > acpi_sci_ioapic_setup().The code duplication due to this new function will be cleaned up in a separate patch. This reads way better, but I have a small nit pick. In the example I gave you there were multiple paragraphs on purpose to separate the different parts. So if I just split the above lump into separate paragraphs: [1] The platforms which support only IOAPIC mode, pass the SCI information above the legacy space (0-15) via the FADT mechanism and not via MADT. [2] In such cases the mp_override_legacy_irq() used by acpi_sci_ioapic_setup() to register SCI interrupts fails for interrupts >= 16, since it is meant to handle only legacy space and throws error "Invalid bus_irq %u for legacy override". [3] Hence add a new function to handle SCI interrupts >= 16 and invoke it conditionally in acpi_sci_ioapic_setup(). [4] The code duplication due to this new function will be cleaned up in a separate patch. then this is clearly structured: [1] describes the context. [2] describes the failure [3] describes the solution [4] is an extra note to tell the reviewer/reader that you are aware of the code duplication and this is addressed later. No need to resend. I can do that when picking it up. Thanks. > Co-developed-by: Sunil V L I had a discussion with Greg about this tag which resulted in a patch so it should be soon part of the official documentation: https://lkml.kernel.org/r/20171116132309.GA8449@kroah.com Great. Good to know that. We agreed that both authors should add their Signed-off-by to document that the work conforms with the Developer Certificate of Origin. I'll add that if that's ok for you. I am OK with that. Please go ahead. Thanks for following up! Thank you for the review. tglx