mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Boylston, Brian" <brian.boylston@hpe.com>
To: "Kani, Toshimitsu" <toshi.kani@hpe.com>,
	"viro@ZenIV.linux.org.uk" <viro@ZenIV.linux.org.uk>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"x86@kernel.org" <x86@kernel.org>,
	"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
	"Moreno, Oliver" <oliver.moreno@hpe.com>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"ross.zwisler@linux.intel.com" <ross.zwisler@linux.intel.com>
Subject: RE: [PATCH] use a nocache copy for bvecs in copy_from_iter_nocache()
Date: Tue, 11 Oct 2016 13:26:07 +0000	[thread overview]
Message-ID: <CS1PR84MB0119D6AB03D91248DAFE0E538EDA0@CS1PR84MB0119.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <1476113071.20881.15.camel@hpe.com>

Kani, Toshimitsu wrote on 2016-10-10:
> On Fri, 2016-10-07 at 18:08 +0100, Al Viro wrote:
>> On Fri, Oct 07, 2016 at 10:55:11AM -0500, Brian Boylston wrote:
>>> 
>>> copy_from_iter_nocache() is only "nocache" for iovecs.  Enhance it
>>> to also use a nocache copy for bvecs.  This improves performance by
>>> 2-3X when splice()ing to a file in a DAX-mounted, pmem-backed file
>>> system.
>> 
>>> 
>>> +static void memcpy_from_page_nocache(char *to, struct page *page,
>>> size_t offset, size_t len)
>>> +{
>>> +	char *from = kmap_atomic(page);
>>> +	__copy_from_user_inatomic_nocache(to, from, len);
>>> +	kunmap_atomic(from);
>>> +}
>> 
>> At the very least, it will blow up on any architecture with split
>> userland and kernel MMU contexts.  You *can't* feed a kernel pointer
>> to things like that and expect it to work.  At the very least, you
>> need to add memcpy_nocache() and have it default to memcpy(), with
>> non-dummy version on x86.  And use _that_, rather than messing with
>> __copy_from_user_inatomic_nocache()
> 
> Good point.  I think we can add memcpy_nocache() which calls
> __copy_from_user_inatomic_nocache() on x86 and defauts to memcpy() on
> other architectures.

Thanks, Al and Toshi, for the feedback.  I'll re-work and come back.

Brian

      reply	other threads:[~2016-10-11 14:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-07 15:55 Brian Boylston
2016-10-07 17:08 ` Al Viro
2016-10-10 15:26   ` Kani, Toshimitsu
2016-10-11 13:26     ` Boylston, Brian [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CS1PR84MB0119D6AB03D91248DAFE0E538EDA0@CS1PR84MB0119.NAMPRD84.PROD.OUTLOOK.COM \
    --to=brian.boylston@hpe.com \
    --cc=dan.j.williams@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@ml01.01.org \
    --cc=mingo@redhat.com \
    --cc=oliver.moreno@hpe.com \
    --cc=ross.zwisler@linux.intel.com \
    --cc=tglx@linutronix.de \
    --cc=toshi.kani@hpe.com \
    --cc=viro@ZenIV.linux.org.uk \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®