From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D635DC7EE24 for ; Thu, 18 May 2023 14:06:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231589AbjEROGa (ORCPT ); Thu, 18 May 2023 10:06:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231591AbjEROG1 (ORCPT ); Thu, 18 May 2023 10:06:27 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4131CE51 for ; Thu, 18 May 2023 07:06:25 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-307d58b3efbso1397987f8f.0 for ; Thu, 18 May 2023 07:06:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684418784; x=1687010784; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=azqpCVnd/614+AfKRHDl6hN6ez5a51IoobwFr9W5qBQ=; b=h+GRLvpVsV6qF+yhQyC+9b89tOnb+IO73WPsf/PENnlj/jBn9IHDnS3KG2cpxTAoSi ix13lFUJ/6yah6rp5/iuHqJzworFHDCDRWlmVTJfPoIyi/b8ZQWsq7QGGwXxS3MgKR5b lxVSwmnxQIbRUscKxLYp1u/pdm+ggnBOTSW6oFHFM6nnLsAoAL8a3GI8E3kjQK+xlHIo eNomgcLsFD3Byhthgx2JOBp3d81/Qf2/lXHfkszJkGuHG0EovhpGJeXYXJ16T8GiKbaF JTwccEgIFv27bd9bxEelXasc/qEmPjALXS/fhVMT625offvc0Gb7VwOivbAqiwudCXRu 7iYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684418784; x=1687010784; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=azqpCVnd/614+AfKRHDl6hN6ez5a51IoobwFr9W5qBQ=; b=aAb8WH3cowNMjvmHEBwy76tBYP43hLsmoLjJuhU+yhs6i+iysMvfcVLhiSRm1VWE7M zmBXhfOJEILh0z1WupMcJRrpV8SCTAHS+nGfxTgjY4af1tvlJzI1mH7/OQ4INrMnyWn8 k0C/Gl7bQHrFYBXwxADmJSI8FI8ujVHD22sax7BOep34a3vkBa9j5pXiwGSvjmfjinXp lGxAo8fTyGK2f73e9CIcyGn582Ifap1ga2d/TiBEadXP7+5zxd2CVf0mozhT079KeyWe odensoHtDxyXB3EIzhz47KEffD386EM140lQP0/9dRqEGZEHlkMNwq5ruZLLjTgzoX8n jGoQ== X-Gm-Message-State: AC+VfDxSK6+xOwb8TXjJ7iY+wDvx3jAEnwwb0cPVS0Ho09LCinDnH30z JR1frp3c8T0LC4aBogNVM4izCA== X-Google-Smtp-Source: ACHHUZ7G56jeX+RtKQ3jgdBRAl+/CNsoOO6ryL3IsYzeTnzcHLO0SRpVzbHO+rNNmTHmhy28FkvR+w== X-Received: by 2002:a05:6000:1245:b0:2ef:b19f:b24c with SMTP id j5-20020a056000124500b002efb19fb24cmr2059445wrx.0.1684418783660; Thu, 18 May 2023 07:06:23 -0700 (PDT) Received: from localhost (cpc76484-cwma10-2-0-cust274.7-3.cable.virginm.net. [82.31.201.19]) by smtp.gmail.com with ESMTPSA id n16-20020a1c7210000000b003f19b3d89e9sm5389587wmc.33.2023.05.18.07.06.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 May 2023 07:06:23 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 18 May 2023 15:06:22 +0100 Message-Id: Cc: , , , , <~postmarketos/upstreaming@lists.sr.ht>, , Subject: Re: [PATCH v3 3/3] arm64: dts: qcom: sdm845-shift-axolotl: enable flash LEDs From: "Caleb Connolly" To: "Dylan Van Assche" , , , , , , , , , X-Mailer: aerc 0.15.1 References: <20230518133113.273880-1-me@dylanvanassche.be> <20230518133113.273880-4-me@dylanvanassche.be> In-Reply-To: <20230518133113.273880-4-me@dylanvanassche.be> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu May 18, 2023 at 2:31 PM BST, Dylan Van Assche wrote: > The SHIFT6mq (axolotl) is an SDM845-based smartphone with 2 flash LEDs. > One LED is white, the other one is yellow. Define both LEDs in the DTS > so they can be used as flash or torch and enable the flash LED > controller to control them in PMI8998. > > Signed-off-by: Dylan Van Assche > Reviewed-by: Konrad Dybcio Reviewed-by: Caleb Connolly // Caleb (they/them) > --- > .../boot/dts/qcom/sdm845-shift-axolotl.dts | 22 +++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm= 64/boot/dts/qcom/sdm845-shift-axolotl.dts > index 0ad891348e0c..1eaff964b202 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts > @@ -554,6 +554,28 @@ led@5 { > }; > }; > =20 > +&pmi8998_flash { > + status =3D "okay"; > + > + led-0 { > + function =3D LED_FUNCTION_FLASH; > + color =3D ; > + led-sources =3D <1>; > + led-max-microamp =3D <100000>; > + flash-max-microamp =3D <1100000>; > + flash-max-timeout-us =3D <1280000>; > + }; > + > + led-1 { > + function =3D LED_FUNCTION_FLASH; > + color =3D ; > + led-sources =3D <2>; > + led-max-microamp =3D <100000>; > + flash-max-microamp =3D <1100000>; > + flash-max-timeout-us =3D <1280000>; > + }; > +}; > + > &qup_uart9_rx { > drive-strength =3D <2>; > bias-pull-up;