From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68798C83005 for ; Fri, 9 Jun 2023 15:37:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241689AbjFIPhs (ORCPT ); Fri, 9 Jun 2023 11:37:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241659AbjFIPhp (ORCPT ); Fri, 9 Jun 2023 11:37:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9B4F30FD; Fri, 9 Jun 2023 08:37:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 66F8D60AE9; Fri, 9 Jun 2023 15:37:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5914BC433EF; Fri, 9 Jun 2023 15:37:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686325063; bh=sIw718I/KXUMK63ArYX4Z1Gqc0mVqjNsTiETfGIXXgw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HfbfaDNiJ+6R7zOa3SNtnWIhqUqMcjZslTOTfFzjNnvyI5QOYro+xqb2Ofrf+GgtY yRDYeWSs0JMcgveGOoTKiNpCk7xqfDlpd2QIZbCgBYNj/laEveGgIPLz7dTFtuRti5 UX7dYtSdXVtt+tjTFINSo9hSGPCMmWyCTe91p3AdCw4KolQom719SHEtLCY+hZAWsQ N7yKYetxKB2duPvNGgFVbBicWFGlUNku6K00u2MiLP8LIxOh9NMk8jgm5qFCfMsl46 AJQiFeDxR8Mzehxpc5DtvBDv7ngGEESPc4/ZEP4AseithSjAnH8Pgw/s5TwREZsDjn +7HDjWoJ8gBOA== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 09 Jun 2023 18:37:37 +0300 Message-Id: From: "Jarkko Sakkinen" To: "Dan Carpenter" Cc: "Bagas Sanjaya" , "Franziska Naepelt" , , , , , "Franziska Naepelt" , "kernel test robot" , "Linux SPDX Licenses" , "Linux Kernel Janitors" Subject: Re: [PATCH v2] certs/extract-cert: Fix checkpatch issues X-Mailer: aerc 0.14.0 References: <20230601190508.56610-1-franziska.naepelt@gmail.com> <20230602085902.59006-1-franziska.naepelt@gmail.com> In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri Jun 9, 2023 at 5:01 PM EEST, Dan Carpenter wrote: > On Tue, Jun 06, 2023 at 05:51:09PM +0300, Jarkko Sakkinen wrote: > > It's not a "punishment". It's more like that I really have to take the > > time to read the prose... > > The thing about imperative tense is that it was used as a punishment on > me once five years ago. I wrote a quite bad commit message and a senior > maintainer told me to re-write it properly and I realized that it was > true. My commit message was bad. So I wrote a proper commit message. > And then he yelled at me, "Can't you follow simple directions and write > it in imperative tense like the documentation says? Are you a > shithead?" Wow :-O I'm totally against name calling or any sort of shittiness like that, and all for co-operation. Just told my personal thoughts on the matter. I'm sorry that this happened to you. > > So then I swore I would never talk to him again or to anyone who > enforced the imperative tense rule. That has only happened once in the > intervening years. I told the maintainer, "Fine. Re-write the commit > message however you like and give me Reported-by credit." This was a > cheeky response and it made the maintainer enraged. I guess he thought > that my boss would force me to fix the bug or something? I felt bad for > the Intel developer who had to fix my bug instead because I knew that > the maintainer was going to be super angry if he gave me reported-by > credit so I had put him in a bind. I almost re-wrote the commit message > so that he wouldn't have to deal with that. Maybe this is how mothers > feel when they try to take abuse from an angry husband instead of > letting their kids suffer. But I am a bad mother and I left. > > My boss would never have forced me to deal with that. When he left for > a different company he said, "Dan, I'm transitioning and XXX is taking > over me and I have told him all your weirdness so he is prepared." And > it was a huge comfort to me because I know what my weakness are. > > You people on this thread all seem super nice. And you're right that we > should always try to be improve every aspect of our craft. > > When Jarkko talked about people who write too long commit messages, I > thought about one developer in particular who writes too long commit > messages. He writes in imperative tense. He takes everything so > seriously and he's never seen a rule without following it. His patches > are always right. People have told him that his commit messages are bad > and too long and those people are right. But they need to shut up. The > good things that he does and the bad things that he does are all part of > the same package. He can't change and I don't want him to feel anything > but welcome. > > It's hard to be a good kernel developer without being at least slightly > obsessive. Both developers and maintainers are that way. And I deal > with a lot of people and accomodating maintainers you disagree with is > part of the job. > > So long as everyone is kind to each other. That's the main thing. I 110% agree with this. I even bookmarked this response :-) > regards, > dan carpenter BR, Jarkko