From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2307FC41513 for ; Wed, 16 Aug 2023 20:17:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346069AbjHPUQ0 (ORCPT ); Wed, 16 Aug 2023 16:16:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346100AbjHPUQP (ORCPT ); Wed, 16 Aug 2023 16:16:15 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 644B91FE3; Wed, 16 Aug 2023 13:16:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ED11A63161; Wed, 16 Aug 2023 20:16:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C3AEC433C7; Wed, 16 Aug 2023 20:16:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692216973; bh=RwMfdQoVMocHV8lsm9MWMyQ8RwAc9ankzFYtPPXLPQw=; h=Date:Cc:Subject:From:To:References:In-Reply-To:From; b=VTpMfbLkk3vKzcRHHAH+kqW0nDku7T7ICuxUnDpJw/wqY8DqklTKEKWYdpkzDtnvU TzRQTx2kw+C7pmmYTYxScIlLU0AHH0rZfgYzYvLWpDfLnLGy9FHbrlTT/eQ5FNAzra ZnN3WaWm1N/X2hedmAJyzM3ZJjIarXlCRI//ScRPWW/r+fhejxDWQqVpjZWE1ZsfA1 rfnm/3SEZTzDGn94GehDsfWWBPsMtGuscnscvNbX0uPzb64R/oeNY0N1OpMaV0FmY/ 4sg4Hif72Ud0HrbRMMtLlNDt78P1Cf/yUQMMck+XAbeNm8NywUWwQGgTiOYLt+9vJB NpagraTM73ihA== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 16 Aug 2023 23:16:08 +0300 Message-Id: Cc: , "Jonathan Corbet" , "Peter Huewe" , "Jason Gunthorpe" , "Richard Cochran" , "Paul E. McKenney" , "Catalin Marinas" , "Randy Dunlap" , "Dave Hansen" , "Steven Rostedt (Google)" , "Daniel Sneddon" , , , Subject: Re: [PATCH] tpm_tis: Revert "tpm_tis: Disable interrupts on ThinkPad T490s" From: "Jarkko Sakkinen" To: "Jerry Snitselaar" X-Mailer: aerc 0.14.0 References: <20230814164054.64280-1-jarkko@kernel.org> In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue Aug 15, 2023 at 2:13 AM EEST, Jerry Snitselaar wrote: > On Mon, Aug 14, 2023 at 07:40:53PM +0300, Jarkko Sakkinen wrote: > > Since for MMIO driver using FIFO registers, also known as tpm_tis, the > > default (and tbh recommended) behaviour is now the polling mode, the > > "tristate" workaround is no longer for benefit. > >=20 > > If someone wants to explicitly enable IRQs for a TPM chip that should b= e > > without question allowed. It could very well be a piece hardware in the > > existing deny list because of e.g. firmware update or something similar= . > >=20 > > While at it, document the module parameter, as this was not done in 200= 6 > > when it first appeared in the mainline. > >=20 > > Link: https://lore.kernel.org/linux-integrity/20201015214430.17937-1-js= nitsel@redhat.com/ > > Link: https://lore.kernel.org/all/1145393776.4829.19.camel@localhost.lo= caldomain/ > > Signed-off-by: Jarkko Sakkinen > > I was just typing an email to say that it looks like 6aaf663ee04a ("tpm_t= is: Opt-in interrupts") will require > updating tpm_tis_disable_irq(), but you are already dealing with it. :) > > Reviewed-by: Jerry Snitselaar Thanks! BR, Jarkko