From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BA0EC71159 for ; Fri, 18 Aug 2023 17:01:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378867AbjHRRA4 (ORCPT ); Fri, 18 Aug 2023 13:00:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378872AbjHRRAl (ORCPT ); Fri, 18 Aug 2023 13:00:41 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6650C3C3D; Fri, 18 Aug 2023 10:00:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F1FF560DBB; Fri, 18 Aug 2023 17:00:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA405C433C8; Fri, 18 Aug 2023 17:00:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692378039; bh=U1lILcAAq6UqewmXOvmloUOdvzlXGMCiCEEtq7k0bP4=; h=Date:To:Cc:Subject:From:References:In-Reply-To:From; b=heO6ejZgXvKlne4AE7aDAuQTwpmdv9xjFjMNAmANXO3oEv2wWvOT7R+/35fXyM0Ws rrMkF25NXQ+0MWr61C+ng3lnjEedLmeewFpCcFQM+Cba0kkBrEhtcVIjQ7F8c14Gr5 u5WxZLpNZavLjVpL3LiMg1cNl8FT2FI3DlhN8zwf071W7N96stdbat+v7KwAfq/LnK As9VbaIZScS9x5//JEt+v10pZd9X9vH92G9HQwMZZ8eaBN38ymIVFzej6s8R/5btjt ZtC5o+O4buOq4PDR+WKn7XJVBRDQ2EGPca6y0jnnfPf9nP4XOxZr5hhAMVg9rv9PCT ECWAOFY1gxKow== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 18 Aug 2023 20:00:35 +0300 Message-Id: To: "Limonciello, Mario" , , Cc: , , , Subject: Re: REGRESSION WITH BISECT: v6.5-rc6 TPM patch breaks S3 on some Intel systems From: "Jarkko Sakkinen" X-Mailer: aerc 0.14.0 References: <485e8740385239b56753ce01d8995f01f84a68e5.camel@linux.intel.com> <5a344d1ffa66fac828feb3d1c6abce010da94609.camel@linux.intel.com> In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri Aug 18, 2023 at 4:58 AM EEST, Limonciello, Mario wrote: > > > On 8/17/2023 5:33 PM, Jarkko Sakkinen wrote: > > On Fri Aug 18, 2023 at 1:25 AM EEST, Todd Brandt wrote: > >> On Fri, 2023-08-18 at 00:47 +0300, Jarkko Sakkinen wrote: > >>> On Fri Aug 18, 2023 at 12:09 AM EEST, Todd Brandt wrote: > >>>> While testing S3 on 6.5.0-rc6 we've found that 5 systems are seeing > >>>> a > >>>> crash and reboot situation when S3 suspend is initiated. To > >>>> reproduce > >>>> it, this call is all that's required "sudo sleepgraph -m mem > >>>> -rtcwake > >>>> 15". > >>> > >>> 1. Are there logs available? > >>> 2. Is this the test case: https://pypi.org/project/sleepgraph/ (never > >>> used it before). > >> > >> There are no dmesg logs because the S3 crash wipes them out. Sleepgrap= h > >> isn't actually necessary to activate it, just an S3 suspend "echo mem = > > >> /sys/power/state". > >> > >> So far it appears to only have affected test systems, not production > >> hardware, and none of them have TPM chips, so I'm beginning to wonder > >> if this patch just inadvertently activated a bug somewhere else in the > >> kernel that happens to affect test hardware. > >> > >> I'll continue to debug it, this isn't an emergency as so far I haven't > >> seen it in production hardware. > >=20 > > OK, I'll still see if I could reproduce it just in case. > >=20 > > BR, Jarkko > > I'd like to better understand what kind of TPM initialization path has=20 > run. Does the machine have some sort of TPM that failed to fully=20 > initialize perhaps? > > If you can't share a full bootup dmesg, can you at least share > > # dmesg | grep -i tpm It would be more useful perhaps to get full dmesg output after power on and before going into suspend. Also ftrace filter could be added to the kernel command-line: ftrace=3Dfunction ftrace_filter=3Dtpm* After bootup: mount -t tracefs nodev /sys/kernel/tracing cat /sys/kernel/tracing/trace BR, Jarkko