From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Jo Van Bulck" <jo.vanbulck@cs.kuleuven.be>,
<kai.huang@intel.com>, <linux-sgx@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: <dave.hansen@linux.intel.com>
Subject: Re: [PATCH v3 8/9] selftests/sgx: Separate linker options
Date: Tue, 22 Aug 2023 13:11:56 +0300 [thread overview]
Message-ID: <CUYZRAU5D4UV.MSTZCT24FHV7@suppilovahvero> (raw)
In-Reply-To: <20230819094332.8535-9-jo.vanbulck@cs.kuleuven.be>
On Sat Aug 19, 2023 at 12:43 PM EEST, Jo Van Bulck wrote:
> Fixes "'linker' input unused [-Wunused-command-line-argument]" errors when
> compiling with clang.
>
> Signed-off-by: Jo Van Bulck <jo.vanbulck@cs.kuleuven.be>
> ---
> tools/testing/selftests/sgx/Makefile | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/tools/testing/selftests/sgx/Makefile b/tools/testing/selftests/sgx/Makefile
> index 1d6315a2e..2de970f72 100644
> --- a/tools/testing/selftests/sgx/Makefile
> +++ b/tools/testing/selftests/sgx/Makefile
> @@ -12,9 +12,11 @@ OBJCOPY := $(CROSS_COMPILE)objcopy
> endif
>
> INCLUDES := -I$(top_srcdir)/tools/include
> -HOST_CFLAGS := -Wall -Werror -g $(INCLUDES) -fPIC -z noexecstack
> +HOST_CFLAGS := -Wall -Werror -g $(INCLUDES) -fPIC
> +HOST_LDFLAGS := -z noexecstack -lcrypto
> ENCL_CFLAGS := -Wall -Werror -static-pie -nostdlib -nostartfiles -fPIE \
> -fno-stack-protector -mrdrnd $(INCLUDES)
> +ENCL_LDFLAGS := -Wl,-T,test_encl.lds,--build-id=none
>
> TEST_CUSTOM_PROGS := $(OUTPUT)/test_sgx
> TEST_FILES := $(OUTPUT)/test_encl.elf
> @@ -28,7 +30,7 @@ $(OUTPUT)/test_sgx: $(OUTPUT)/main.o \
> $(OUTPUT)/sigstruct.o \
> $(OUTPUT)/call.o \
> $(OUTPUT)/sign_key.o
> - $(CC) $(HOST_CFLAGS) -o $@ $^ -lcrypto
> + $(CC) $(HOST_CFLAGS) -o $@ $^ $(HOST_LDFLAGS)
>
> $(OUTPUT)/main.o: main.c
> $(CC) $(HOST_CFLAGS) -c $< -o $@
> @@ -45,8 +47,8 @@ $(OUTPUT)/call.o: call.S
> $(OUTPUT)/sign_key.o: sign_key.S
> $(CC) $(HOST_CFLAGS) -c $< -o $@
>
> -$(OUTPUT)/test_encl.elf: test_encl.lds test_encl.c test_encl_bootstrap.S
> - $(CC) $(ENCL_CFLAGS) -T $^ -o $@ -Wl,--build-id=none
> +$(OUTPUT)/test_encl.elf: test_encl.c test_encl_bootstrap.S
> + $(CC) $(ENCL_CFLAGS) $^ -o $@ $(ENCL_LDFLAGS)
>
> EXTRA_CLEAN := \
> $(OUTPUT)/test_encl.elf \
> --
> 2.25.1
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
BR, Jarkko
next prev parent reply other threads:[~2023-08-22 10:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-19 9:43 [PATCH v3 0/9] selftests/sgx: Fix compilation errors Jo Van Bulck
2023-08-19 9:43 ` [PATCH v3 1/9] selftests/sgx: Fix uninitialized pointer dereference in error path Jo Van Bulck
2023-08-19 9:43 ` [PATCH v3 2/9] selftests/sgx: Produce static-pie executable for test enclave Jo Van Bulck
2023-08-22 0:26 ` Huang, Kai
2023-08-23 13:19 ` Jo Van Bulck
2023-08-19 9:43 ` [PATCH v3 3/9] selftests/sgx: Handle relocations in " Jo Van Bulck
2023-08-22 1:11 ` Huang, Kai
2023-08-25 13:27 ` Jo Van Bulck
2023-08-22 10:08 ` Jarkko Sakkinen
2023-08-19 9:43 ` [PATCH v3 4/9] selftests/sgx: Fix linker script asserts Jo Van Bulck
2023-08-22 10:09 ` Jarkko Sakkinen
2023-08-19 9:43 ` [PATCH v3 5/9] selftests/sgx: Include memory clobber for inline asm in test enclave Jo Van Bulck
2023-08-22 10:10 ` Jarkko Sakkinen
2023-08-19 9:43 ` [PATCH v3 6/9] selftests/sgx: Ensure test enclave buffer is entirely preserved Jo Van Bulck
2023-08-21 11:10 ` Huang, Kai
2023-08-22 10:10 ` Jarkko Sakkinen
2023-08-19 9:43 ` [PATCH v3 7/9] selftests/sgx: Ensure expected location of test enclave buffer Jo Van Bulck
2023-08-21 11:10 ` Huang, Kai
2023-08-22 10:11 ` Jarkko Sakkinen
2023-08-19 9:43 ` [PATCH v3 8/9] selftests/sgx: Separate linker options Jo Van Bulck
2023-08-22 10:11 ` Jarkko Sakkinen [this message]
2023-08-19 9:43 ` [PATCH v3 9/9] selftests/sgx: Specify freestanding environment for enclave compilation Jo Van Bulck
2023-08-22 10:14 ` Jarkko Sakkinen
2023-08-23 12:57 ` Jo Van Bulck
2023-08-23 17:31 ` Jarkko Sakkinen
2023-08-22 10:31 ` [PATCH v3 0/9] selftests/sgx: Fix compilation errors Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CUYZRAU5D4UV.MSTZCT24FHV7@suppilovahvero \
--to=jarkko@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=jo.vanbulck@cs.kuleuven.be \
--cc=kai.huang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®