mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: <chenguohua@jari.cn>, <dhowells@redhat.com>
Cc: <keyrings@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] KEYS: Clean up errors in key.h
Date: Mon, 23 Oct 2023 22:59:35 +0300	[thread overview]
Message-ID: <CWG330WZCFGQ.35L0OJ29CT08S@suppilovahvero> (raw)
In-Reply-To: <1f5f72f6.936.18b2322e256.Coremail.chenguohua@jari.cn>

On Thu Oct 12, 2023 at 12:06 PM EEST,  wrote:
> Fix the following errors reported by checkpatch:
>
> ERROR: space required before the open parenthesis '('
>
> Signed-off-by: GuoHua Cheng <chenguohua@jari.cn>

So what was the patch?

> ---
>  include/linux/key.h | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/include/linux/key.h b/include/linux/key.h
> index 938d7ecfb495..48a43c9efaed 100644
> --- a/include/linux/key.h
> +++ b/include/linux/key.h
> @@ -503,18 +503,18 @@ extern void key_init(void);
>  #define key_validate(k)			0
>  #define key_serial(k)			0
>  #define key_get(k) 			({ NULL; })
> -#define key_revoke(k)			do { } while(0)
> -#define key_invalidate(k)		do { } while(0)
> -#define key_put(k)			do { } while(0)
> -#define key_ref_put(k)			do { } while(0)
> +#define key_revoke(k)			do { } while (0)
> +#define key_invalidate(k)		do { } while (0)
> +#define key_put(k)			do { } while (0)
> +#define key_ref_put(k)			do { } while (0)
>  #define make_key_ref(k, p)		NULL
>  #define key_ref_to_ptr(k)		NULL
>  #define is_key_possessed(k)		0
> -#define key_fsuid_changed(c)		do { } while(0)
> -#define key_fsgid_changed(c)		do { } while(0)
> -#define key_init()			do { } while(0)
> -#define key_free_user_ns(ns)		do { } while(0)
> -#define key_remove_domain(d)		do { } while(0)
> +#define key_fsuid_changed(c)		do { } while (0)
> +#define key_fsgid_changed(c)		do { } while (0)
> +#define key_init()			do { } while (0)
> +#define key_free_user_ns(ns)		do { } while (0)
> +#define key_remove_domain(d)		do { } while (0)
>  
>  #endif /* CONFIG_KEYS */
>  #endif /* __KERNEL__ */

BR, Jarkko

      reply	other threads:[~2023-10-23 19:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-12  9:06 chenguohua
2023-10-23 19:59 ` Jarkko Sakkinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CWG330WZCFGQ.35L0OJ29CT08S@suppilovahvero \
    --to=jarkko@kernel.org \
    --cc=chenguohua@jari.cn \
    --cc=dhowells@redhat.com \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®