From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE284C27C46 for ; Fri, 27 Oct 2023 10:07:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345606AbjJ0KHR (ORCPT ); Fri, 27 Oct 2023 06:07:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231463AbjJ0KHN (ORCPT ); Fri, 27 Oct 2023 06:07:13 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A0E5191 for ; Fri, 27 Oct 2023 03:07:11 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-9ba1eb73c27so296953766b.3 for ; Fri, 27 Oct 2023 03:07:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1698401230; x=1699006030; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=W2ttGxsEpCovYo5WGBI/2wLRWRua0I9N3WCMj8o9qdk=; b=lBmY1PeYgZfGZHhF2ipQeifDPJfHLIZueGkvb1MqXm55J+e6PLu5WRwxrfCYj4Z+WT R8Z8LTQm7nmaHSF+TF7NPXQW/xsOKL/cJSN7sjj+l2mOWeI3Zn9xcET+a6f9E605Uq45 wY9ivoR9cFfTvJvD58GDUMCi9/d8X4QqxG7wN2YlmzYo3F66oO/rvNZ2vmsH9E/egQz7 9U1I0fP0VVequ70rYdnKpTuUg0gWctPjqKUP4yrf3abfWu8XKIhSNWXkve2cQFtccv1g BCZNWRQ1TG6J3sJvYj8Gk/FZiz1sn5fpx3hdIohc/gg1A2NGR3y9K435/Bwq4V+QbiOo V0+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698401230; x=1699006030; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=W2ttGxsEpCovYo5WGBI/2wLRWRua0I9N3WCMj8o9qdk=; b=FIxHZIf/4dvw5CXXfe5iNbEp6XXdZxOYw2wPuBX3WVMXyZRJTYn13gKI+us2dFVepI NwAi30nqNyxu1GUsW9yDuOqfMbqX+/QqdDCnxyEnNy44MnrKCDAkRYLDADKlp4FSvUZk DZt+G9E/cLvyeB3UYLiTtEt9bN0wHifXJyrE1nQ6EtTzmPA78IdYnsDkorASW5OEhMiQ bEybXf4W1WXynljGMohrEl0AIvt41VAwJwDxBHvwmBi4NdMki5Qj9AqgxsAc30K7BWIY LYzh8+Km0T48qGvXBbSQAFpGsp+Q6aOe8M0nHD1I9Bkl1Emkf3YyNDI/YpaNpODFusMa Q5NA== X-Gm-Message-State: AOJu0Ywd6XWGGcY3bt2F4I2dQI6gdPGVD5lKTnxXFMc3O2IAiuIAWKPa QvTpKIesDw1QdiMVkVPvhNsoRw== X-Google-Smtp-Source: AGHT+IHwXW32IKOGavGwueMqyskdd7p7jS6bw8H7bAFEFW4DJTD6sjtVirXz5fvBiW1yOPC8GSFVTQ== X-Received: by 2002:a17:906:fe4c:b0:9be:2991:81fa with SMTP id wz12-20020a170906fe4c00b009be299181famr1956326ejb.39.1698401229965; Fri, 27 Oct 2023 03:07:09 -0700 (PDT) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id c16-20020a1709060fd000b0099cb349d570sm949317ejk.185.2023.10.27.03.07.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Oct 2023 03:07:09 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 27 Oct 2023 12:07:09 +0200 Message-Id: Cc: "Jeff Johnson" , <~postmarketos/upstreaming@lists.sr.ht>, , , , , Subject: Re: [PATCH] wifi: ath11k: Defer on rproc_get failure From: "Luca Weiss" To: "Kalle Valo" X-Mailer: aerc 0.15.2 References: <20231027-ath11k-rproc-defer-v1-1-f6b6a812cd18@fairphone.com> <87lebowjyf.fsf@kernel.org> In-Reply-To: <87lebowjyf.fsf@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri Oct 27, 2023 at 10:25 AM CEST, Kalle Valo wrote: > Luca Weiss writes: > > > If we already have gotten the rproc_handle (meaning the "qcom,rproc" > > property is defined in the devicetree), it's a valid state that the > > remoteproc module hasn't probed yet so we should defer probing instead > > of just failing to probe. > > > > This resolves a race condition when the ath11k driver probes and fails > > before the wpss remoteproc driver has probed, like the following: > > > > [ 6.232360] ath11k 17a10040.wifi: failed to get rproc > > [ 6.232366] ath11k 17a10040.wifi: failed to get rproc: -22 > > [ 6.232478] ath11k: probe of 17a10040.wifi failed with error -22 > > ... > > [ 6.252415] remoteproc remoteproc2: 8a00000.remoteproc is availabl= e > > [ 6.252776] remoteproc remoteproc2: powering up 8a00000.remoteproc > > [ 6.252781] remoteproc remoteproc2: Booting fw image qcom/qcm6490/= fairphone5/wpss.mdt, size 7188 > > > > So, defer the probe if we hit that so we can retry later once the wpss > > remoteproc is available. > > > > Signed-off-by: Luca Weiss > > Did you test this on a real device? If yes, what ath11k hardware and firm= ware > did you use? We use Tested-on tag to document that: > > https://wireless.wiki.kernel.org/en/users/drivers/ath11k/submittingpatche= s#tested-on_tag Hi, Yes I tested this on qcm6490-fairphone-fp5 including some extra patches for wpss-pas remoteproc support (nothing special, just adding it to the existing PAS driver) and wifi enablement in dts. I built this line from info from the dmesg, hope it's okay: Tested-on: wcn6750 hw1.0 AHB WLAN.MSL.1.0.1-01264-QCAMSLSWPLZ-1.37886.3 And thinking about it, a Fixes tag would also be appropriate for this patch. The code was moved to a different file in commit ba929d6fe31a ("ath11k: Remove rproc references from common core layer") but I think this tag should be correct. Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") > > I can add that in the pending branch if you provide the info. Thanks! Regards Luca