mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yusef Aslam <yuzi54780@outlook.com>
To: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Staging: rtl8192e: rtllib_rx: fix alignment
Date: Thu, 27 Jun 2024 09:06:48 +0100	[thread overview]
Message-ID: <CWLP265MB651633F722342DFB3F923799FDD72@CWLP265MB6516.GBRP265.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <4b489362-7714-4d96-b6a1-50d627b15319@gmail.com>

On Wed, 2024-06-26 at 19:32 +0200, Philipp Hortmann wrote:
> On 6/26/24 14:56, Yusef Aslam wrote:
> Hi Yusef,

Hi Philipp.

> The patch can be applied. Thanks for the change history.
> 
> But your patch description is not answering the why.
> 
> It could be: Fix alignment to increase readabiltiy.
> 
> For the first patch this is way to long and the indentations are
> really 
> a mess. Issue is that lines then get to long which leads again to 
> checkpatch issues. Please find some of my comments below.

Thank you for your comments and advice. They help me alot.

  reply	other threads:[~2024-06-27  8:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-26 12:56 Yusef Aslam
2024-06-26 17:32 ` Philipp Hortmann
2024-06-27  8:06   ` Yusef Aslam [this message]
2024-06-27 13:43 ` Greg KH
2024-06-27 18:09   ` Yusef Aslam
2024-06-29 23:54     ` Bagas Sanjaya
2024-06-30  7:36       ` Philipp Hortmann
2024-06-30  8:31         ` Yusef Aslam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CWLP265MB651633F722342DFB3F923799FDD72@CWLP265MB6516.GBRP265.PROD.OUTLOOK.COM \
    --to=yuzi54780@outlook.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=philipp.g.hortmann@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®