From: "Simon Holesch" <simon@holesch.de>
To: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: "Valentina Manea" <valentina.manea.m@gmail.com>,
"Shuah Khan" <shuah@kernel.org>, "Hongren Zheng" <i@zenithal.me>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] usbip: Don't submit special requests twice
Date: Wed, 06 Dec 2023 05:57:37 +0100 [thread overview]
Message-ID: <CXGZGEBGA58J.3CX7BKVV2EUHK@holesch.de> (raw)
In-Reply-To: <2023120641-krypton-presume-a375@gregkh>
On Wed Dec 6, 2023 at 4:38 AM CET, Greg Kroah-Hartman wrote:
> On Fri, Dec 01, 2023 at 12:10:13AM +0100, Simon Holesch wrote:
> > - if (usb_lock_device_for_reset(sdev->udev, NULL) < 0) {
> > + err = usb_lock_device_for_reset(sdev->udev, NULL)
>
> You didn't actually build this change, so how was it tested?
Last thing I did was update the comment of tweak_special_requests().
Must have hit undo once too often, because I've seen (and fixed) this
error. Really sorry about that. I'll send a v4 with a detailed test
description.
Simon
> {sigh}
>
> greg k-h
next prev parent reply other threads:[~2023-12-06 5:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 23:10 Simon Holesch
2023-12-04 18:19 ` Shuah Khan
2023-12-06 3:38 ` Greg Kroah-Hartman
2023-12-06 4:57 ` Simon Holesch [this message]
2023-12-06 7:00 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CXGZGEBGA58J.3CX7BKVV2EUHK@holesch.de \
--to=simon@holesch.de \
--cc=gregkh@linuxfoundation.org \
--cc=i@zenithal.me \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®