From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 202674C60B for ; Thu, 11 Jan 2024 15:28:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="3UJA2fLt" Received: by mail-ed1-f68.google.com with SMTP id 4fb4d7f45d1cf-557a3ce9942so5749600a12.1 for ; Thu, 11 Jan 2024 07:28:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1704986906; x=1705591706; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=B7mE+52tIHuQGxlPUuwMMzBM9GxGpHPAmvjX828iiAI=; b=3UJA2fLt8ao7qa7PJpFFX89y4/NzY91dQdlWmuu2JcDf2fGp7WD6d/HJ5V3VxagBBg jSlhJFDWGqNp55VCfjzI7ftJJjYgV2zfT/G+SULL18+ycirnZKHaUsZgCSk5XMERIQB5 3ctP07jkt2i+IboO8vrkCVlt8Q7xTRQHo4onn6YeFLKxweN6Y5MtS+lbrp15zC67uCkk a4uc5DHKZL2YBgXhcC6lgk4/AbbWmT5T+6oXFr/Pq1p8hOu3pu0DaxVUso6v66kdaoEr MSX5Q5vmiEYjZYpkhdspCA7kyVGaZol2IMtLaQwEJQDmrFnpK1PkL/HxomPc+UCGFrqi 4XKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704986906; x=1705591706; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=B7mE+52tIHuQGxlPUuwMMzBM9GxGpHPAmvjX828iiAI=; b=TAv1QMf6MiB7grxp9iYPnhz/izqVaQZBT5xqlZ3hBXIjamLGkwQr7H98cwxmng76zz PtH4lQVJlVmHs2j0269Y54RQjudwlS9DdO+3V+HoU9hKxDYGuB5ZSYhI0knQGfz+Ya/K 5Oz62J4kILKSyXe3vfj/6jboNUAu0yrZUgNrJfwMnOIPA/3ExyESsG/qui2RurrAG0lS LQKuaTRp+F9ekL4dZs07RtIixUI5ixIyz6SqBoMhU6X+SXgfdumO+1vaM9wXGhvpU/xi kBpephRXAAhgNbpjNU6cAqS+OHrCDbT/kQCSruSQXmVlDm4Nqb1FMN1Qh6a6Vr7vYwhr kCcA== X-Gm-Message-State: AOJu0YwAE0zjYopsZzdeTVAxn38br1JPhlsimttRtlYMVXn3lp/+Uk+S 5x5mnmAsECp5QlMtEoWcNQQiIm2N4f6ylA== X-Google-Smtp-Source: AGHT+IFrvzkgvZxDk2Qj4HTlNXeH9Cg5K5scTvQ7rSicpxuLzRPig/wdkeNZZxH3cj4lmdNGi3b+9Q== X-Received: by 2002:aa7:d403:0:b0:558:b988:b8dc with SMTP id z3-20020aa7d403000000b00558b988b8dcmr33261edq.84.1704986906349; Thu, 11 Jan 2024 07:28:26 -0800 (PST) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id m23-20020a50ef17000000b0055751515a84sm717753eds.51.2024.01.11.07.28.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jan 2024 07:28:26 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 11 Jan 2024 16:28:24 +0100 Message-Id: Cc: "Neil Armstrong" , "Jessica Zhang" , "Sam Ravnborg" , "David Airlie" , "Daniel Vetter" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Bjorn Andersson" , "Konrad Dybcio" , "Andy Gross" , , , , , <~postmarketos/upstreaming@lists.sr.ht>, Subject: Re: [PATCH v2 2/4] drm/panel: Add driver for DJN HX83112A LCD panel From: "Luca Weiss" To: "Linus Walleij" X-Mailer: aerc 0.15.2 References: <20240110-fp4-panel-v2-0-8ad11174f65b@fairphone.com> <20240110-fp4-panel-v2-2-8ad11174f65b@fairphone.com> In-Reply-To: On Thu Jan 11, 2024 at 3:57 PM CET, Linus Walleij wrote: > On Wed, Jan 10, 2024 at 4:14=E2=80=AFPM Luca Weiss wrote: > > > Add support for the 2340x1080 LCD DJN panel bundled with a HX83112A > > driver IC, as found on the Fairphone 4 smartphone. > > > > Signed-off-by: Luca Weiss > > This makes it sound like the Himax HX83112A is the driver IC. > > This does not seem to be the case: > https://github.com/HimaxSoftware/HX83112_Android_Driver > > The driver IC seems to be a truly 5p65. Hi Linus, In some internal documentation it says "LCD Driver IC" "HX83112A" and I don't see any reference to Truly 5P65 anywhere. On their website they have this sentence: Himax offers display drivers for mobile handset displays that combine source driver, gate driver, timing controller, frame buffer, and DC to DC circuits into a single chip in various display technologies, such as TFT-LCD, LTPS, In-Cell Touch and AMOLED. https://www.himax.com.tw/products/display-drivers/mobile-handset-applicatio= ns/ While I'm not super well versed in panel driver ICs, this sounds like it should be the one to take the name from? Regards Luca > > If this is right, could you rename the driver file to truly-5p65.c > and all symbols containing hx83112 to truly_5965 or something > that indicate the driver IC instead of the panel? > > My main concern is that the next display using the same IC > need to find the right file to patch. > > Yours, > Linus Walleij