From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A6E3BA4B for ; Fri, 26 Jan 2024 07:49:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706255368; cv=none; b=L8Mwi1DwkGRI1e/elpienSCgRX1jto8WvTd7dCKypXGBYCqvJ9rmMShG7YzPATbgLVI0ZdLnpYD7p/1yAuZeTWLuxDJWYBCGOwQEl8ju1FlA4PbaWVP7+TmJgEda5zPZGR8QVQaMkQUig61kliyz2evnnh9ZcrycE9PWakhRLos= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706255368; c=relaxed/simple; bh=X2bIO9XhEirZtwD9+aodGW5ANv8mY0gQ8ZSBilmbmQw=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=LKogRIKvyZwYCt8/5H0+yr4aD0/FvpRYUZafktjaYhyhcJTcMJXQWWd6c//uVQHuYbrALZu2I2ioVDEtnBCeWXgV0fGmFv9bdXXVRlk0m1KYocnYmUrLWijhXm5tULm2DKgHcxc/522rFeMgV+0YYtcwO1pAN0+V69Rieqh/LIk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=Xg8LrfSr; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="Xg8LrfSr" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-40eac352733so4090105e9.0 for ; Thu, 25 Jan 2024 23:49:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1706255364; x=1706860164; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=kMLN7Rz7MGbuTKXXFDmPa4TaxPrxTUAEjlgxCmYMMqE=; b=Xg8LrfSrTfG+6F9AcL2BEdD+PT6M/m6/NLrgDsrXNzieaZdMEoh28ikO6laScNDyTU JpIa+sq5l4WtC+5bcJLahUy2bJgc50mPzlEuJ60cxFujbqVXN3DWn7WBSVvicN7dlbsV c6zTl3b47JYmnLt3zDz6T2mhCPtlmyzkCvghJzmUWMxkdsKQ6LcBOJeWXp33+6c222BC TV4IMvL15PNDHAlstro6zZDMm1iRxrwFYB4X+2NzmaJIowsYcFz0tHSfbvQ7Pwi00ZYd SYCQykrjxNHNfbfRUQW5+bKGvE2GypDHmfxkLjIyJKcwC9C5iNoHhk3eTk5lGISDKXsR fvig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706255364; x=1706860164; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=kMLN7Rz7MGbuTKXXFDmPa4TaxPrxTUAEjlgxCmYMMqE=; b=Va+nUV5mA47Vm5ZCOom1QshPMKEpcUBtS+wJuMyywJ9HoOdoVNJcrrxuaKaeIivn1N 2EL+tdzQ77jayKPOShVt22D7DlhlEIwGc203ZUjNovVtXFtCB26RfjTnPZ9N6ItkYPKx Dm8Y5SKGOzZT5TxtRgMMkTc+Msj/t63qPRjwihM4oTVMR/HdTn9qdEtknDQbbItfTywR 8LITrfIz9+HDzJN3ujL5v2rNUDeP98EvjooiVJ5R9mUg+8PrhIG12116GGjk/lMzGd87 bqqFrgFTlBxzBZh2bLknBIacOqSwDUPV7SkdP0tKY7729Wk5U5PR5lvL0fPUOdKN7f1E Wd5w== X-Gm-Message-State: AOJu0Yzx/9dk56uj8U8gyJldmhIM7zrpFl5g7DYra/RgsHrhB3XIvUkL zRVLNtnKJ/UpUBwi5Xl4VcfAR9xpnh4o27ACMEbZSg4LvkXJ2BiYOWqozCA52wI= X-Google-Smtp-Source: AGHT+IFY+1BBYpedT+Me5GvLK2bkjb5tnsE8ri1rpr97wJTETbTwBLEoVpQ9JMBcAskBjVDXMlocoA== X-Received: by 2002:a05:600c:1913:b0:40e:b0e8:ee96 with SMTP id j19-20020a05600c191300b0040eb0e8ee96mr547389wmq.122.1706255364640; Thu, 25 Jan 2024 23:49:24 -0800 (PST) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id tb21-20020a1709078b9500b00a3025e05665sm350745ejc.14.2024.01.25.23.49.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jan 2024 23:49:24 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 26 Jan 2024 08:49:24 +0100 Message-Id: Cc: <~postmarketos/upstreaming@lists.sr.ht>, , , , Subject: Re: [PATCH] arm64: dts: qcom: sm6350: Add tsens thermal zones From: "Luca Weiss" To: "Konrad Dybcio" , "Bjorn Andersson" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" X-Mailer: aerc 0.15.2 References: <20240124-sm6350-tsens-v1-1-d37ec82140af@fairphone.com> In-Reply-To: On Thu Jan 25, 2024 at 5:30 PM CET, Konrad Dybcio wrote: > > > On 1/24/24 16:31, Luca Weiss wrote: > > Add the definitions for the various thermal zones found on the SM6350 > > SoC. Hooking up GPU and CPU cooling can limit the clock speeds there to > > reduce the temperature again to good levels. > >=20 > > Most thermal zones only have one critical temperature configured at > > 125=C2=B0C which can be mostly considered a placeholder until those zon= es can > > be hooked up to cooling. > >=20 > > Signed-off-by: Luca Weiss > > --- > > [...] > > > + cpuss0-thermal { > > + polling-delay-passive =3D <0>; > > + polling-delay =3D <0>; > > + > > + thermal-sensors =3D <&tsens0 7>; > > cpuss0-thermal and cpuss1-thermal are very likely the sensors for > cluster0/1, can you test that out, perhaps with corepinning+stress? Not really, according to my docs the CPUs aren't placed symmetrically on the SoC and cpuss0 and cpuss1 are just somewhere inbetween all of the 6x LITTLE cores, the 2x big cores are a little bit further away. So apart from hooking up all of the cores for cooling for cpuss0 & cpuss1 I don't have a great idea what to do here. Shall I do that? Regards Luca > You can then assign multiple cpu cooling devices. > > LGTM otherwise! > > > Konrad