From: John Moon <john@jmoon.dev>
To: Jackie Liu <liuyun01@kylinos.cn>, masahiroy@kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] check-uapi: added arm64 support
Date: Wed, 27 Mar 2024 18:17:48 +0000 [thread overview]
Message-ID: <D04QMF0IN7CH.2DPU99RSEZJDM@jmoon.dev> (raw)
In-Reply-To: <20240327103547.25695-1-liuyun01@kylinos.cn>
On Wed Mar 27, 2024 at 3:35 AM PDT, Jackie Liu wrote:
> By default, `uname -m` of arm64 will return aarch64, and the correct source code
> directory cannot be obtained when the script is executed. In order to solve this
> problem, it is necessary to correct ARCH=arm64 when aarch64.
>
> Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
> ---
> scripts/check-uapi.sh | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/scripts/check-uapi.sh b/scripts/check-uapi.sh
> index 955581735cb3..1c39d13b90b8 100755
> --- a/scripts/check-uapi.sh
> +++ b/scripts/check-uapi.sh
> @@ -408,6 +408,8 @@ check_deps() {
> ARCH="${ARCH:-$(uname -m)}"
> if [ "$ARCH" = "x86_64" ]; then
> ARCH="x86"
> + elif [ "$ARCH" = "aarch64" ]; then
> + ARCH="arm64"
> fi
>
> local -r abidiff_min_version="2.4"
> --
> 2.33.0
Good catch. Looks good to me!
Reviewed-by: John Moon <john@jmoon.dev>
parent reply other threads:[~2024-03-27 18:18 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20240327103547.25695-1-liuyun01@kylinos.cn>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D04QMF0IN7CH.2DPU99RSEZJDM@jmoon.dev \
--to=john@jmoon.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyun01@kylinos.cn \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®