From: Song Liu <songliubraving@fb.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Norbert Warmuth <nwarmuth@t-online.de>,
Jens Axboe <axboe@kernel.dk>,
Guoqing Jiang <guoqing.jiang@linux.dev>,
"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [Regression] md/raid1: write-intent logging/bitmap issue since fd3b6975e9c1 - v5.16-rc1
Date: Mon, 3 Jan 2022 21:59:25 +0000 [thread overview]
Message-ID: <D0600716-A336-4622-9A99-6EC4BA4D3B58@fb.com> (raw)
In-Reply-To: <CAHk-=whzdxBuoeTP1uJrxRQYtwOxPDYuP92c8e=_K5T1xHy7Ug@mail.gmail.com>
> On Jan 3, 2022, at 11:53 AM, Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> [ Jens wasn't cc'd for some reason but was the signer-off-on the patch
> you bisected to. Added him to the cc. I'll bounce the original
> separately, as I also don't see this on lore.kernel.org - it might not
> have gotten there yet ]
>
> On Mon, Jan 3, 2022 at 11:30 AM Norbert Warmuth <nwarmuth@t-online.de> wrote:
>>
>> Please verify and either revert or fixup fd3b6975e9c1 if my analysis is
>> correct.
>
> Can you check if moving the WriteMostly bit to the "do behind I/O?"
> section fixes things for you?
>
> IOW, something like the attached patch..
>
> Warning: This is very much a "Money see, monkey do" patch. I'm not
> really familiar with the raid1 code ]
>
> But yeah, if you see corruption and there isn't an absolutely trivial
> fix for this, we should revert.
>
> Linus
> <patch.diff>
I can confirm this patch fixes the issue. I will send pull request with
the fix shortly.
Thanks,
Song
next prev parent reply other threads:[~2022-01-03 21:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m3tuekbos5.fsf@nogrod.ivcecceob.t-online.de>
2022-01-03 19:53 ` Linus Torvalds
2022-01-03 21:59 ` Song Liu [this message]
2022-01-04 4:26 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D0600716-A336-4622-9A99-6EC4BA4D3B58@fb.com \
--to=songliubraving@fb.com \
--cc=axboe@kernel.dk \
--cc=guoqing.jiang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=nwarmuth@t-online.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®