From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender-of-o57.zoho.eu (sender-of-o57.zoho.eu [136.143.169.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B662D347FFE for ; Thu, 26 Mar 2026 07:10:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.169.57 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774509027; cv=pass; b=XjqqI8CUw8NRqt9qGrkHUUGtraRxuGA5ssec/xAmB85TZcK2kk/t/E6LJlwZ1NyTVFYLKOiAdNytpWOtOKQ+k7LuOaZySEHY2G6/tE4ybZ7BU/TV6FBSHoLZG9P3jyKs2gLuR+wuVTxiCoDDZanN7rZENvY4p4YPSKWOAoOmS3s= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774509027; c=relaxed/simple; bh=MCnG94Y9VT0MjINub2Wx4AZHsrqwuURYP0dP3/wRW7M=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=HwL1BuzvnZmDux3XA7xH6cV+H9C8Vy/oZv1ovMNPVvHiCu/yPyIetCPDkQ7PRBfbqxfK3g5xPi23U9lpEIAcJd1yOYZzW8KnOPxsHVORY1SFSEUSUelKkVjbNE3nfwpPwEFXzZUtSe/rplqRwkoBYimVEt+j8dYut3UCayzKT/Q= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=objecting.org; spf=pass smtp.mailfrom=objecting.org; dkim=pass (1024-bit key) header.d=objecting.org header.i=objecting@objecting.org header.b=MonAhbgx; arc=pass smtp.client-ip=136.143.169.57 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=objecting.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=objecting.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=objecting.org header.i=objecting@objecting.org header.b="MonAhbgx" ARC-Seal: i=1; a=rsa-sha256; t=1774509016; cv=none; d=zohomail.eu; s=zohoarc; b=Wc28it84nkXBjBJC+eoYrJG9fVEjoPxjzW8viq0XGaaR1CEiZB+cV6MthYBS/t3R/PyAqNRHAW6XB8nKwO7xNK0uSespxr+qTRlJoZQJAt9BbsFrf6bwgYEOCEMHk/xNaCnwuASFcG2FxvKJHsj0yWvtbkt/ijWnoqeBRRn9N74= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.eu; s=zohoarc; t=1774509016; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=/Wj5SBYakdn121mEYtfWsm6VpQKP6i/eroLS17KHXQE=; b=g+TirmWlDb6AxJz5ATcrJaaCOOloIYYS6fkAdxLokK+BPFfxF5fWpoixUfaBQWvRyoERKFu2LF1VvxYi85dagsu8/6Wk5/ir1dbU2+hshJkqhl+jfNJwtE7Hasc3kokVHtXqhOu73Ga3UaZph1rLnLUWjuMIqN3jUZ2mt/MWy+Y= ARC-Authentication-Results: i=1; mx.zohomail.eu; dkim=pass header.i=objecting.org; spf=pass smtp.mailfrom=objecting@objecting.org; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1774509016; s=zmail; d=objecting.org; i=objecting@objecting.org; h=Date:Date:From:From:To:To:CC:Subject:Subject:In-Reply-To:References:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc; bh=/Wj5SBYakdn121mEYtfWsm6VpQKP6i/eroLS17KHXQE=; b=MonAhbgxUkh0euo73Td4aLa4Am3/s9c9kuM5CqQsbuZjPeJg+HxD9Wl/cddxSUOs ++eOsu+7oohD6ao0xXgAUwm80j5jO43h1Q4fH/+zqPwk/rBzdZ4QzNiqEcQudZ2Jh3C 5u2t7U51DpHm339e9+2SeJ3el+Py5NSE1Tyy0Np4= Received: by mx.zoho.eu with SMTPS id 1774509012928712.1548004747601; Thu, 26 Mar 2026 08:10:12 +0100 (CET) Date: Thu, 26 Mar 2026 07:10:11 +0000 From: Josh Law To: Andrew Morton , Inseob Kim CC: linux-kernel@vger.kernel.org, changbin.du@gmail.com, jbaron@akamai.com, joe@perches.com Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v2=5D_lib=3A_parser=3A_Fix_match=5Fwi?= =?US-ASCII?Q?ldcard_to_correctly_handle_trailing_stars?= User-Agent: Thunderbird for Android In-Reply-To: <20260325192534.151e86e439e7e4080a630d4c@linux-foundation.org> References: <20260326020630.4139520-1-inseob@google.com> <20260325192534.151e86e439e7e4080a630d4c@linux-foundation.org> Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External On 26 March 2026 02:25:34 GMT, Andrew Morton = wrote: >On Thu, 26 Mar 2026 11:06:04 +0900 Inseob Kim wrote= : > >> This fixes a bug of match_wildcard that incorrectly handles trailing >> asterisks=2E For example, `match_wildcard("abc**", "abc")` must return >> true, but it returns false=2E >>=20 >> Signed-off-by: Inseob Kim >> --- >> v2: >> - Added Cc=2E No changes to the code=2E >> --- >> lib/parser=2Ec | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >>=20 >> diff --git a/lib/parser=2Ec b/lib/parser=2Ec >> index 73e8f8e5be73=2E=2E62da0ac0d438 100644 >> --- a/lib/parser=2Ec >> +++ b/lib/parser=2Ec >> @@ -315,7 +315,7 @@ bool match_wildcard(const char *pattern, const char= *str) >> } >> } >> =20 >> - if (*p =3D=3D '*') >> + while (*p =3D=3D '*') >> ++p; >> return !*p; >> } > >Thanks, looks right=2E > >We don't appear to have any selftesting for this code=2E > >Should all of parser=2Ec actually exist? Some of it is a subset of >lib/glob=2Ec? Hi! Reviewed-By: Josh Law Good patch