From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755300AbbCBQwe (ORCPT ); Mon, 2 Mar 2015 11:52:34 -0500 Received: from mail-bl2on0123.outbound.protection.outlook.com ([65.55.169.123]:10944 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754618AbbCBQwa convert rfc822-to-8bit (ORCPT ); Mon, 2 Mar 2015 11:52:30 -0500 X-WSS-ID: 0NKLG76-07-BKH-02 X-M-MSG: From: "Suthikulpanit, Suravee" To: Tejun Heo CC: "rjw@rjwysocki.net" , "mika.westerberg@linux.intel.com" , "lv.zheng@intel.com" , "hpa@linux.intel.com" , "lenb@kernel.org" , "hdegoede@redhat.com" , "arnd@arndb.de" , "mjg59@srcf.ucam.org" , "gregkh@linuxfoundation.org" , "hanjun.guo@linaro.org" , "al.stone@linaro.org" , "graeme.gregory@linaro.org" , "Duran, Leo" , "linux-ide@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linaro-acpi@lists.linaro.org" Subject: Re: [V4 PATCH 2/2] ata: ahci_platform: Add ACPI _CLS matching Thread-Topic: [V4 PATCH 2/2] ata: ahci_platform: Add ACPI _CLS matching Thread-Index: AQHQVMK6UfVfqQYnF0KGcHRVRIWJe50JuaOA//+ejIA= Date: Mon, 2 Mar 2015 16:52:17 +0000 Message-ID: In-Reply-To: <20150302164103.GH17694@htj.duckdns.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.3.0.121105 x-originating-ip: [10.224.9.37] Content-Type: text/plain; charset="us-ascii" Content-ID: <9AAF8362201F49438A5446EE0FB8D53E@amd.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-EOPAttributedMessage: 0 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=Suravee.Suthikulpanit@amd.com; arndb.de; dkim=none (message not signed) header.d=none; X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(428002)(24454002)(51704005)(199003)(189002)(479174004)(46102003)(105586002)(50986999)(102836002)(46406003)(62966003)(77156002)(54356999)(53416004)(50466002)(106466001)(87936001)(2656002)(19580405001)(83506001)(2900100001)(19580395003)(2950100001)(86362001)(106116001)(36756003)(47776003)(101416001)(110136001)(92566002)(97756001)(23726002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR02MB474;H:atltwp01.amd.com;FPR:;SPF:None;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB474;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB044; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006);SRVR:BY2PR02MB474;BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB474; X-Forefront-PRVS: 0503FF9A3E X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2015 16:52:20.0444 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.221] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR02MB474 X-OriginatorOrg: amd4.onmicrosoft.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/2/15, 10:41, "Tejun Heo" wrote: >On Mon, Mar 02, 2015 at 02:27:20AM -0600, Suravee Suthikulpanit wrote: >> This patch adds ACPI supports for AHCI platform driver, which uses _CLS >> method to match the device. >> >> The following is an example of ASL structure in DSDT for a SATA >>controller, >> which contains _CLS package to be matched by the ahci_platform driver: >> >> Device (AHC0) // AHCI Controller >> { >> Name(_HID, "AMDI0600") >> Name (_CCA, 1) >> Name (_CLS, Package (3) >> { >> 0x01, // Base Class: Mass Storage >> 0x06, // Sub-Class: serial ATA >> 0x01, // Interface: AHCI >> }) >> Name (_CRS, ResourceTemplate () >> { >> Memory32Fixed (ReadWrite, 0xE0300000, 0x00010000) >> Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive,,,) { >>387 } >> }) >> } >> >> Also, since ATA driver should not require PCI support for ATA_ACPI, >> this patch removes dependency in the driver/ata/Kconfig. >> >> Signed-off-by: Suravee Suthikulpanit > >Looks good to me from the libata side. > > Acked-by: Tejun Heo > >Please let me now if this needs to go through libata. > >Thanks. > >-- >tejun Thank you. I will let you know one the whole series is ready. Suravee