From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751324AbbDZWpk (ORCPT ); Sun, 26 Apr 2015 18:45:40 -0400 Received: from mail-by2on0146.outbound.protection.outlook.com ([207.46.100.146]:22294 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751043AbbDZWpf convert rfc822-to-8bit (ORCPT ); Sun, 26 Apr 2015 18:45:35 -0400 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; intel.com; dkim=none (message not signed) header.d=none; X-WSS-ID: 0NNFR7T-07-EU9-02 X-M-MSG: From: "Suthikulpanit, Suravee" To: "Rafael J. Wysocki" CC: "Zheng, Lv" , "mika.westerberg@linux.intel.com" , "Moore, Robert" , "hanjun.guo@linaro.org" , "lenb@kernel.org" , "hdegoede@redhat.com" , "tj@kernel.org" , "mjg59@srcf.ucam.org" , "gregkh@linuxfoundation.org" , "al.stone@linaro.org" , "graeme.gregory@linaro.org" , "Duran, Leo" , "linux-ide@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linaro-acpi@lists.linaro.org" Subject: Re: [V8 PATCH 1/3] ACPICA: Add ACPI _CLS processing Thread-Topic: [V8 PATCH 1/3] ACPICA: Add ACPI _CLS processing Thread-Index: AQHQazReni7SfDxa00Gyt8V9xTy7lJ1QzR4AgAvxV4CAAK1ZgIACkmaA Date: Sun, 26 Apr 2015 22:45:29 +0000 Message-ID: In-Reply-To: <1960107.SMA7G3OmSP@vostro.rjw.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.3.0.121105 x-originating-ip: [10.177.96.13] Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;BMV:1;SFV:NSPM;SFS:(10019020)(6009001)(428002)(377454003)(189002)(164054003)(479174004)(24454002)(199003)(51704005)(54356999)(62966003)(46102003)(77156002)(50986999)(47776003)(5250100002)(23756003)(2950100001)(50466002)(2900100001)(102836002)(86362001)(110136001)(106466001)(101416001)(4001350100001)(53416004)(105586002)(83506001)(19580405001)(92566002)(2656002)(19580395003)(36756003)(87936001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM2PR02MB543;H:atltwp01.amd.com;FPR:;SPF:None;MLV:sfv;MX:1;A:1;LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR02MB543; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(5002010)(3002001);SRVR:DM2PR02MB543;BCL:0;PCL:0;RULEID:;SRVR:DM2PR02MB543; X-Forefront-PRVS: 0558D3C5AC X-OriginatorOrg: amd4.onmicrosoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2015 22:45:31.0960 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR02MB543 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/24/15, 21:28, "Rafael J. Wysocki" wrote: >On Friday, April 24, 2015 04:08:31 PM Suravee Suthikulpanit wrote: >> On 4/16/15 20:45, Zheng, Lv wrote: >> > Before back porting this to ACPICA, let me ask one simple question. >> > According to the spec, the _CLS is optional and PCI specific. >> > So why should we implement it in ACPICA core not OSPM specific >>modules? >> > If this need to be implemented in ACPICA, then what about the >>following device identification objects? >> > _DDN, _HRV, _MLS, _PLD, _STR, _SUN >> > >> > Thanks and best regards >> > -Lv >> >> Hi, >> >> Sorry for late reply. As for the justification for introducing the _CLS >> support in the ACPICA, this is mainly because ACPI does not currently >> define _CID for certain device classes, which used to mostly be PCI >> devices. Instead, ACPI spec mentioned that _CLS can be used for loading >> generic drivers on hardware that is compatible with PCI-defined device >> classes, but that is not implemented on the PCI bus (and is therefore >> enumerated by ACPI.) > >I think it would be good to point to the particular part of the spec >making that provision. In what section is that mentioned, exactly? Here is the copied from section 6.1.3 _CLS (Class Code) from ACPI 5.1 spec: "This object is used to supply OSPM with the PCI-defined class, subclass and programming interface for a device. This object is optional but may be useful for generic drivers written for PCI devices that move off of PCI and are enumerated by ACPI.² Otherwise, if the community think itıs better to not putting the _CLS the _CLS parsing code in ACPICA since, I can try looking into pulling the code out of ACPICA. I also noticed a little issue in the patch series where the ACPI_VALID_CLS is used in the patch 1 but defined in patch 2. I can send out v9 with the fix once we agree on the _CLS parsing. Thanks, Suravee