From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754940AbbG0X0V (ORCPT ); Mon, 27 Jul 2015 19:26:21 -0400 Received: from mx0b-0016ce01.pphosted.com ([67.231.156.153]:12071 "EHLO mx0b-0016ce01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754132AbbG0X0S convert rfc822-to-8bit (ORCPT ); Mon, 27 Jul 2015 19:26:18 -0400 From: Quinn Tran To: Christoph Hellwig , Dilip Uppugandla CC: Spencer Baugh , Dept-Eng QLA2xxx Upstream , "James E.J. Bottomley" , linux-scsi , linux-kernel , Joern Engel , "Spencer Baugh" , "target-devel@vger.kernel.org" , Bart Van Assche Subject: Re: [PATCH] qla2xxx: Return the fabric command state for non-task management requests Thread-Topic: [PATCH] qla2xxx: Return the fabric command state for non-task management requests Thread-Index: AQHQxAIIBdAnkEwbwkqA13YS5Qjp4J3pRlSAgAJ4NyCABEC6AA== Date: Mon, 27 Jul 2015 23:25:30 +0000 Message-ID: References: <1437516477-30554-3-git-send-email-sbaugh@catern.com> <20150723094651.GA15301@infradead.org> <20150725062926.GC26437@infradead.org> In-Reply-To: <20150725062926.GC26437@infradead.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.5.2.150604 x-originating-ip: [10.3.10.23] disclaimer: bypass Content-Type: text/plain; charset="iso-8859-1" Content-ID: <15F42DD116C5274F9CCB150ED43C6E1E@qlogic.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=5700 definitions=7875 signatures=670614 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1506180000 definitions=main-1507270388 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christoph, Currently, the command state within TCM (se_cmd.t_state) only track command states from the point of new to the Back End and from Back End up to QLA driver. From the debug perspective, that¹s only half the picture. The other half comes from qla2xxx¹s private command state provided by this patch. Having another trace point that happens 5~10 seconds ago might be difficult to back track. For task management debugging, dumping the current states (se_cmd + qla_tgt_cmd) of each command when the TMR is received provides some benefit. If you feel uncomfortable with the "driver defined binary", one alternative would be to translate QLA¹s private command state into se_cmd¹s new field. This new file would be modify by the fabric layer only. This would limit any regression with existing se_cmd field modification. Regards, Quinn Tran On 7/24/15, 11:29 PM, "target-devel-owner@vger.kernel.org on behalf of Christoph Hellwig" wrote: >Which debug printk do you care about? I'd much prefer having a trace >point inside the driver which could even pretty print it instead of the >hack where a driver defined binary value is printed by the core. >-- >To unsubscribe from this list: send the line "unsubscribe target-devel" in >the body of a message to majordomo@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html