From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Linus Torvalds" <torvalds@linux-foundation.org>
Cc: "Jason Gunthorpe" <jgg@ziepe.ca>,
"David Howells" <dhowells@redhat.com>,
<linux-integrity@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"James Bottomley" <James.Bottomley@HansenPartnership.com>,
"Mimi Zohar" <zohar@linux.ibm.com>, <keyrings@vger.kernel.org>
Subject: [GIT PULL] KEYS-TRUSTED: keys-trusted-next-6.10-rc1-part2
Date: Tue, 21 May 2024 02:47:08 +0300 [thread overview]
Message-ID: <D1EVFNB6HJZ8.2ZRZB8Y0K3TV5@kernel.org> (raw)
The following changes since commit 8f6a15f095a63a83b096d9b29aaff4f0fbe6f6e6:
Merge tag 'cocci-for-6.10' of git://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux (2024-05-20 16:00:04 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git tags/keys-trusted-next-6.10-rc1-part2
for you to fetch changes up to 050bf3c793a07f96bd1e2fd62e1447f731ed733b:
KEYS: trusted: Do not use WARN when encode fails (2024-05-21 02:35:10 +0300)
----------------------------------------------------------------
Hi,
These are couple of bugs I found from trusted keys while working on a new
asymmetric key type for TPM2 [1]. Both originate form v5.13. Memory leak is
more crucial but I don't think it is either good idea if kernel throws WARN
when ASN.1 parser fails, even if it is related to programming error, as it
is not that mature code yet.
There's at least two WARN's in that code but I picked just the one more
likely to trigger. Planning to fix the other one too over time.
BR, Jarkko
[1] https://lore.kernel.org/linux-integrity/D1ERDC16XLUO.578U4ZE7VXW@kernel.org/T/#t
----------------------------------------------------------------
Jarkko Sakkinen (2):
KEYS: trusted: Fix memory leak in tpm2_key_encode()
KEYS: trusted: Do not use WARN when encode fails
security/keys/trusted-keys/trusted_tpm2.c | 25 +++++++++++++++++++------
1 file changed, 19 insertions(+), 6 deletions(-)
next reply other threads:[~2024-05-20 23:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-20 23:47 Jarkko Sakkinen [this message]
2024-05-21 18:13 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D1EVFNB6HJZ8.2ZRZB8Y0K3TV5@kernel.org \
--to=jarkko@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dhowells@redhat.com \
--cc=jgg@ziepe.ca \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®