mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ilya Matveychikov <matvejchikov@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] ksys_mount: check for permissions before resource allocation
Date: Tue, 5 Jun 2018 06:00:47 +0400	[thread overview]
Message-ID: <D2317950-0DB0-4311-ADB1-FF677B676E04@gmail.com> (raw)

Early check for mount permissions prevents possible allocation of 3
pages from kmalloc() pool by unpriveledged user which can be used for
spraying the kernel heap.

Signed-off-by: Ilya V. Matveychikov <matvejchikov@gmail.com>
---
 fs/namespace.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/namespace.c b/fs/namespace.c
index 5f75969adff1..1ef8feb2de2a 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -3046,6 +3046,9 @@ int ksys_mount(char __user *dev_name, char __user *dir_name, char __user *type,
 	char *kernel_dev;
 	void *options;

+	if (!may_mount())
+		return -EPERM;
+
 	kernel_type = copy_mount_string(type);
 	ret = PTR_ERR(kernel_type);
 	if (IS_ERR(kernel_type))
--
2.17.0

             reply	other threads:[~2018-06-05  2:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-05  2:00 Ilya Matveychikov [this message]
2018-06-05  6:59 ` Ilya Matveychikov
2018-06-05 11:26   ` Al Viro
2018-06-05 11:35     ` Ilya Matveychikov
2018-06-05 11:53       ` Al Viro
2018-06-05 12:07         ` Ilya Matveychikov
2018-06-05 12:28           ` David Sterba
2018-06-05 12:42             ` Ilya Matveychikov
2018-06-05 12:34           ` Al Viro
2018-06-05 19:56   ` Eric W. Biederman
2018-06-06  9:32     ` Ilya Matveychikov
2018-06-06 14:22       ` Eric W. Biederman
2018-06-06 15:26         ` Ilya Matveychikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D2317950-0DB0-4311-ADB1-FF677B676E04@gmail.com \
    --to=matvejchikov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®