From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-106118.protonmail.ch (mail-106118.protonmail.ch [79.135.106.118]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D8B038B7CB; Thu, 22 Jan 2026 15:37:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=79.135.106.118 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769096257; cv=none; b=UDigbuWdWktWKfElWJBzMWqzAdw+n+/d4RcbD53HRMal+cOM1vK0/B6MF6SsDz6neSSlWYngHTRnuUl5nrVHdlPhspIP9DYMsuXmk0LdW+sW+LZEHSnoYaBtn+6p7oLwKlifQTtD3OXxPnXE4fMJlCOvb8bPGN1sOAxU3fFXimI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769096257; c=relaxed/simple; bh=S1BGqcMlASMvyYCKXlGf55t9i2UcSbu9BGB4Vbxmsjw=; h=Date:To:From:Cc:Subject:Message-ID:MIME-Version:Content-Type; b=o8/afDQIb27Ci2pPwxBcpOYXXrdVWcLxJLTdQsqmLSSlAtKNT72j5JTzGVJvaSJnDPIV26AidvCfyYxu48NQiswymVgk9nfEzjsGgftG/U0yc6fa6ReRD4GQJETOnh2L9VXCkAK3BR/hpDhTPUhAblzEIh5T3IrrYkRQHmolWxw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=OAShtVl8; arc=none smtp.client-ip=79.135.106.118 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="OAShtVl8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1769096249; x=1769355449; bh=S1BGqcMlASMvyYCKXlGf55t9i2UcSbu9BGB4Vbxmsjw=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=OAShtVl8spr+0GUWWivMvpCjCyV4nt7net/RqiDocSoRyc2xGILA5VY3XkzJCj5rN JBlHlnEg7Vc+q+W2pH00Kt/XkXvx/kl4CFvgkIuexUOB6S+hdAhnsISrVfJP6hEtXc cgoRwCNiDa59Pd7yCtj6KSqs5XR3JzrS7A46BRv7KCBCveSUeD4L3A2c8WwOTkWaq1 X/9mfBKXG/p5ecgX44tQSC0rOp26QPaFpXV84SRN1WShlnz70Tz4swAIkbTukIVFhT OrDavFueoypp77UwkvbkXzUtgk4i8ug1Z6o3wQwrbCWhC8SJ5yFWNUintGE7vIWboE 791SQUjO/0mZg== Date: Thu, 22 Jan 2026 15:37:23 +0000 To: Krzysztof Kozlowski From: Arturs Artamonovs Cc: arturs.artamonovs@analog.com, Catalin Marinas , Will Deacon , Greg Malysa , Philipp Zabel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Utsav Agarwal , Michael Turquette , Stephen Boyd , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Andi Shyti , Greg Kroah-Hartman , Jiri Slaby , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-serial@vger.kernel.org, adsp-linux@analog.com, Nathan Barrett-Morrison Subject: Re: [PATCH 00/21] Adding support of ADI ARMv8 ADSP-SC598 SoC. Message-ID: Feedback-ID: 15175799:user:proton X-Pm-Message-ID: 645533fd368795d784bccb039ef9deb7ee99176c Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, big thanks to Krysztof, Arnd, Rob and Linus Walleij for the reviewing f= irst set of patches that were sent some time ago. I have reviewed comments = few times since then and Im currently at last stage of internal review for = v2 series those are planned to be sent sometime in near future.=20 > On 16 Sep 2024, at 10:05, Krzysztof Kozlowski wrote: >=20 > On 12/09/2024 20:24, Arturs Artamonovs via B4 Relay wrote: >> This set of patches based on ADI fork of Linux Kerenl that support famil= y of ADSP-SC5xx >> SoC's and used by customers for some time . Patch series contains minima= l set >> of changes to add ADSP-SC598 support to upstream kernel. This series inc= lude >> UART,I2C,IRQCHIP,RCU drivers and device-tree to be able boot on EV-SC598= -SOM >> board into serial shell and able to reset the board. Current SOM board >> requires I2C expander to enable UART output. >>=20 >> UART,I2C and PINCTRL drivers are based on old Blackfin drivers with >> ADSP-SC5xx related bug fixes and improvments. >>=20 >> Signed-off-by: Arturs Artamonovs >> --- >=20 > For new platform, be sure you have 0 warnings: > 1. Please run standard kernel tools for static analysis, like > coccinelle, smatch and sparse, and fix reported warnings. >=20 > 2. Also check for warnings when building with W=3D1. Most of these > commands (checks or W=3D1 build) can build specific targets, like some > directory, to narrow the scope to only your code. The code here looks > like it needs a fix. Feel free to get in touch if the warning is not clea= r. >=20 > 3. Fix all compile test warning reported by LKP and check for common > configs, regardless of reports. >=20 > 4. Please run `make dtbs_check W=3D1` (see > Documentation/devicetree/bindings/writing-schema.rst or > https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sou= rces-with-the-devicetree-schema/ > for instructions). >=20 > 5. Please run scripts/checkpatch.pl and fix reported warnings. Then > please run `scripts/checkpatch.pl --strict` and (probably) fix more > warnings. Some warnings can be ignored, especially from --strict run. >=20 >=20 > Best regards, > Krzysztof >=20 >=20