From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5610C55191 for ; Thu, 23 Apr 2020 06:53:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9DA8D21775 for ; Thu, 23 Apr 2020 06:53:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726531AbgDWGx0 convert rfc822-to-8bit (ORCPT ); Thu, 23 Apr 2020 02:53:26 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:54627 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725854AbgDWGxZ (ORCPT ); Thu, 23 Apr 2020 02:53:25 -0400 Received: from mail-pl1-f198.google.com ([209.85.214.198]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jRVjf-0003hw-9O for linux-kernel@vger.kernel.org; Thu, 23 Apr 2020 06:53:23 +0000 Received: by mail-pl1-f198.google.com with SMTP id n18so3927735plp.17 for ; Wed, 22 Apr 2020 23:53:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Brn70UkrdEH9wF8l6cReBO011o8Fv5QqqLg/eGvIrCI=; b=D6sVebGIFKGhBgAcZSZi1fxA8XCKyi2UolmNrpONKZhkALaJ5I3DTeqc+BRb2YDLzR lMBFezXp6R9x0Whlq76ICl++98CUeL++UoqcawMagzL/di95Pv03gggc+OVKGpA+I77G eQKZwou44RiEjYmuzXCJv+rs1SueYVBVEmRnmHLqSShlUJHMIfg7xt09QKJq1wQ3oPjO 8039pfytLI13C7HcH6pfywCWZZ71WDrTSIJlzc6M04yKIgvdB3VIxE34VTwda/AHbxoU eItt2mfvBjV7j2oc89TL9ZwOGGWQkADMJWtO/AbaOKsglMQNygQgUP+fBpxRVjwTIlUm sFlw== X-Gm-Message-State: AGi0Pubh5raeFF1cxnE5I/MySkZdw03ssujtMWMkjROM2DsF2Sxva9dR wz5VzYNCYONV+R1FjIY5LhYaaJik/PSXWijEZRb7JmgsuuJXWuns07IHo3ZbkBb+uaD3xldlPLk 8kkMoBR0yRY8uCwJHx1HPnzJNlbRjamI69V1NVhtn3w== X-Received: by 2002:a17:902:20b:: with SMTP id 11mr2202451plc.209.1587624801891; Wed, 22 Apr 2020 23:53:21 -0700 (PDT) X-Google-Smtp-Source: APiQypJjjevu44Y1bDstf34odxPmWbk2i8mHMY4lhgtg04FGkpDdcGX8ckb4H8mS0HyeJuNBf7IfnQ== X-Received: by 2002:a17:902:20b:: with SMTP id 11mr2202437plc.209.1587624801597; Wed, 22 Apr 2020 23:53:21 -0700 (PDT) Received: from [192.168.1.208] (220-133-187-190.HINET-IP.hinet.net. [220.133.187.190]) by smtp.gmail.com with ESMTPSA id n9sm1289198pjt.29.2020.04.22.23.53.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Apr 2020 23:53:21 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: [PATCH 2/2] rtw88: Use udelay instead of usleep in atomic context From: Kai-Heng Feng In-Reply-To: <87h7xan1cy.fsf@kamboji.qca.qualcomm.com> Date: Thu, 23 Apr 2020 14:53:18 +0800 Cc: Tony Chuang , "David S. Miller" , "open list:REALTEK WIRELESS DRIVER (rtw88)" , "open list:NETWORKING DRIVERS" , open list Content-Transfer-Encoding: 8BIT Message-Id: References: <20200423063811.2636-1-kai.heng.feng@canonical.com> <20200423063811.2636-2-kai.heng.feng@canonical.com> <87h7xan1cy.fsf@kamboji.qca.qualcomm.com> To: Kalle Valo X-Mailer: Apple Mail (2.3608.80.23.2.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Apr 23, 2020, at 14:49, Kalle Valo wrote: > > Kai-Heng Feng writes: > >> It's incorrect to use usleep in atomic context. >> >> Switch to a macro which uses udelay instead of usleep to prevent the issue. >> >> Signed-off-by: Kai-Heng Feng > > This fixes a regression, right? So there should be a Fixes line. Yes, but the regression commit isn't in Linus' tree, so the sha1 may change. Kai-Heng > > Also I can't take this until patch 1 is in my tree. And I don't know who > takes iopoll.h patches. > > -- > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches