From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7224C54EE9 for ; Tue, 27 Sep 2022 04:44:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229545AbiI0EoS (ORCPT ); Tue, 27 Sep 2022 00:44:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbiI0EoP (ORCPT ); Tue, 27 Sep 2022 00:44:15 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEFC1A896C; Mon, 26 Sep 2022 21:44:13 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id bj12so18163355ejb.13; Mon, 26 Sep 2022 21:44:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date; bh=l1wBi+6umvncLDBKieZ1XfXH8kSugLZm2o3CnBG1w44=; b=im7Sx2Cfiel3Nb1P60hkLEkIwjc956AdHjop3aTwDymCONtuBpYwtcVtbY6UdAEcZh 4NhgCFrnvJpGu5miRNQijeaE5rRvu3VoaA5U+W+NZgcCsFdcFctuXVCvP5cwyoyFdFCv a3NC+ObvcHP4WDiZtBtcDIz7H/oZ88/FZzJXzgR1tR4tjrcgLaaz2y7rPN6v6c7+At8T AvZjatw90+uVLHIaa3uVbijbPUMC+nWB0zeTnzy56B/k+tRpe6V8KpINlrLw14o5kH7y K1GjMO84zXy2RI8w0ijgBr9p1YIlm8HD+gXeLlOoaYkpoq6HXaor2dVUOUZ1KCwmXjtg tTWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=l1wBi+6umvncLDBKieZ1XfXH8kSugLZm2o3CnBG1w44=; b=dSgJNGuoWF5du6k/D0TVqcPVKse64d9uWMtkNjfwkk60tOFiYqQ+HqT9yLajsej7nc vMi5UgbNk0ibx9XiCOViqWgk0oynUkEPMxhUqCZoRWq2sVXHcwrjLrMmX2B9TbZ/1QTC DSoV938G1GGn1fPLqs77qR/DcETpBgpzTqdpnYlQnybkNaX4eINwim4LNeiBi6nNNFmh uW5u2l7TPE6VNJYh8iypzI5lJ0a4zVNaBEycJ3biknvxdYo7Bga15j/H8MqqQvKNSKjL H8CcZn+S+l2DOmqOZfl0EFfwclgKs6lHuYFIweu6Oaif13DN8Z0I/brdF3nnlG99+beK Zheg== X-Gm-Message-State: ACrzQf2VN23j9eQMrMjJoIH05x+WTar34FHWxHFRx+wj4es6dvlJkGw9 qFRE1vf95o26jVuvWcV7NGs= X-Google-Smtp-Source: AMsMyM7TxU0q3RRO4eY7tXMJeGNLQWWlQeC1LFjKN1GQmdpFh4FtYwyNG7CaaC+7bAATwY9bl/oH5A== X-Received: by 2002:a17:906:974c:b0:784:d96c:b4fa with SMTP id o12-20020a170906974c00b00784d96cb4famr970916ejy.391.1664253852194; Mon, 26 Sep 2022 21:44:12 -0700 (PDT) Received: from smtpclient.apple ([178.254.237.20]) by smtp.gmail.com with ESMTPSA id x3-20020a1709064a8300b0078082f95e5csm122080eju.204.2022.09.26.21.44.10 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Sep 2022 21:44:11 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: [PATCH net] rhashtable: fix crash due to mm api change From: Martin Zaharinov In-Reply-To: <20220926151939.GG12777@breakpoint.cc> Date: Tue, 27 Sep 2022 07:44:09 +0300 Cc: Michal Hocko , netdev , tgraf@suug.ch, urezki@gmail.com, Paolo Abeni , "David S. Miller" , Eric Dumazet , Jakub Kicinski , herbert@gondor.apana.org.au, "linux-kernel@vger kernel. org" , akpm@linux-foundation.org, Paolo Bonzini , kvm@vger.kernel.org, david.switzer@intel.com, Intel-wired-lan@osuosl.org, intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com Content-Transfer-Encoding: quoted-printable Message-Id: References: <20220926083139.48069-1-fw@strlen.de> <20220926151939.GG12777@breakpoint.cc> To: Florian Westphal X-Mailer: Apple Mail (2.3654.120.0.1.13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add intel=20 And one more from last min: Sep 27 06:28:58 [ 1715.463514][ C28] ------------[ cut here = ]------------ Sep 27 06:28:58 [ 1715.464245][ C28] NETDEV WATCHDOG: eth0 (i40e): = transmit queue 0 timed out Sep 27 06:28:58 [ 1715.465216][ C28] WARNING: CPU: 28 PID: 0 at = net/sched/sch_generic.c:529 dev_watchdog+0x167/0x170 Sep 27 06:28:58 [ 1715.466459][ C28] Modules linked in: nft_limit = nf_conntrack_netlink pppoe pppox ppp_generic slhc nft_ct nft_nat = nft_chain_nat team_mode_loadbalance team nf_tables netconsole coretemp = i40e nf_nat_sip nf_conntrack_sip nf_nat_pptp nf_conntrack_pptp = nf_nat_tftp nf_conntrack_tftp nf_nat_ftp nf_conntrack_ftp nf_nat = nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 acpi_ipmi ipmi_si = ipmi_devintf ipmi_msghandler rtc_cmos [last unloaded: nf_flow_table] Sep 27 06:28:58 [ 1715.472099][ C28] CPU: 28 PID: 0 Comm: swapper/28 = Tainted: G O 5.19.11 #1 Sep 27 06:28:58 [ 1715.473225][ C28] Hardware name: Supermicro = SYS-5038MR-H8TRF/X10SRD-F, BIOS 3.3 10/28/2020 Sep 27 06:28:58 [ 1715.474377][ C28] RIP: = 0010:dev_watchdog+0x167/0x170 Sep 27 06:28:58 [ 1715.475081][ C28] Code: 28 e9 77 ff ff ff 48 89 df = c6 05 63 57 c4 00 01 e8 de 59 fb ff 48 89 c2 44 89 e1 48 89 de 48 c7 c7 = 08 c7 ec 98 e8 52 c6 13 00 <0f> 0b eb 85 0f 1f 44 00 00 41 55 41 54 55 = 53 48 8b 47 50 4c 8b 28 Sep 27 06:28:58 [ 1715.477736][ C28] RSP: 0018:ffffa93c806b8ee8 = EFLAGS: 00010292 Sep 27 06:28:58 [ 1715.478542][ C28] RAX: 0000000000000038 RBX: = ffffa01591bb0000 RCX: 0000000000000001 Sep 27 06:28:58 [ 1715.479608][ C28] RDX: 00000000ffffffea RSI: = 00000000fff7ffff RDI: 00000000fff7ffff Sep 27 06:28:58 [ 1715.480674][ C28] RBP: ffffa01591bb03c0 R08: = 0000000000000001 R09: 00000000fff7ffff Sep 27 06:28:58 [ 1715.481741][ C28] R10: ffffa01cdae00000 R11: = 0000000000000003 R12: 0000000000000000 Sep 27 06:28:58 [ 1715.482807][ C28] R13: 0000000000000001 R14: = ffffa01cdfd207a8 R15: 0000000000000082 Sep 27 06:28:58 [ 1715.483876][ C28] FS: 0000000000000000(0000) = GS:ffffa01cdfd00000(0000) knlGS:0000000000000000 Sep 27 06:28:58 [ 1715.485072][ C28] CS: 0010 DS: 0000 ES: 0000 CR0: = 0000000080050033 Sep 27 06:28:58 [ 1715.485949][ C28] CR2: 000000c000c19010 CR3: = 00000001974a4005 CR4: 00000000003706e0 Sep 27 06:28:58 [ 1715.487018][ C28] DR0: 0000000000000000 DR1: = 0000000000000000 DR2: 0000000000000000 Sep 27 06:28:58 [ 1715.488084][ C28] DR3: 0000000000000000 DR6: = 00000000fffe0ff0 DR7: 0000000000000400 Sep 27 06:28:58 [ 1715.489151][ C28] Call Trace: Sep 27 06:28:58 [ 1715.489582][ C28] Sep 27 06:28:58 [ 1715.489949][ C28] ? pfifo_fast_destroy+0x30/0x30 Sep 27 06:28:58 [ 1715.490615][ C28] = call_timer_fn.constprop.0+0x14/0x70 Sep 27 06:28:58 [ 1715.491342][ C28] __run_timers.part.0+0x164/0x190 Sep 27 06:28:58 [ 1715.492019][ C28] ? ktime_get+0x30/0x90 Sep 27 06:28:58 [ 1715.492576][ C28] run_timer_softirq+0x21/0x50 Sep 27 06:28:58 [ 1715.493204][ C28] __do_softirq+0xaf/0x1d7 Sep 27 06:28:58 [ 1715.493788][ C28] __irq_exit_rcu+0x9a/0xd0 Sep 27 06:28:58 [ 1715.494383][ C28] = sysvec_apic_timer_interrupt+0x66/0x80 Sep 27 06:28:58 [ 1715.495131][ C28] Sep 27 06:28:58 [ 1715.495509][ C28] Sep 27 06:28:58 [ 1715.495887][ C28] = asm_sysvec_apic_timer_interrupt+0x16/0x20 Sep 27 06:28:58 [ 1715.496683][ C28] RIP: = 0010:cpuidle_enter_state+0xb3/0x290 Sep 27 06:28:58 [ 1715.497455][ C28] Code: e8 12 25 b0 ff 31 ff 49 89 = c5 e8 c8 80 af ff 45 84 ff 74 12 9c 58 f6 c4 02 0f 85 cf 01 00 00 31 ff = e8 c1 cb b3 ff fb 45 85 f6 <0f> 88 d0 00 00 00 49 63 ce 48 6b f1 68 48 = 8b 04 24 4c 89 ea 48 29 Sep 27 06:28:58 [ 1715.500111][ C28] RSP: 0018:ffffa93c801cfe98 = EFLAGS: 00000202 Sep 27 06:28:58 [ 1715.500916][ C28] RAX: ffffa01cdfd26800 RBX: = ffffa01580bff000 RCX: 000000000000001f Sep 27 06:28:58 [ 1715.501983][ C28] RDX: 0000018f6997dcb8 RSI: = 00000000313b13b1 RDI: 0000000000000000 Sep 27 06:28:58 [ 1715.503050][ C28] RBP: 0000000000000001 R08: = 0000000000000002 R09: ffffa01cdfd25724 Sep 27 06:28:58 [ 1715.504118][ C28] R10: 0000000000000018 R11: = 000000000000007b R12: ffffffff99222da0 Sep 27 06:28:58 [ 1715.536292][ C28] R13: 0000018f6997dcb8 R14: = 0000000000000001 R15: 0000000000000000 Sep 27 06:28:58 [ 1715.568539][ C28] ? cpuidle_enter_state+0x98/0x290 Sep 27 06:28:58 [ 1715.600850][ C28] cpuidle_enter+0x24/0x40 Sep 27 06:28:58 [ 1715.632878][ C28] cpuidle_idle_call+0xbb/0x100 Sep 27 06:28:58 [ 1715.664572][ C28] do_idle+0x76/0xc0 Sep 27 06:28:58 [ 1715.695803][ C28] cpu_startup_entry+0x14/0x20 Sep 27 06:28:58 [ 1715.726582][ C28] start_secondary+0xd6/0xe0 Sep 27 06:28:58 [ 1715.756507][ C28] = secondary_startup_64_no_verify+0xd3/0xdb Sep 27 06:28:58 [ 1715.785770][ C28] Sep 27 06:28:58 [ 1715.813710][ C28] ---[ end trace 0000000000000000 = ]--- Sep 27 06:28:58 [ 1715.840988][ C28] i40e 0000:03:00.0 eth0: = tx_timeout: VSI_seid: 390, Q 0, NTC: 0x697, HWB: 0x78c, NTU: 0x78c, = TAIL: 0x78c, INT: 0x0 Sep 27 06:28:58 [ 1715.896233][ C28] i40e 0000:03:00.0 eth0: = tx_timeout recovery level 1, txqueue 0 > On 26 Sep 2022, at 18:19, Florian Westphal wrote: >=20 > Michal Hocko wrote: >> On Mon 26-09-22 10:31:39, Florian Westphal wrote: >>> Martin Zaharinov reports BUG() in mm land for 5.19.10 kernel: >>> kernel BUG at mm/vmalloc.c:2437! >>> invalid opcode: 0000 [#1] SMP >>> CPU: 28 PID: 0 Comm: swapper/28 Tainted: G W O 5.19.9 = #1 >>> [..] >>> RIP: 0010:__get_vm_area_node+0x120/0x130 >>> __vmalloc_node_range+0x96/0x1e0 >>> kvmalloc_node+0x92/0xb0 >>> bucket_table_alloc.isra.0+0x47/0x140 >>> rhashtable_try_insert+0x3a4/0x440 >>> rhashtable_insert_slow+0x1b/0x30 >>> [..] >>>=20 >>> bucket_table_alloc uses kvzalloc(GPF_ATOMIC). If kmalloc fails, = this now >>> falls through to vmalloc and hits code paths that assume GFP_KERNEL. >>>=20 >>> I sent a patch to restore GFP_ATOMIC support in kvmalloc but mm >>> maintainers rejected it. >>>=20 >>> This patch is partial revert of >>> commit 93f976b5190d ("lib/rhashtable: simplify = bucket_table_alloc()"), >>> to avoid kvmalloc for ATOMIC case. >>>=20 >>> As kvmalloc doesn't warn when used with ATOMIC, kernel will only = crash >>> once vmalloc fallback occurs, so we may see more crashes in other = areas >>> in the future. >>>=20 >>> Most other callers seem ok but kvm_mmu_topup_memory_cache looks like = it >>> might be affected by the same breakage, so Cc kvm@. >>>=20 >>> Reported-by: Martin Zaharinov >>> Fixes: a421ef303008 ("mm: allow !GFP_KERNEL allocations for = kvmalloc") >>> Link: https://lore.kernel.org/linux-mm/Yy3MS2uhSgjF47dy@pc636/T/#t >>> Cc: Michal Hocko >>> Cc: Paolo Bonzini >>> Cc: kvm@vger.kernel.org >>> Signed-off-by: Florian Westphal >>=20 >> Please continue in the original email thread until we sort out the = most >> reasonable solution for this. >=20 > I've submitted a v2 using Michals proposed fix for kvmalloc api, if > thats merged no fixes are required in the callers, so this rhashtable > patch can be discarded.