From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757128AbcFAB2d (ORCPT ); Tue, 31 May 2016 21:28:33 -0400 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:35241 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752488AbcFAB2b convert rfc822-to-8bit (ORCPT ); Tue, 31 May 2016 21:28:31 -0400 Authentication-Results: ppops.net; spf=pass smtp.mailfrom=Paul.Handrigan@cirrus.com From: "Handrigan, Paul" To: Nicolin Chen , "broonie@kernel.org" CC: "lgirdwood@gmail.com" , "Austin, Brian" , "linux-kernel@vger.kernel.org" , "alsa-devel@alsa-project.org" Subject: Re: [PATCH 2/2] ASoC: cs53l30: Check return value of regcache_sync() Thread-Topic: [PATCH 2/2] ASoC: cs53l30: Check return value of regcache_sync() Thread-Index: AQHRu5Eel0P7QXkT50iK18hSmi5PA5/T0qiA Date: Wed, 1 Jun 2016 01:28:25 +0000 Message-ID: In-Reply-To: <1464735999-10384-2-git-send-email-nicoleotsuka@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.3.5.130515 x-originating-ip: [141.131.3.31] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-SPF-Result: pass X-Proofpoint-SPF-Record: v=spf1 include:spf-001ae601.pphosted.com ip4:141.131.128.20 ip4:141.131.3.20 ip4:213.128.236.230 ip4:87.246.98.25 ip4:87.246.78.26 -all X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606010015 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/31/16, 6:06 PM, "Nicolin Chen" wrote: >Regcache_sync() might fail. So this patch adds a return value Check for >it. > >Signed-off-by: Nicolin Chen >--- > sound/soc/codecs/cs53l30.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > >diff --git a/sound/soc/codecs/cs53l30.c b/sound/soc/codecs/cs53l30.c >index 9aff449..ac90dd7 100644 >--- a/sound/soc/codecs/cs53l30.c >+++ b/sound/soc/codecs/cs53l30.c >@@ -1055,7 +1055,11 @@ static int cs53l30_runtime_resume(struct device >*dev) > gpiod_set_value_cansleep(cs53l30->reset_gpio, 1); > > regcache_cache_only(cs53l30->regmap, false); >- regcache_sync(cs53l30->regmap); >+ ret = regcache_sync(cs53l30->regmap); >+ if (ret) { >+ dev_err(dev, "failed to synchronize regcache: %d\n", ret); >+ return ret; >+ } > > return 0; > } >-- >2.1.4 Acked-by: Paul Handrigan