From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752793AbcFFRal (ORCPT ); Mon, 6 Jun 2016 13:30:41 -0400 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:51309 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752115AbcFFRak convert rfc822-to-8bit (ORCPT ); Mon, 6 Jun 2016 13:30:40 -0400 Authentication-Results: ppops.net; spf=pass smtp.mailfrom=Paul.Handrigan@cirrus.com From: "Handrigan, Paul" To: Fabian Frederick , Nicolin Chen CC: "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" , "broonie@kernel.org" , Liam Girdwood Subject: Re: [alsa-devel] [PATCH V2 linux-next] ASoC: cs53l30: include gpio/consumer.h Thread-Topic: [alsa-devel] [PATCH V2 linux-next] ASoC: cs53l30: include gpio/consumer.h Thread-Index: AQHRwBkfua3/HWAAQU2A2lIl/WlbmA== Date: Mon, 6 Jun 2016 17:30:31 +0000 Message-ID: In-Reply-To: <1465232753-32492-1-git-send-email-fabf@skynet.be> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.3.5.130515 x-originating-ip: [141.131.38.212] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-SPF-Result: pass X-Proofpoint-SPF-Record: v=spf1 include:spf-001ae601.pphosted.com ip4:141.131.128.20 ip4:141.131.3.20 ip4:213.128.236.230 ip4:87.246.98.25 ip4:87.246.78.26 -all X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 impostorscore=0 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606060197 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/6/16, 12:05 PM, "Fabian Frederick" wrote: >cs53l30 breaks kernel compilation when CONFIG_GPIOLIB is disabled. > >sound/soc/codecs/cs53l30.c:931:2: error: implicit declaration of >function devm_gpiod_get_optional [-Werror=implicit-function-declaration] > cs53l30->reset_gpio = devm_gpiod_get_optional(dev, "reset", > ^ >sound/soc/codecs/cs53l30.c:932:13: error: GPIOD_OUT_LOW undeclared >(first use in this function) > >Including gpio/consumer.h declares minimal functions in that case. > >Signed-off-by: Fabian Frederick >--- >V2: > Add in alphabetical order (suggested by Nicolin Chen) > > sound/soc/codecs/cs53l30.c | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/sound/soc/codecs/cs53l30.c b/sound/soc/codecs/cs53l30.c >index ac90dd7..4f6ede9 100644 >--- a/sound/soc/codecs/cs53l30.c >+++ b/sound/soc/codecs/cs53l30.c >@@ -14,6 +14,7 @@ > > #include > #include >+#include > #include > #include > #include >-- >2.1.4 Thanks! Acked-by: Paul Handrigan