From: Andreas Dilger <adilger@dilger.ca>
To: Arnd Bergmann <arnd@arndb.de>
Cc: y2038@lists.linaro.org, Dave Chinner <david@fromorbit.com>,
linux-fsdevel@vger.kernel.org,
Deepa Dinamani <deepa.kernel@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [Y2038] [RFC 02/15] vfs: Change all structures to support 64 bit time
Date: Sat, 16 Jan 2016 19:30:55 -0700 [thread overview]
Message-ID: <D37C59DA-DFC7-4E18-8C53-5ACBC7B3FD4F@dilger.ca> (raw)
In-Reply-To: <6591497.mpSR1PpHzG@wuerfel>
[-- Attachment #1: Type: text/plain, Size: 1130 bytes --]
On Jan 16, 2016, at 4:36 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Saturday 16 January 2016 12:14:22 Andreas Dilger wrote:
>>>>
>>>> Sure, and nfs is a pain because of all it's internal use of
>>>> timespecs, too.
>>>
>>> lustre is probably the worst.
>>
>> Lustre currently only has one-second granularity in a 64-bit field,
>> so it doesn't really care about the difference between timespec or
>> timespec64 at all.
>>
>> The only other uses are for measuring relative times, so the 64-bitness
>> shouldn't really matter.
>>
>> Could you please point out what issues exist so they can be fixed.
>
> It's not really a bug that needs to be fixed, but more the general
> issue of referencing inode->i_?time and attr->ia_?time and passing
> them around. When we change the types in the inode and iattr from
> timespec to timespec64, all assigments need to be modified, and lustre
> has more of those assignments than any other file system I'm aware of.
All of those accesses are with the LTIME_S() macro to get/set only the
seconds field of the inode time, so it should only be a one-line patch?
Cheers, Andreas
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2016-01-17 2:31 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 5:35 [RFC 00/15] Add 64 bit timestamp support Deepa Dinamani
2016-01-07 5:35 ` [RFC 01/15] fs: add Kconfig entry CONFIG_FS_USES_64BIT_TIME Deepa Dinamani
2016-01-07 5:35 ` [RFC 02/15] vfs: Change all structures to support 64 bit time Deepa Dinamani
2016-01-10 23:03 ` Dave Chinner
2016-01-12 5:42 ` Deepa Dinamani
2016-01-12 8:29 ` Dave Chinner
2016-01-12 9:27 ` [Y2038] " Arnd Bergmann
2016-01-13 6:27 ` Dave Chinner
2016-01-13 9:20 ` Arnd Bergmann
2016-01-13 16:33 ` Deepa Dinamani
2016-01-13 21:04 ` Dave Chinner
2016-01-14 16:53 ` [Y2038] " Arnd Bergmann
2016-01-14 18:00 ` Deepa Dinamani
2016-01-14 21:00 ` Dave Chinner
2016-01-14 22:46 ` Arnd Bergmann
2016-01-14 22:54 ` Arnd Bergmann
2016-01-15 2:27 ` Dave Chinner
2016-01-15 17:01 ` Arnd Bergmann
2016-01-15 22:41 ` Dave Chinner
2016-01-15 2:49 ` Dave Chinner
2016-01-15 16:50 ` Arnd Bergmann
2016-01-16 19:14 ` Andreas Dilger
2016-01-16 23:36 ` Arnd Bergmann
2016-01-17 2:30 ` Andreas Dilger [this message]
2016-01-18 6:09 ` Deepa Dinamani
2016-01-18 10:56 ` Arnd Bergmann
2016-01-18 17:40 ` Deepa Dinamani
2016-01-18 19:53 ` Arnd Bergmann
2016-01-18 21:14 ` Dave Chinner
2016-01-18 21:46 ` Arnd Bergmann
2016-01-19 1:38 ` Dave Chinner
2016-01-19 5:27 ` Deepa Dinamani
2016-01-19 20:49 ` Dave Chinner
2016-01-19 22:25 ` Arnd Bergmann
2016-01-20 5:12 ` Deepa Dinamani
2016-01-20 15:04 ` Deepa Dinamani
2016-01-20 23:06 ` Dave Chinner
2016-01-20 23:17 ` [Y2038] " Arnd Bergmann
2016-01-27 6:26 ` Deepa Dinamani
2016-01-15 5:03 ` Deepa Dinamani
2016-01-07 5:36 ` [RFC 03/15] kernel: time: Add macros and functions " Deepa Dinamani
2016-01-07 5:36 ` [RFC 04/15] vfs: Add support for vfs code to use " Deepa Dinamani
2016-01-07 5:36 ` [RFC 05/15] fs: cifs: Add support for cifs " Deepa Dinamani
2016-01-07 5:36 ` [RFC 06/15] fs: fat: convert fat to " Deepa Dinamani
2016-01-07 5:36 ` [RFC 07/15] fs: ext4: convert to use " Deepa Dinamani
2016-01-07 5:36 ` [RFC 08/15] fs: Enable " Deepa Dinamani
2016-01-07 5:36 ` [RFC 09/15] fs: cifs: replace inode_timespec with timespec64 Deepa Dinamani
2016-01-07 5:36 ` [RFC 10/15] fs: fat: " Deepa Dinamani
2016-01-07 5:36 ` [RFC 11/15] fs: ext4: " Deepa Dinamani
2016-01-07 5:36 ` [RFC 12/15] vfs: remove inode_timespec and timespec references Deepa Dinamani
2016-01-07 5:36 ` [RFC 13/15] kernel: time: change inode_timespec to timespec64 Deepa Dinamani
2016-01-07 8:50 ` Michael Adam
2016-01-07 10:42 ` Deepa Dinamani
2016-01-07 5:36 ` [RFC 14/15] vfs: Remove inode_timespec aliases Deepa Dinamani
2016-01-07 5:36 ` [RFC 15/15] fs: Drop CONFIG_FS_USES_64BIT_TIME Deepa Dinamani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D37C59DA-DFC7-4E18-8C53-5ACBC7B3FD4F@dilger.ca \
--to=adilger@dilger.ca \
--cc=arnd@arndb.de \
--cc=david@fromorbit.com \
--cc=deepa.kernel@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®