From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F3AFC3DA6F for ; Thu, 24 Aug 2023 14:14:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236979AbjHXONi (ORCPT ); Thu, 24 Aug 2023 10:13:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241509AbjHXONe (ORCPT ); Thu, 24 Aug 2023 10:13:34 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94C2A1BC7 for ; Thu, 24 Aug 2023 07:12:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692886365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1YeFf3Wlrfc0CcBF8o0TQp1/prpVwhPD/RteH85vGLQ=; b=JMJ1o8LjkJglwCDpkjRiK4dGqoJpDKRMyeIY6XyTMRPisvJCN/WE5jC+giiQtA43yw361q eq+hYjuf9eqWllS0mQZ8qSogcRCS4igp6p7gMycQeQYwE5+8R6X5WqnFexHCOjP+Uki6vZ ipEgZm1a+525K6j1nf0/ubpnd4iMOzQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-617-_hajzuusPoSaJFW35qtFew-1; Thu, 24 Aug 2023 10:12:41 -0400 X-MC-Unique: _hajzuusPoSaJFW35qtFew-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2988F823F65; Thu, 24 Aug 2023 14:12:37 +0000 (UTC) Received: from [192.168.37.1] (ovpn-0-2.rdu2.redhat.com [10.22.0.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 85C8A140E963; Thu, 24 Aug 2023 14:12:35 +0000 (UTC) From: Benjamin Coddington To: Chuck Lever Cc: kernel test robot , oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, Jeff Layton , linux-nfs@vger.kernel.org, ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com Subject: Re: [linus:master] [NFSD] 39d432fc76: fsmark.files_per_sec -100.0% regression Date: Thu, 24 Aug 2023 10:12:33 -0400 Message-ID: In-Reply-To: References: <202308241229.68396422-oliver.sang@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24 Aug 2023, at 9:23, Chuck Lever wrote: > On Thu, Aug 24, 2023 at 01:59:06PM +0800, kernel test robot wrote: >> >> >> hi, Chuck Lever, >> >> Fengwei (CCed) helped us review this astonishing finding by fsmark tests, >> and doubt below part: >> - nfsd4_end_grace(nn); >> + trace_nfsd_end_grace(netns(file)); >> >> and confirmed if adding back: >> nfsd4_end_grace(nn); >> >> the regression is gone and files_per_sec restore to 61.93. > > As always, thanks for the report. However, this result is not > plausible. "end_grace" happens only once after a server reboot. > > Can you confirm that the NFS server kernel is not crashing > during the test? Does the removal of nfsd4_end_grace() here disable the ability of nfsdcltrack to terminate the grace period early on a first start of the server? Ben