From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753318AbcFQSxa (ORCPT ); Fri, 17 Jun 2016 14:53:30 -0400 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:53974 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751097AbcFQSx2 convert rfc822-to-8bit (ORCPT ); Fri, 17 Jun 2016 14:53:28 -0400 Authentication-Results: ppops.net; spf=pass smtp.mailfrom=Paul.Handrigan@cirrus.com From: "Handrigan, Paul" To: "weiyj_lk@163.com" , "Austin, Brian" , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai CC: Wei Yongjun , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH -next] ASoC: cs53l30: Fix non static symbol warnings Thread-Topic: [PATCH -next] ASoC: cs53l30: Fix non static symbol warnings Thread-Index: AQHRyLzLSWNd7OMkS06sQwQnwqHiw5/uAXkA Date: Fri, 17 Jun 2016 18:53:03 +0000 Message-ID: In-Reply-To: <1466184120-13062-1-git-send-email-weiyj_lk@163.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.3.5.130515 x-originating-ip: [141.131.38.212] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-SPF-Result: pass X-Proofpoint-SPF-Record: v=spf1 include:spf-001ae601.pphosted.com ip4:141.131.128.20 ip4:141.131.3.20 ip4:213.128.236.230 ip4:87.246.98.25 ip4:87.246.78.26 -all X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 impostorscore=0 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606170216 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/17/16, 12:22 PM, "weiyj_lk@163.com" wrote: >From: Wei Yongjun > >Fixes the following sparse warnings: > >sound/soc/codecs/cs53l30.c:182:20: warning: > symbol 'input1_sel_values' was not declared. Should it be static? >sound/soc/codecs/cs53l30.c:202:20: warning: > symbol 'input2_sel_values' was not declared. Should it be static? >sound/soc/codecs/cs53l30.c:734:20: warning: > symbol 'cs53l30_src_rates' was not declared. Should it be static? > >Signed-off-by: Wei Yongjun >--- > sound/soc/codecs/cs53l30.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/sound/soc/codecs/cs53l30.c b/sound/soc/codecs/cs53l30.c >index 714e579..a9949ad 100644 >--- a/sound/soc/codecs/cs53l30.c >+++ b/sound/soc/codecs/cs53l30.c >@@ -179,7 +179,7 @@ static const char * const input1_sel_text[] = { > "DMIC1 Off ADC1 Off", > }; > >-unsigned int const input1_sel_values[] = { >+static unsigned int const input1_sel_values[] = { > CS53L30_CH_TYPE, > CS53L30_ADCxB_PDN | CS53L30_CH_TYPE, > CS53L30_ADCxA_PDN | CS53L30_CH_TYPE, >@@ -199,7 +199,7 @@ static const char * const input2_sel_text[] = { > "DMIC2 Off ADC2 Off", > }; > >-unsigned int const input2_sel_values[] = { >+static unsigned int const input2_sel_values[] = { > 0x0, > CS53L30_ADCxB_PDN, > CS53L30_ADCxA_PDN, >@@ -731,7 +731,7 @@ static int cs53l30_set_tristate(struct snd_soc_dai >*dai, int tristate) > CS53L30_ASP_3ST_MASK, val); > } > >-unsigned int const cs53l30_src_rates[] = { >+static unsigned int const cs53l30_src_rates[] = { > 8000, 11025, 12000, 16000, 22050, 24000, 32000, 44100, 48000 > }; Acked-by: Paul Handrigan