From: Marcel Holtmann <marcel@holtmann.org>
To: Joseph Hwang <josephsih@chromium.org>
Cc: linux-bluetooth <linux-bluetooth@vger.kernel.org>,
"Luiz Augusto von Dentz" <luiz.dentz@gmail.com>,
"Pali Rohár" <pali@kernel.org>,
"Joseph Hwang" <josephsih@google.com>,
"CrosBT Upstreaming"
<chromeos-bluetooth-upstreaming@chromium.org>,
"kernel test robot" <lkp@intel.com>,
"Miao-chen Chou" <mcchou@chromium.org>,
"Johan Hedberg" <johan.hedberg@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] Bluetooth: btandroid: Support Android Bluetooth Quality Report
Date: Mon, 13 Sep 2021 16:32:45 +0200 [thread overview]
Message-ID: <D38B22EC-EFC8-44A0-84BE-F3710380C022@holtmann.org> (raw)
In-Reply-To: <20210913152801.v3.1.I17f57656757b83a1c0fb4b78525d8aca581725db@changeid>
Hi Joseph,
> Add the btandroid.c file to support Android BQR commands.
>
> This module may be referenced by btusb, btrtl, and hci_qca when a
> Bluetooth controller supports the Android Bluetooth Quality Report.
>
> Reported-by: kernel test robot <lkp@intel.com>
>
> Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
> Signed-off-by: Joseph Hwang <josephsih@chromium.org>
> ---
>
> Changes in v3:
> - Fix the auto build test ERROR
> "undefined symbol: btandroid_set_quality_report" that occurred
> with some kernel configs.
> - Note that the mgmt-tester "Read Exp Feature - Success" failed.
> But on my test device, the same test passed. Please kindly let me
> know what may be going wrong. These patches do not actually
> modify read/set experimental features.
> - As to CheckPatch failed. No need to modify the MAINTAINERS file.
> Thanks.
>
> Changes in v2:
> - Fix the titles of patches 2/3 and 3/3 and reduce their lengths.
>
> drivers/bluetooth/Kconfig | 5 ++
> drivers/bluetooth/Makefile | 1 +
> drivers/bluetooth/btandroid.c | 106 ++++++++++++++++++++++++++++++++++
> drivers/bluetooth/btandroid.h | 10 ++++
> 4 files changed, 122 insertions(+)
> create mode 100644 drivers/bluetooth/btandroid.c
> create mode 100644 drivers/bluetooth/btandroid.h
I am confused now. Did you read my review comments? I do _not_ want it this way; so please read my previous response and don’t send the exact same patch again.
Regards
Marcel
next prev parent reply other threads:[~2021-09-13 14:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 7:28 Joseph Hwang
2021-09-13 7:28 ` [PATCH v3 2/3] Bluetooth: hci_qca: Set up Qualcomm WCN399x for Android BQR commands Joseph Hwang
2021-09-13 7:28 ` [PATCH v3 3/3] Bluetooth: btrtl: Set up Realtek 8822CE " Joseph Hwang
2021-09-13 9:55 ` [PATCH v3 1/3] Bluetooth: btandroid: Support Android Bluetooth Quality Report Pavel Machek
2021-09-13 14:32 ` Marcel Holtmann [this message]
2021-09-26 7:14 ` Joseph Hwang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D38B22EC-EFC8-44A0-84BE-F3710380C022@holtmann.org \
--to=marcel@holtmann.org \
--cc=chromeos-bluetooth-upstreaming@chromium.org \
--cc=johan.hedberg@gmail.com \
--cc=josephsih@chromium.org \
--cc=josephsih@google.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=luiz.dentz@gmail.com \
--cc=mcchou@chromium.org \
--cc=pali@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®