From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754666AbcFTPgJ (ORCPT ); Mon, 20 Jun 2016 11:36:09 -0400 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:56707 "EHLO mx0a-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753291AbcFTPf4 convert rfc822-to-8bit (ORCPT ); Mon, 20 Jun 2016 11:35:56 -0400 Authentication-Results: ppops.net; spf=pass smtp.mailfrom=Paul.Handrigan@cirrus.com From: "Handrigan, Paul" To: Nicolin Chen , "broonie@kernel.org" CC: "lgirdwood@gmail.com" , "Austin, Brian" , "linux-kernel@vger.kernel.org" , "alsa-devel@alsa-project.org" Subject: Re: [PATCH] ASoC: cs53l30: Set idle_bias_off true Thread-Topic: [PATCH] ASoC: cs53l30: Set idle_bias_off true Thread-Index: AQHRyQE2fksP0rbUQESPrM/sJRXvwp/ygNSA Date: Mon, 20 Jun 2016 15:35:51 +0000 Message-ID: In-Reply-To: <1466213517-18523-1-git-send-email-nicoleotsuka@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.3.5.130515 x-originating-ip: [141.131.38.212] Content-Type: text/plain; charset="us-ascii" Content-ID: <1919694E975E7A4484A2C030BA78044E@ad.cirrus.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-SPF-Result: pass X-Proofpoint-SPF-Record: v=spf1 include:spf-001ae601.pphosted.com ip4:141.131.128.20 ip4:141.131.3.20 ip4:213.128.236.230 ip4:87.246.98.25 ip4:87.246.78.26 -all X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606200172 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/17/16, 8:31 PM, "Nicolin Chen" wrote: >The driver is using the set_bias_level to control the power on and >off so it should get SND_SOC_BIAS_OFF in order to proceed normal >powering sequences. This patch enables the idle_bias_off option so >the DAPM core will set the bias level to SND_SOC_BIAS_OFF instead >of stopping at SND_SOC_BIAS_STANDBY. > >Signed-off-by: Nicolin Chen >--- > sound/soc/codecs/cs53l30.c | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/sound/soc/codecs/cs53l30.c b/sound/soc/codecs/cs53l30.c >index a5976f3..b0a64a1 100644 >--- a/sound/soc/codecs/cs53l30.c >+++ b/sound/soc/codecs/cs53l30.c >@@ -879,6 +879,7 @@ static int cs53l30_codec_probe(struct snd_soc_codec >*codec) > static struct snd_soc_codec_driver cs53l30_driver = { > .probe = cs53l30_codec_probe, > .set_bias_level = cs53l30_set_bias_level, >+ .idle_bias_off = true, > > .dapm_widgets = cs53l30_dapm_widgets, > .num_dapm_widgets = ARRAY_SIZE(cs53l30_dapm_widgets), >-- >2.1.4 Thanks! Acked-by: Paul Handrigan >