From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753008AbcF2Os2 (ORCPT ); Wed, 29 Jun 2016 10:48:28 -0400 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:60886 "EHLO mx0a-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752656AbcF2Os0 convert rfc822-to-8bit (ORCPT ); Wed, 29 Jun 2016 10:48:26 -0400 Authentication-Results: ppops.net; spf=pass smtp.mailfrom=Paul.Handrigan@cirrus.com From: "Handrigan, Paul" To: Arnd Bergmann , Mark Brown CC: "Austin, Brian" , Liam Girdwood , Axel Lin , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ASoC: cs35l33: mark PM functions as __maybe_unused Thread-Topic: [PATCH] ASoC: cs35l33: mark PM functions as __maybe_unused Thread-Index: AQHR0hL0RRW4G4Z5X0KeKk58Y1f5IqAAhmEA Date: Wed, 29 Jun 2016 14:48:15 +0000 Message-ID: In-Reply-To: <20160629143416.45214-1-arnd@arndb.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.3.5.130515 x-originating-ip: [141.131.38.212] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-SPF-Result: pass X-Proofpoint-SPF-Record: v=spf1 include:spf-001ae601.pphosted.com ip4:141.131.128.20 ip4:141.131.3.20 ip4:213.128.236.230 ip4:87.246.98.25 ip4:87.246.78.26 -all X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 impostorscore=0 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606290138 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/29/16, 9:33 AM, "Arnd Bergmann" wrote: >The newly added cs35l33 driver produces a harmless warning when >CONFIG_PM is disabled: > >sound/soc/codecs/cs35l33.c:908:12: error: 'cs35l33_runtime_suspend' >defined but not used [-Werror=unused-function] >sound/soc/codecs/cs35l33.c:868:12: error: 'cs35l33_runtime_resume' >defined but not used [-Werror=unused-function] > >This adds __maybe_unused annotations to shut up the warning >regardless of the configuration. > >Signed-off-by: Arnd Bergmann >--- > sound/soc/codecs/cs35l33.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/sound/soc/codecs/cs35l33.c b/sound/soc/codecs/cs35l33.c >index 622a1111b21c..d8b5fc3fc45d 100644 >--- a/sound/soc/codecs/cs35l33.c >+++ b/sound/soc/codecs/cs35l33.c >@@ -862,7 +862,7 @@ static const struct regmap_config cs35l33_regmap = { > .use_single_rw = true, > }; > >-static int cs35l33_runtime_resume(struct device *dev) >+static int __maybe_unused cs35l33_runtime_resume(struct device *dev) > { > struct cs35l33_private *cs35l33 = dev_get_drvdata(dev); > int ret; >@@ -902,7 +902,7 @@ err: > return ret; > } > >-static int cs35l33_runtime_suspend(struct device *dev) >+static int __maybe_unused cs35l33_runtime_suspend(struct device *dev) > { > struct cs35l33_private *cs35l33 = dev_get_drvdata(dev); > >-- >2.9.0 Thanks! Acked-by: Paul Handrigan