From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933337AbcIALbh (ORCPT ); Thu, 1 Sep 2016 07:31:37 -0400 Received: from mail-bl2nam02on0115.outbound.protection.outlook.com ([104.47.38.115]:43936 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932357AbcIALbe (ORCPT ); Thu, 1 Sep 2016 07:31:34 -0400 X-Greylist: delayed 1928 seconds by postgrey-1.27 at vger.kernel.org; Thu, 01 Sep 2016 07:31:34 EDT From: Nilesh Javali To: Baoyou Xie , Dept-Eng QLogic Storage Upstream , "jejb@linux.vnet.ibm.com" CC: linux-scsi , linux-kernel , "arnd@linaro.org" , "xie.baoyou@zte.com.cn" Subject: Re: [PATCH] [SCSI] qla4xxx: mark symbols static where possible Thread-Topic: [PATCH] [SCSI] qla4xxx: mark symbols static where possible Thread-Index: AQHSAeK5zggrIO4gbkOX2/WsNQz896Bk2BqA Date: Thu, 1 Sep 2016 10:59:01 +0000 Message-ID: References: <1472467611-8574-1-git-send-email-baoyou.xie@linaro.org> In-Reply-To: <1472467611-8574-1-git-send-email-baoyou.xie@linaro.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.6.5.160527 authentication-results: spf=none (sender IP is ) smtp.mailfrom=nilesh.javali@qlogic.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [114.143.185.87] x-ld-processed: 0d68a1f9-1490-4d0e-8767-a87dab3ef2ba,ExtAddr,ExtAddr x-ms-office365-filtering-correlation-id: 24d730a6-ef5b-4b33-4e30-08d3d256fb97 x-microsoft-exchange-diagnostics: 1;DM3PR1101MB1214;6:5UmjFxSLZ428SAWprMst7CdXpc4iVRmjlfcdV6+qejH58O7vo/GvLbdAbrHi/GE4jEAg9x6sHREE3mDza5YEHvK0+NZgEAsIXJbauqCo/08M224QWQeEF3e5V1jIaLMlxqNgrf0/TL97XPRR3rEQOCE99zIQSZxnSkKAHQOX+S5EQwfxH7k2zSckIpyK0j8bLCz2pPDEnaZT1FcOlrfnvoHdmW7I2YTii80NBF9ZXW/SNXOl1Bx8wuANKwSgU1+e61Qibs2VYLEun25awDX+ldUKCUReZiR4X+Mo7+AGsGc=;5:Fhks1bbZQ2W2SsZSayUhcEcickrg0v87tpMtokUzryQ267B7eDqPogPZdQk9JFtw04vpLtuKnWj7jFbevxGiMN8pkeilm1piD2Yy5N4PlvjDcBWpTkWslkWV1CviJDrqrBcI48n8X3ao6OSTnKliNg==;24:3UQ+nfuvYi7I74Vd1MN6O4Jk/jpuhmLrtBXHmCmhLsoOr1hjBQwRqc5FiikhUfaeWvTbCXWlBXFHRUMUOIMG0fFMtZWmbPmEcFEPJlo/vRE=;7:+CymUceorTPpp6K6lchGXlIjOCIAtO2icnzfV85aDP6tQ3+TFHhfuG2RJjU5pAKP12KI7L+tP4m5BydTD2Vpz3isSRzlNrSnOC70SIjpURcy6pVcqHx3Ww1JdPOO58/etESJLOVW18tBZ7AWpK/3IGR1cniCcXqeST8Hb3fuMqAF7Bvpa+WuXD1RzxPmgZQZagrFQm3F6H16E6V1LnRUP1y/P7khSKg4cIIMXF9ge06FnfDz7WvbMLF0u3QWfUqb x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM3PR1101MB1214; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:DM3PR1101MB1214;BCL:0;PCL:0;RULEID:;SRVR:DM3PR1101MB1214; x-forefront-prvs: 0052308DC6 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(979002)(6009001)(7916002)(24454002)(189002)(377454003)(199003)(8676002)(7846002)(5660300001)(97736004)(68736007)(86362001)(5001770100001)(83506001)(66066001)(19580405001)(4326007)(3280700002)(19580395003)(2900100001)(2950100001)(122556002)(3660700001)(92566002)(106356001)(586003)(6116002)(102836003)(4001350100001)(3846002)(105586002)(11100500001)(87936001)(106116001)(2906002)(50986999)(99286002)(54356999)(5002640100001)(101416001)(76176999)(2501003)(8936002)(81166006)(81156014)(36756003)(305945005)(189998001)(10400500002)(7736002)(77096005)(32563001)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM3PR1101MB1214;H:DM3PR1101MB1214.namprd11.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <81088465690B284E9111337D6F461980@namprd11.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: qlogic.com X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2016 10:59:01.3003 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0d68a1f9-1490-4d0e-8767-a87dab3ef2ba X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR1101MB1214 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u81BVgDr011755 On 29/08/16 4:16 PM, "Baoyou Xie" wrote: >We get 1 warning when build kernel with W=1: >drivers/scsi/qla4xxx/ql4_nx.c:1846:10: warning: no previous prototype for >'ql4_84xx_ipmdio_rd_reg' [-Wmissing-prototypes] > >In fact, this function is only used in the file in which it is >declared and don't need a declaration, but can be made static. >so this patch marks this function with 'static'. > >Signed-off-by: Baoyou Xie >--- > drivers/scsi/qla4xxx/ql4_nx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/scsi/qla4xxx/ql4_nx.c b/drivers/scsi/qla4xxx/ql4_nx.c >index ae87d6c..06ddd13 100644 >--- a/drivers/scsi/qla4xxx/ql4_nx.c >+++ b/drivers/scsi/qla4xxx/ql4_nx.c >@@ -1843,7 +1843,7 @@ static uint32_t ql4_84xx_poll_wait_for_ready(struct >scsi_qla_host *ha, > return rval; > } > >-uint32_t ql4_84xx_ipmdio_rd_reg(struct scsi_qla_host *ha, uint32_t addr1, >+static uint32_t ql4_84xx_ipmdio_rd_reg(struct scsi_qla_host *ha, >uint32_t addr1, > uint32_t addr3, uint32_t mask, uint32_t addr, > uint32_t *data_ptr) > { >-- >2.7.4 Acked-by: Nilesh Javali