From: Esko Mobius <echoowall@gmail.com>
To: Eric Dumazet <edumazet@kernel.org>
Cc: Jiayuan Chen <jiayuan.chen@linux.dev>,
netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Simon Horman <horms@kernel.org>, David Ahern <dsahern@kernel.org>,
Ido Schimmel <idosch@nvidia.com>, Shuah Khan <shuah@kernel.org>,
Thorsten Leemhuis <regressions@leemhuis.info>,
regressions@lists.linux.dev, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net 2/2] Revert "net: advertise TCP MSS from the configured MTU, not the learned PMTU"
Date: Tue, 27 Oct 2026 21:12:52 +0800 [thread overview]
Message-ID: <D438C59D-09D4-4008-9240-18DA0ABBDCEA@gmail.com> (raw)
In-Reply-To: <CAL4Wiip=TkP2hmOFR-1Y-CU4rYHY_q=TBDhK6RmTj9UEMQ95Gw@mail.gmail.com>
On 10/27/26 1:45 PM, Jiayuan Chen wrote:
> This precondition does all the work. The server only learns the PMTU
> when it sends a full-size segment itself. [...]
>
> Please re-run the 6.12.107 case without seeding the PMTU.
You are right. Without seeding, 6.12.107 stalls the same way:
kernel PMTU seeded SYN-ACK MSS 1 MB upload
6.12.107 no 1460 stalls
6.12.107 yes (ping) 1416 OK
My reproducer took a shortcut there. What it should have modelled is
our production setup, which is the masquerading relay you describe:
the clients share the relay's address, so ordinary downloads by other
clients keep the server's PMTU entry fresh. Modelling that directly,
with no artificial seeding (cliA downloads 1 MB, then cliB, behind a
firewall dropping frag-needed, uploads 1 MB through the same relay):
kernel SYN-ACK MSS to cliB cliB upload
6.12.107 1416 OK
6.12.111 1460 stalls
So I agree it was never a designed mechanism, it is the side effect
Eric describes. We have since added MSS clamping on our relays.
If it helps, I can send a v2 that describes the masquerading case
instead of the seeded one in the changelog. And I am happy to test
the net-next follow-up on this setup.
Thanks,
Esko
next prev parent reply other threads:[~2026-10-27 13:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 7:23 [PATCH net 0/2] Revert advertising the TCP MSS from the configured MTU Esko Mobius via B4 Relay
2026-10-26 7:23 ` [PATCH net 1/2] Revert "selftests: net: packetdrill: add tests for advertised MSS with PMTU exceptions" Esko Mobius via B4 Relay
2026-10-27 11:44 ` Jiayuan Chen
2026-10-26 7:23 ` [PATCH net 2/2] Revert "net: advertise TCP MSS from the configured MTU, not the learned PMTU" Esko Mobius via B4 Relay
2026-10-27 12:45 ` Jiayuan Chen
2026-10-27 13:02 ` Eric Dumazet
2026-10-27 13:12 ` Esko Mobius [this message]
2026-10-27 13:44 ` Jiayuan Chen
2026-10-27 23:18 ` Jakub Kicinski
2026-10-28 3:38 ` Esko Mobius
2026-10-26 13:28 ` [PATCH net 0/2] Revert advertising the TCP MSS from the configured MTU Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D438C59D-09D4-4008-9240-18DA0ABBDCEA@gmail.com \
--to=echoowall@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jiayuan.chen@linux.dev \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=regressions@leemhuis.info \
--cc=regressions@lists.linux.dev \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®