From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751880AbdB1LaT (ORCPT ); Tue, 28 Feb 2017 06:30:19 -0500 Received: from mail-bn3nam01on0065.outbound.protection.outlook.com ([104.47.33.65]:21944 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751507AbdB1LaO (ORCPT ); Tue, 28 Feb 2017 06:30:14 -0500 From: "Rangankar, Manish" To: Colin King , Dept-Eng QLogic Storage Upstream , "James E . J . Bottomley" , "Martin K . Petersen" , "linux-scsi@vger.kernel.org" CC: "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] scsi: qedi: fix missing return error code check on call to qedi_setup_int Thread-Topic: [PATCH] scsi: qedi: fix missing return error code check on call to qedi_setup_int Thread-Index: AQHSkbI25zdD7q4SP0SGPz5u1rQtLaF+pKsA Date: Tue, 28 Feb 2017 11:29:34 +0000 Message-ID: References: <20170228110248.19290-1-colin.king@canonical.com> In-Reply-To: <20170228110248.19290-1-colin.king@canonical.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Manish.Rangankar@cavium.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [114.143.185.87] x-ms-office365-filtering-correlation-id: 75b203ff-0a80-4a4d-46ab-08d45fcd124f x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BN3PR07MB2481; x-microsoft-exchange-diagnostics: 1;BN3PR07MB2481;7:FEEQUOtOl7jI5D0lb4iEswuMOtfwJEY061eQFeDH5eraF/5/Qqlmb8lqt0p8Z736Ih3zw49NVW58NnDgB61Wob40W+xYVgPm35e7CL1T6VLfudvQU9CDbb1z4fwudaZJqiMNDP9mZbGB+EKdugvYK0dGvlB93zSDSjtO5iJF6flyp190BIULeubX+1oy18hZ7RkxyN12fAtt5fEa8aPBYE4o/Mzjohb4y5kgWJ/Y5z6XWjFJCou3yt14+vtSEc00zknbnc/fH930ad0yGKA77x54H/5RaBiJgS2Ir9/S6NMhxK0E7S60SsBv7xYKYZr2a5fC9UjyuIpSxlbi9KLLBQ== x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(198206253151910); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123558025)(20161123555025)(20161123560025)(20161123562025)(20161123564025)(6072148);SRVR:BN3PR07MB2481;BCL:0;PCL:0;RULEID:;SRVR:BN3PR07MB2481; x-forefront-prvs: 0232B30BBC x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(39450400003)(377454003)(24454002)(189002)(199003)(92566002)(3280700002)(6506006)(122556002)(2950100002)(5660300001)(305945005)(101416001)(53546006)(77096006)(3660700001)(6116002)(6486002)(99286003)(53936002)(97736004)(105586002)(6512007)(25786008)(54906002)(106116001)(6246003)(38730400002)(106356001)(6436002)(2906002)(68736007)(81156014)(7736002)(76176999)(50986999)(54356999)(229853002)(81166006)(2501003)(36756003)(102836003)(189998001)(3846002)(2900100001)(8936002)(66066001)(8676002)(4326007)(86362001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR07MB2481;H:BN3PR07MB2483.namprd07.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <26BD04D72FB7E548B9028670F3873272@namprd07.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2017 11:29:34.4171 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR07MB2481 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v1SBUWKi014444 On 28/02/17 4:32 PM, "Colin King" wrote: >From: Colin Ian King > >The call to qedi_setup_int is not updating the return code rc yet rc >is being checked for an error. Fix this by assigning rc to the return >code from the call to qedi_setup_int. > >Signed-off-by: Colin Ian King >--- > drivers/scsi/qedi/qedi_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c >index 5eda21d..8e3d928 100644 >--- a/drivers/scsi/qedi/qedi_main.c >+++ b/drivers/scsi/qedi/qedi_main.c >@@ -1805,7 +1805,7 @@ static int __qedi_probe(struct pci_dev *pdev, int >mode) > */ > qedi_ops->common->update_pf_params(qedi->cdev, &qedi->pf_params); > >- qedi_setup_int(qedi); >+ rc = qedi_setup_int(qedi); > if (rc) > goto stop_iscsi_func; > >-- >2.10.2 > Acked-by: Manish Rangankar