mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Singh, Brijeshkumar" <Brijeshkumar.Singh@amd.com>
To: "minyard@acm.org" <minyard@acm.org>,
	yalin wang <yalin.wang2010@gmail.com>
Cc: "openipmi-developer@lists.sourceforge.net" 
	<openipmi-developer@lists.sourceforge.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] ipmi: add of_device_id in MODULE_DEVICE_TABLE
Date: Tue, 25 Aug 2015 12:02:57 +0000	[thread overview]
Message-ID: <D506FF644BBE48498B87295D58C770F820EBA6FD@satlexdag03.amd.com> (raw)
In-Reply-To: <55DC58B5.1070001@acm.org>

Hi,

I have compile tested on both x86 and arm64 on 4.1, but today will try with 4.2 and send updated patch. Thanks

-Brijesh
________________________________________
From: Corey Minyard [tcminyard@gmail.com] on behalf of Corey Minyard [minyard@acm.org]
Sent: Tuesday, August 25, 2015 6:59 AM
To: yalin wang
Cc: Singh, Brijeshkumar; openipmi-developer@lists.sourceforge.net; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipmi: add of_device_id in MODULE_DEVICE_TABLE

On 08/24/2015 09:04 PM, yalin wang wrote:
>> On Aug 25, 2015, at 08:48, Corey Minyard <minyard@acm.org> wrote:
>>
>> Well, I should have compile tested first.  On x86_64:
>>
>>
>>  CC [M]  drivers/char/ipmi/ipmi_si_intf.o
>> In file included from ../drivers/char/ipmi/ipmi_si_intf.c:42:0:
>> ../drivers/char/ipmi/ipmi_si_intf.c:2804:25: error: ‘ipmi_match’
>> undeclared here (not in a function)
>> MODULE_DEVICE_TABLE(of, ipmi_match);
>>                         ^
>> ../include/linux/module.h:223:21: note: in definition of macro
>> ‘MODULE_DEVICE_TABLE’
>> extern const typeof(name) __mod_##type##__##name##_device_table \
>>                     ^
>> ../include/linux/module.h:223:27: error:
>> ‘__mod_of__ipmi_match_device_table’ aliased to undefined symbol ‘ipmi_match’
>> extern const typeof(name) __mod_##type##__##name##_device_table \
>>                           ^
>> ../drivers/char/ipmi/ipmi_si_intf.c:2804:1: note: in expansion of macro
>> ‘MODULE_DEVICE_TABLE’
>> MODULE_DEVICE_TABLE(of, ipmi_match);
>>
>>
>> This has to compile on all arches.  I'm not sure what is wrong, but I've
>> removed the patch.
>>
>> -corey
> it seems should be :
>
> MODULE_DEVICE_TABLE(of, of_ipmi_match);
I actually already tried that, and it fails to compile on x86_64, too,
with a different error.

-corey

  reply	other threads:[~2015-08-25 12:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-24 14:15 Brijesh Singh
2015-08-24 21:36 ` Corey Minyard
2015-08-25  0:48 ` Corey Minyard
2015-08-25  2:04   ` yalin wang
2015-08-25 11:59     ` Corey Minyard
2015-08-25 12:02       ` Singh, Brijeshkumar [this message]
2015-08-25 14:50   ` Singh, Brijeshkumar
2015-08-26 14:57     ` Corey Minyard
2015-08-26 16:03       ` Singh, Brijeshkumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D506FF644BBE48498B87295D58C770F820EBA6FD@satlexdag03.amd.com \
    --to=brijeshkumar.singh@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minyard@acm.org \
    --cc=openipmi-developer@lists.sourceforge.net \
    --cc=yalin.wang2010@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®