From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751025AbdEXRMZ (ORCPT ); Wed, 24 May 2017 13:12:25 -0400 Received: from mail-co1nam03on0062.outbound.protection.outlook.com ([104.47.40.62]:50976 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750746AbdEXRMW (ORCPT ); Wed, 24 May 2017 13:12:22 -0400 From: "Malavali, Giridhar" To: Bart Van Assche , "jthumshirn@suse.de" , "martin.petersen@oracle.com" CC: "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Madhani, Himanshu" , Dept-Eng QLA2xxx Upstream Subject: Re: [PATCH] qla2xxx: don't disable a not previously enabled PCI device Thread-Topic: [PATCH] qla2xxx: don't disable a not previously enabled PCI device Thread-Index: AQHS09P/B+oVRCZ9TE2QaibuaFQXz6IDol4A//+iZwA= Date: Wed, 24 May 2017 17:12:19 +0000 Message-ID: References: <20170523145047.5020-1-jthumshirn@suse.de> <1495640832.2823.5.camel@sandisk.com> In-Reply-To: <1495640832.2823.5.camel@sandisk.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: sandisk.com; dkim=none (message not signed) header.d=none;sandisk.com; dmarc=none action=none header.from=cavium.com; x-originating-ip: [73.158.170.32] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR07MB3449;5:4ZdAPdhLpSjLXWDmD95khhE3b/+iJm1lOlwTu1js/LZ7+CfmVW4vQwPLmATmdOIVGKwF1EF2HS/WrF+u71dpI/wNp3ESTiBI1aPWSF0gKDUFfIikQWDO2jBJGoLgSE6dURztJOGXGd0e3Dgyxj/OknqekRPHbMDXTwl3/DBe7xng59epFiNPSgUyo7vVlGHEF9pYk8ii5fyPvTlMG85ykLuy6EMYyLeS5jA9BiF0aGpnDT5Hknba/PEFRmS18QrdfLls8DUiy/h58wEzcTECS909LtP6r4vZYoQXKwqgTS8YdyVpNG/Rkb4qGXC1amE95ip6Wjt7b6MHTTI9dmIv5k6gs0d81c64aXvV+wf2wRHnlOCh7g0LbbnToihDdZr4xfoIiA/IdNdc/rUM7FUB+RXdg8NP4UL/iTvKwDgDQHTt4D081yeQk2e/Q6kHFh7L3PenzwjCKPwhltuXw+/TQw==;24:prsHWnT0fbt/i9dMkDR+cUFHG5bUMxMa9B70Khay62vYLn+r+r++2RGL8KbW9U2LOriosMOWzKidvhASXHI+3JvyF62+njY73qoOcNgpMXI=;7:VqsaH8g3CetY8xEh6+qaoKuXxQLcAv7yngq9CYXToevsYo0IRgnCOat8Z0R1rodFT1w9Ry+xqU8EDcBBlMdr4qHHR2jTi4L1htIirVc+qjWPbeKYpDmL2wETVTaHeJakZWi/5VQlKft8r+zwE/tWpnOGIOJDVFZxAsb5qnWysOubjQp7mz9eo93rh4YGsxLfE9+QuAjQELpYe/+qqNe9zzM/m9S6refmVEtKoPuIXwXIyBZ9/RjIHAHsBDDDSWL0rtj652fik9Bg2GiztFv/mB4wOKmzZbDwqiZ+k1Lh95TqHPl75sKZe2HhNvXComcPaIjCHvkV8QnvL0gXsvh+EQ== x-ms-traffictypediagnostic: DM5PR07MB3449: x-ms-office365-filtering-correlation-id: 352364de-88cc-4280-5c22-08d4a2c80955 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(201703131423075)(201703031133081);SRVR:DM5PR07MB3449; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(42932892334569); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700054)(100105000095)(100000701054)(100105300095)(100000702054)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(100000703054)(100105400095)(6041248)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(20161123558100)(20161123560025)(6072148)(100000704054)(100105200095)(100000705054)(100105500095);SRVR:DM5PR07MB3449;BCL:0;PCL:0;RULEID:(100000800054)(100110000095)(100000801054)(100110300095)(100000802054)(100110100095)(100000803054)(100110400095)(100000804054)(100110200095);SRVR:DM5PR07MB3449; x-forefront-prvs: 031763BCAF x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39410400002)(39400400002)(39840400002)(39450400003)(39850400002)(377454003)(377424004)(24454002)(8676002)(36756003)(478600001)(72206003)(53546009)(86362001)(25786009)(81166006)(66066001)(102836003)(3846002)(6116002)(8936002)(2906002)(2900100001)(229853002)(189998001)(2201001)(5660300001)(6506006)(77096006)(6486002)(6436002)(2950100002)(122556002)(50986999)(76176999)(3280700002)(6246003)(305945005)(107886003)(38730400002)(54356999)(53936002)(8656002)(99286003)(3660700001)(6512007)(54906002)(4326008)(7736002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR07MB3449;H:BY1PR0701MB1910.namprd07.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <7117F73BA2C59B4E8C2B23F874A69368@namprd07.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2017 17:12:19.6407 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3449 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v4OHCSAu012058 On 5/24/17, 8:47 AM, "Bart Van Assche" wrote: >On Tue, 2017-05-23 at 16:50 +0200, Johannes Thumshirn wrote: >> When pci_enable_device() or pci_enable_device_mem() fail in >> qla2x00_probe_one() we bail out but do a call to >> pci_disable_device(). This causes the dev_WARN_ON() in >> pci_disable_device() to trigger, as the device wasn't enabled >> previously. >> >> So instead of taking the 'probe_out' error path we can directly return >> *iff* one of the pci_enable_device() calls fails. >> >> Additionally rename the 'probe_out' goto label's name to the more >> descriptive 'disable_device'. >> >> Signed-off-by: Johannes Thumshirn >> Fixes: e315cd28b9ef ("[SCSI] qla2xxx: Code changes for qla data >>structure refactoring") > >Hello Johannes, > >Please consider adding a Cc: stable tag to this patch. Since otherwise >this >patch looks fine to me: > >Reviewed-by: Bart Van Assche Looks good to me. Reviewed-by: Giridhar Malavali