From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754264AbdFWWEb (ORCPT ); Fri, 23 Jun 2017 18:04:31 -0400 Received: from mail-bn3nam01on0069.outbound.protection.outlook.com ([104.47.33.69]:60480 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754407AbdFWWE3 (ORCPT ); Fri, 23 Jun 2017 18:04:29 -0400 From: "Malavali, Giridhar" To: Julia Lawall , Johannes Thumshirn CC: "Martin K . Petersen" , Linux SCSI Mailinglist , Linux Kernel Mailinglist , Dept-Eng QLA2xxx Upstream , "Madhani, Himanshu" , Johannes Thumshirn , Linux SCSI Mailinglist , Linux Kernel Mailinglist , Dept-Eng QLA2xxx Upstream , "Madhani, Himanshu" , Johannes Thumshirn Subject: Re: [PATCH] qla2xxx: Protect access to qpair members with qpair->qp_lock Thread-Topic: [PATCH] qla2xxx: Protect access to qpair members with qpair->qp_lock Thread-Index: AQHS7GytbCyTbGyILU65WCP4oEg9cg== Date: Fri, 23 Jun 2017 22:04:26 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: lip6.fr; dkim=none (message not signed) header.d=none;lip6.fr; dmarc=none action=none header.from=cavium.com; x-originating-ip: [173.186.134.106] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY4PR07MB3445;7:OQTbTIK4zdtQg2Na+a6ilIpqxMUDS/Qlu/x9bQqSY+Zp1p4xgkQfQjIHFLp4XekXZtngvKdb9Hkn5xvV/dgSZH/DjKx1pV0frbeWi8agwsJNgQCa6Fncg/EkyNu/03y8hxmPkrtSZWtowbtV6+hKXy6zITy2Wwk5Wn860wRg925Qupfsf7WvSIGKmdSKdil7ry1lb6wJqEh09z/obycQqCb2q/P2tOMtWb1EcJXnCS2duawU8/Wlrc8XlD9mOuCywRHODMvYGMrw2ex+XjMX16PuARFsQQFtCKL7sTgS7k5jtFwI57B/+SEaOeVx9GJIIIneXc5fQBOp4duligbafl+U9EKKQAvbE0J4Ne/sqMJoV8nlOXG0Z7hdku5LsuK4B3MCGg3HtVV/wQIK45Bzi3slbpk8t8/4loCbMSYDVY6sTiEXnHXE0YV78RNHd4zDO7eW7s6kPXOws7b9mqQMRKPTgLSpGxfSvtZ514FbDgZGAmMsXEgQnLXztcOgVsxhVgudB6aTRIE75lAFf7zobk8I1toQidaN0WlpDgv4TOdyAPzg9gkNeijkY7d3Zd9tl+dxKL5NP5Vdll7+HMU/PBZShdnasUbwBeF45ybg4H7Pk52XAHTXoQEQWxODrx/e7waw/clucG2ImKFN/iL9dWGA4Z6C0Z06LhqYm5p6BtN1KmmAuFpIDA2YxpAmghk3228wPuqsHx4xtkjihkdAOV/evVi5lmmRym4x1MNX2zpWblyhD6bzLtqJ+pGsQaMjZIHZaYB0ntQVyw0PyY4e/2yqEweerqHI+y7uA0FX1+Y= x-ms-office365-filtering-correlation-id: 92f6d57d-158c-4dff-c9d8-08d4ba83d0ba x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500073)(300135000095)(300000501073)(300135300095)(22001)(300000502073)(300135100095)(2017030254075)(300000503073)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504073)(300135200095)(300000505073)(300135600095);SRVR:CY4PR07MB3445; x-ms-traffictypediagnostic: CY4PR07MB3445: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(166708455590820)(162533806227266)(84791874153150)(146099531331640)(228905959029699)(236129657087228)(48057245064654)(167848164394848); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(10201501046)(100000703101)(100105400095)(6041248)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123560025)(20161123558100)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY4PR07MB3445;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY4PR07MB3445; x-forefront-prvs: 0347410860 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39840400002)(39450400003)(39400400002)(39850400002)(39410400002)(377424004)(377454003)(24454002)(99286003)(6506006)(66066001)(2906002)(6436002)(50986999)(102836003)(6116002)(3846002)(6512007)(54356999)(86362001)(2900100001)(189998001)(6246003)(6306002)(53936002)(305945005)(38730400002)(53546010)(3660700001)(3280700002)(54906002)(72206003)(966005)(4001150100001)(122556002)(478600001)(14454004)(25786009)(8676002)(36756003)(8936002)(6486002)(4326008)(5660300001)(81166006)(77096006)(229853002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR07MB3445;H:BY1PR0701MB1910.namprd07.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-ID: <06E33A1C53A2F54B939D7C14C54087C0@namprd07.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jun 2017 22:04:27.0060 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3445 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v5NM4mco017986 Yes, itıs needed. We will post a patch. On 6/23/17, 9:34 AM, "Julia Lawall" wrote: >Please check on whether an unlock is neeed before line 1965. > >julia > >---------- Forwarded message ---------- >Date: Fri, 23 Jun 2017 15:23:00 +0800 >From: kbuild test robot >To: kbuild@01.org >Cc: Julia Lawall >Subject: Re: [PATCH] qla2xxx: Protect access to qpair members with > qpair->qp_lock > >CC: kbuild-all@01.org >In-Reply-To: <20170622134325.26931-1-jthumshirn@suse.de> > >Hi Johannes, > >[auto build test WARNING on scsi/for-next] >[also build test WARNING on v4.12-rc6 next-20170622] >[if your patch is applied to the wrong git tree, please drop us a note to >help improve the system] > >url: >https://github.com/0day-ci/linux/commits/Johannes-Thumshirn/qla2xxx-Protec >t-access-to-qpair-members-with-qpair-qp_lock/20170623-123844 >base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git >for-next >:::::: branch date: 3 hours ago >:::::: commit date: 3 hours ago > >>> drivers/scsi/qla2xxx/qla_iocb.c:1965:3-9: preceding lock on line 1952 > >git remote add linux-review https://github.com/0day-ci/linux >git remote update linux-review >git checkout 4a35d720268dbe9ac016957a3c4fc644398d68ba >vim +1965 drivers/scsi/qla2xxx/qla_iocb.c > >d74595278 Michael Hernandez 2016-12-12 1946 /* Only process >protection or >16 cdb in this routine */ >d74595278 Michael Hernandez 2016-12-12 1947 if (scsi_get_prot_op(cmd) >== SCSI_PROT_NORMAL) { >d74595278 Michael Hernandez 2016-12-12 1948 if (cmd->cmd_len <= 16) >d74595278 Michael Hernandez 2016-12-12 1949 return >qla2xxx_start_scsi_mq(sp); >d74595278 Michael Hernandez 2016-12-12 1950 } >d74595278 Michael Hernandez 2016-12-12 1951 >4a35d7202 Johannes Thumshirn 2017-06-22 @1952 > spin_lock_irqsave(&qpair->qp_lock, flags); >4a35d7202 Johannes Thumshirn 2017-06-22 1953 >d74595278 Michael Hernandez 2016-12-12 1954 /* Setup qpair pointers */ >d74595278 Michael Hernandez 2016-12-12 1955 rsp = qpair->rsp; >d74595278 Michael Hernandez 2016-12-12 1956 req = qpair->req; >d74595278 Michael Hernandez 2016-12-12 1957 >d74595278 Michael Hernandez 2016-12-12 1958 /* So we know we haven't >pci_map'ed anything yet */ >d74595278 Michael Hernandez 2016-12-12 1959 tot_dsds = 0; >d74595278 Michael Hernandez 2016-12-12 1960 >d74595278 Michael Hernandez 2016-12-12 1961 /* Send marker if >required */ >d74595278 Michael Hernandez 2016-12-12 1962 if (vha->marker_needed != >0) { >d74595278 Michael Hernandez 2016-12-12 1963 if (qla2x00_marker(vha, >req, rsp, 0, 0, MK_SYNC_ALL) != >d74595278 Michael Hernandez 2016-12-12 1964 QLA_SUCCESS) >d74595278 Michael Hernandez 2016-12-12 @1965 return >QLA_FUNCTION_FAILED; >d74595278 Michael Hernandez 2016-12-12 1966 vha->marker_needed = 0; >d74595278 Michael Hernandez 2016-12-12 1967 } >d74595278 Michael Hernandez 2016-12-12 1968 > >:::::: The code at line 1965 was first introduced by commit >:::::: d74595278f4ab192af66d9e60a9087464638beee scsi: qla2xxx: Add >multiple queue pair functionality. > >:::::: TO: Michael Hernandez >:::::: CC: Martin K. Petersen > >--- >0-DAY kernel test infrastructure Open Source Technology >Center >https://lists.01.org/pipermail/kbuild-all Intel >Corporation