From: "Rangankar, Manish" <Manish.Rangankar@cavium.com>
To: Christos Gkekas <chris.gekas@gmail.com>,
Dept-Eng QLogic Storage Upstream
<QLogic-Storage-Upstream@cavium.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] bnx2i: Clean up unused pointers in bnx2i_hwi
Date: Mon, 11 Sep 2017 05:48:24 +0000 [thread overview]
Message-ID: <D5DC2129.3D3F8%manish.rangankar@cavium.com> (raw)
In-Reply-To: <1505045934-16272-1-git-send-email-chris.gekas@gmail.com>
On 10/09/17 5:48 PM, "Christos Gkekas" <chris.gekas@gmail.com> wrote:
>Pointers bnx2i_cmd are set but never used, so they can be removed.
>
>Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
>---
> drivers/scsi/bnx2i/bnx2i_hwi.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
>diff --git a/drivers/scsi/bnx2i/bnx2i_hwi.c
>b/drivers/scsi/bnx2i/bnx2i_hwi.c
>index 42921db..e3f22cb 100644
>--- a/drivers/scsi/bnx2i/bnx2i_hwi.c
>+++ b/drivers/scsi/bnx2i/bnx2i_hwi.c
>@@ -332,12 +332,10 @@ static void
>bnx2i_ring_dbell_update_sq_params(struct bnx2i_conn *bnx2i_conn,
> int bnx2i_send_iscsi_login(struct bnx2i_conn *bnx2i_conn,
> struct iscsi_task *task)
> {
>- struct bnx2i_cmd *bnx2i_cmd;
> struct bnx2i_login_request *login_wqe;
> struct iscsi_login_req *login_hdr;
> u32 dword;
>
>- bnx2i_cmd = (struct bnx2i_cmd *)task->dd_data;
> login_hdr = (struct iscsi_login_req *)task->hdr;
> login_wqe = (struct bnx2i_login_request *)
> bnx2i_conn->ep->qp.sq_prod_qe;
>@@ -391,12 +389,10 @@ int bnx2i_send_iscsi_tmf(struct bnx2i_conn
>*bnx2i_conn,
> struct iscsi_tm *tmfabort_hdr;
> struct scsi_cmnd *ref_sc;
> struct iscsi_task *ctask;
>- struct bnx2i_cmd *bnx2i_cmd;
> struct bnx2i_tmf_request *tmfabort_wqe;
> u32 dword;
> u32 scsi_lun[2];
>
>- bnx2i_cmd = (struct bnx2i_cmd *)mtask->dd_data;
> tmfabort_hdr = (struct iscsi_tm *)mtask->hdr;
> tmfabort_wqe = (struct bnx2i_tmf_request *)
> bnx2i_conn->ep->qp.sq_prod_qe;
>@@ -463,12 +459,10 @@ int bnx2i_send_iscsi_tmf(struct bnx2i_conn
>*bnx2i_conn,
> int bnx2i_send_iscsi_text(struct bnx2i_conn *bnx2i_conn,
> struct iscsi_task *mtask)
> {
>- struct bnx2i_cmd *bnx2i_cmd;
> struct bnx2i_text_request *text_wqe;
> struct iscsi_text *text_hdr;
> u32 dword;
>
>- bnx2i_cmd = (struct bnx2i_cmd *)mtask->dd_data;
> text_hdr = (struct iscsi_text *)mtask->hdr;
> text_wqe = (struct bnx2i_text_request *) bnx2i_conn->ep->qp.sq_prod_qe;
>
>@@ -541,11 +535,9 @@ int bnx2i_send_iscsi_nopout(struct bnx2i_conn
>*bnx2i_conn,
> char *datap, int data_len, int unsol)
> {
> struct bnx2i_endpoint *ep = bnx2i_conn->ep;
>- struct bnx2i_cmd *bnx2i_cmd;
> struct bnx2i_nop_out_request *nopout_wqe;
> struct iscsi_nopout *nopout_hdr;
>
>- bnx2i_cmd = (struct bnx2i_cmd *)task->dd_data;
> nopout_hdr = (struct iscsi_nopout *)task->hdr;
> nopout_wqe = (struct bnx2i_nop_out_request *)ep->qp.sq_prod_qe;
>
>@@ -602,11 +594,9 @@ int bnx2i_send_iscsi_nopout(struct bnx2i_conn
>*bnx2i_conn,
> int bnx2i_send_iscsi_logout(struct bnx2i_conn *bnx2i_conn,
> struct iscsi_task *task)
> {
>- struct bnx2i_cmd *bnx2i_cmd;
> struct bnx2i_logout_request *logout_wqe;
> struct iscsi_logout *logout_hdr;
>
>- bnx2i_cmd = (struct bnx2i_cmd *)task->dd_data;
> logout_hdr = (struct iscsi_logout *)task->hdr;
>
> logout_wqe = (struct bnx2i_logout_request *)
>--
>2.7.4
Thanks,
Acked-by: Manish Rangankar <Manish.Rangankar@cavium.com>
next prev parent reply other threads:[~2017-09-11 5:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-10 12:18 Christos Gkekas
2017-09-11 5:48 ` Rangankar, Manish [this message]
2017-09-15 19:41 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D5DC2129.3D3F8%manish.rangankar@cavium.com \
--to=manish.rangankar@cavium.com \
--cc=QLogic-Storage-Upstream@cavium.com \
--cc=chris.gekas@gmail.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome