From: "Diederik de Haas" <didi.debian@cknow.org>
To: "Sudeep Holla" <sudeep.holla@arm.com>
Cc: <linux-kernel@vger.kernel.org>,
<linux-rockchip@lists.infradead.org>,
"Shawn Lin" <shawn.lin@rock-chips.com>
Subject: Re: Q: Kconfig: 'If unsure, say N'
Date: Wed, 13 Nov 2024 14:47:12 +0100 [thread overview]
Message-ID: <D5L3IQFBCNBQ.1Z5OB2COPA7C5@cknow.org> (raw)
In-Reply-To: <20241112054623.7zxte2nny7h4st3h@bogus>
[-- Attachment #1: Type: text/plain, Size: 2278 bytes --]
Thanks for your response.
On Tue Nov 12, 2024 at 6:46 AM CET, Sudeep Holla wrote:
> On Fri, Nov 08, 2024 at 03:39:30PM +0100, Diederik de Haas wrote:
> > In quite a number of Kconfig help text entries I see this:
> > "If unsure, say N."
> >
> > But that raises the question: How can I be sure?
>
> If you don't know about the feature and it is not having any user-interface
> why do you want to enable it. You must understand the feature to enable it
> and use it IMO.
Ok, understood.
> You seem to contradict yourself here. If you have understood the help
> text and think it is useful, it seems to me as an indication that you
> are not unsure really. So you can enable it if you want TBH.
>
> > Not to discuss these specifically, but just for illustration:
> > ``drivers/firmware/arm_scmi/transports/Kconfig`` has this
> > option: ``ARM_SCMI_TRANSPORT_SMC_ATOMIC_ENABLE``
> > which IIUC enables an *optional* feature for an atomic transaction.
> >
>
> "If you want the SCMI SMC based transport to operate in atomic
> mode, avoiding any kind of sleeping behaviour for selected
> transactions on the TX path, answer Y.
>
> Enabling atomic mode operations allows any SCMI driver using this
> transport to optionally ask for atomic SCMI transactions and operate
> in atomic context too, at the price of using a number of busy-waiting
> primitives all over instead."
>
> So you read the above text, understood and find it useful. You must be
> not unsure of this feature then, so what does that text bother you.
In this case I was wondering whether this was related to Table 1 in
"Power and Performance Management using Arm SCMI Specification"
whitepaper.
And I do think that I understand most of the Help text, but I'm not/less
sure about the part starting with "at the price of ...".
> It is just a caution to users who are just build and not looked at the
> code, or have no idea about the feature or doesn't understand the help
> text.
And my question was exactly about "just a caution", which raises the
question with me "caution for what?" ... which is an unspecified risk.
So to be on the safe side, I will not enable modules with "If unsure,
say N" unless I fully understand the source code.
Cheers,
Diederik
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2024-11-13 13:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 14:39 Diederik de Haas
2024-11-08 15:05 ` Harald Arnesen
2024-11-13 13:50 ` Diederik de Haas
2024-11-12 5:46 ` Sudeep Holla
2024-11-13 13:47 ` Diederik de Haas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D5L3IQFBCNBQ.1Z5OB2COPA7C5@cknow.org \
--to=didi.debian@cknow.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=shawn.lin@rock-chips.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®