From: "Luca Weiss" <luca.weiss@fairphone.com>
To: "Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Ekansh Gupta" <quic_ekangupt@quicinc.com>
Cc: <andersson@kernel.org>, <konradybcio@kernel.org>,
<robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<cros-qcom-dts-watchers@chromium.org>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <srinivas.kandagatla@linaro.org>,
<quic_bkumar@quicinc.com>, <quic_chennak@quicinc.com>
Subject: Re: [PATCH v1] arm64: dts: qcom: sc7280: Make ADSP a secure fastrpc domain
Date: Fri, 15 Nov 2024 16:06:18 +0100 [thread overview]
Message-ID: <D5MUGDO3V9ZE.2EQQUXKCQV3QB@fairphone.com> (raw)
In-Reply-To: <7grzazq7tfv3kixnevia2fkebe6o352372g3gpdinqeihmuavl@6qxd6vvwcwgt>
Hi Dmitry,
On Fri Nov 15, 2024 at 3:45 PM CET, Dmitry Baryshkov wrote:
> On Fri, Nov 15, 2024 at 05:40:23PM +0530, Ekansh Gupta wrote:
> >
> >
> > On 11/14/2024 5:30 PM, Dmitry Baryshkov wrote:
> > > On Thu, Nov 14, 2024 at 10:49:52AM +0530, Ekansh Gupta wrote:
> > >>
> > >> On 11/13/2024 5:20 PM, Dmitry Baryshkov wrote:
> > >>> On Wed, 13 Nov 2024 at 08:18, Ekansh Gupta <quic_ekangupt@quicinc.com> wrote:
> > >>>>
> > >>>> On 11/13/2024 11:13 AM, Dmitry Baryshkov wrote:
> > >>>>> On Wed, Nov 13, 2024 at 10:30:42AM +0530, Ekansh Gupta wrote:
>
> [...]
>
> > >>>>>>
> > >>>>>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > >>>>>> index 3d8410683402..c633926c0f33 100644
> > >>>>>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > >>>>>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > >>>>>> @@ -3852,7 +3852,6 @@ fastrpc {
> > >>>>>> compatible = "qcom,fastrpc";
> > >>>>>> qcom,glink-channels = "fastrpcglink-apps-dsp";
> > >>>>>> label = "adsp";
> > >>>>>> - qcom,non-secure-domain;
> > > - Are there other platforms which have this flag set for ADSP?
> > Yes, there are a few platforms where this property is added for ADSP.
>
> Please clean up all of them to reduce a possible chance of different behaviour or further c&p errors.
>
> > > - Granted that sc7280 was targeting ChromeOS devices, might it be that
> > > there is a CrOS-specific userspace for that?
> > FastRPC nodes were recently added to this devicetree recently. Looks like this property is just getting copied.
> > It might be that fastrpc was recently tried on ChromeOS device or it might be added to support some other devices
> > that uses fastrpc(qcm6490-idp etc.).
>
> Indeed.
>
> Luca, could you possibly comment, as you've added ADSP / FastRPC nodes?
I've just followed other platforms, I have little clue about FastRPC
myself apart from it being used for hexagonrpcd for interfacing with
sensors. There's not much (any?) docs out there.
Regards
Luca
prev parent reply other threads:[~2024-11-15 15:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 5:00 Ekansh Gupta
2024-11-13 5:43 ` Dmitry Baryshkov
2024-11-13 6:17 ` Ekansh Gupta
2024-11-13 11:50 ` Dmitry Baryshkov
2024-11-14 5:19 ` Ekansh Gupta
2024-11-14 12:00 ` Dmitry Baryshkov
2024-11-15 12:10 ` Ekansh Gupta
2024-11-15 14:45 ` Dmitry Baryshkov
2024-11-15 15:06 ` Luca Weiss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D5MUGDO3V9ZE.2EQQUXKCQV3QB@fairphone.com \
--to=luca.weiss@fairphone.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_bkumar@quicinc.com \
--cc=quic_chennak@quicinc.com \
--cc=quic_ekangupt@quicinc.com \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®