mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Daniel Gomez" <d+samsung@kruces.com>
To: "Werner Sembach" <wse@tuxedocomputers.com>,
	<u.kleine-koenig@baylibre.com>, <mcgrof@kernel.org>,
	<petr.pavlu@suse.com>, <samitolvanen@google.com>,
	<da.gomez@samsung.com>, <linux-modules@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux@leemhuis.info>,
	<vv@tuxedocomputers.com>, <cs@tuxedo.de>
Cc: "Uwe Kleine-König" <ukleinek@kernel.org>
Subject: Re: [PATCH v5 2/2] module: Block a module by TUXEDO from accessing GPL symbols
Date: Sat, 16 Nov 2024 09:15:55 +0100	[thread overview]
Message-ID: <D5NGCPSP7EO8.28YI337NY203X@kruces.com> (raw)
In-Reply-To: <20241115185253.1299264-3-wse@tuxedocomputers.com>

On Fri Nov 15, 2024 at 7:50 PM CET, Werner Sembach wrote:
> From: Uwe Kleine-König <ukleinek@kernel.org>
>
> TUXEDO has not yet relicensed a module for GPLv2+ as a reply from former
> contributers the committed code under GPLv3+ is awaited.

FYI, the SPDX identifier GPL-2.0+ is deprecated as of 2.0rc2 [1]. I think you'd
need to use GPL-2.0-or-later [2] instead. And when using the SPDX identifier,
you don't need to include the full text boilerplate in the source of every file
as long as you include a LICENSE file or COPYRIGHT file with a copy of the
license. One example upstream here [3] commit 1a59d1b8e05ea ("treewide: Replace
GPLv2 boilerplate/reference with SPDX - rule 156").

[1] https://spdx.org/licenses/GPL-2.0+.html
[2] https://spdx.org/licenses/GPL-2.0-or-later.html
[3] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v6.12-rc7&id=1a59d1b8e05ea


Daniel
>
> Teach the module loader that this module is not GPLv2 compatible despite
> the declaration to be GPLv2 compatible until the relicensing is complete.
>
> Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org>
> [Remove relicensed modules and accusatory language]
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> ---
>  kernel/module/main.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/kernel/module/main.c b/kernel/module/main.c
> index 905d7b60dd709..df2549352ca8a 100644
> --- a/kernel/module/main.c
> +++ b/kernel/module/main.c
> @@ -2029,6 +2029,14 @@ static const char *module_license_offenders[] = {
>  
>  	/* lve claims to be GPL but upstream won't provide source */
>  	"lve",
> +
> +	/*
> +	 * TUXEDO awaits 2 final answers to relicense the last module to GPLv2+
> +	 * See https://gitlab.com/tuxedocomputers/development/packages/tuxedo-drivers/-/merge_requests/21 ,
> +	 * https://gitlab.com/tuxedocomputers/development/packages/tuxedo-drivers/-/commit/dd34594ab880ed477bb75725176c3fb9352a07eb ,
> +	 * and https://gitlab.com/tuxedocomputers/development/packages/tuxedo-drivers/-/commit/c8893684c2f869b2a6b13f1ef1ddeb4922f2ffe3
> +	 */
> +	"clevo_acpi",
>  };
>  
>  /*


  reply	other threads:[~2024-11-16  8:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-15 18:50 Werner Sembach
2024-11-15 18:50 ` [PATCH v5 1/2] module: Put known GPL offenders in an array Werner Sembach
2024-11-15 18:50 ` [PATCH v5 2/2] module: Block a module by TUXEDO from accessing GPL symbols Werner Sembach
2024-11-16  8:15   ` Daniel Gomez [this message]
2024-11-16 17:20     ` Uwe Kleine-König
2024-11-18  9:05       ` Daniel Gomez
2024-11-18 14:03         ` Greg Kroah-Hartman
2024-11-18 10:10   ` Werner Sembach
2024-11-18 20:53     ` Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D5NGCPSP7EO8.28YI337NY203X@kruces.com \
    --to=d+samsung@kruces.com \
    --cc=cs@tuxedo.de \
    --cc=da.gomez@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=linux@leemhuis.info \
    --cc=mcgrof@kernel.org \
    --cc=petr.pavlu@suse.com \
    --cc=samitolvanen@google.com \
    --cc=u.kleine-koenig@baylibre.com \
    --cc=ukleinek@kernel.org \
    --cc=vv@tuxedocomputers.com \
    --cc=wse@tuxedocomputers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®