From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751895AbdJPFh4 (ORCPT ); Mon, 16 Oct 2017 01:37:56 -0400 Received: from mail-bn3nam01on0062.outbound.protection.outlook.com ([104.47.33.62]:23104 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750731AbdJPFhx (ORCPT ); Mon, 16 Oct 2017 01:37:53 -0400 From: "Rangankar, Manish" To: Christos Gkekas , Dept-Eng QLogic Storage Upstream , "James E.J. Bottomley" , "Martin K. Petersen" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] scsi: qedi: Delete redundant variables Thread-Topic: [PATCH] scsi: qedi: Delete redundant variables Thread-Index: AQHTROZ9mi4Fu26v8kKPhSmN1r15faLmVDMA Date: Mon, 16 Oct 2017 05:37:51 +0000 Message-ID: References: <1507983478-23083-1-git-send-email-chris.gekas@gmail.com> In-Reply-To: <1507983478-23083-1-git-send-email-chris.gekas@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Manish.Rangankar@cavium.com; x-originating-ip: [114.143.185.87] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BN3PR07MB2484;6:+gt5rNSXYjUM8XsopO/PQ28teWj19CozeLLgu8C63XDufaI2UnvL7Sjk8TtbeUfo+ATIDee0caQfcVDU7RzooZoCCzjbVUPmeDExap2h0HLipyDPzeUJLhk/t+qfHEoOzUOy12zHLY5WSjoNJ0KyUornrUFPWu0u2jCRR64xDE2VfqdAyWPQelK/GenmaQ+0aLOwV/WWDtOcoCm8xfsyGhs96ZIng19ZjNFHYROkJBwi1MHJTuQxSbmJQhtPksFKXagSvisLRiIXaaCVeyQPQgN7tyRA9GsLzhIFpYP6+8T0t+sfOj3qZk2ZHs/ChVN+aqjCtndqC4Tf0uQb+Ba/cg==;5:PyEY45s42RyiBdIUfw3/gt3lBSWX/34E7DO60ZlGu/znWW86+pj9c/kjAxT4Uh3xUISKh6cAbJ3cUPHeB0/9iSxeCXDwG4cJDSl8rkD1n6Gd3/m78N7im36f48hnC2rQCDFLZL939WYUUFyyiIe9vg==;24:gmt5C4VkWjsTMqmv+hTz+Q3aYX0IBhP8hYr6eDMzjvFt0krZxfHhelO/qlDLKRi5Au7WI0Y64WifXI4WrtXW2EXxQbmjOnRJD+Yi0VX+dJE=;7:bL8uZAidHGcncsAx84JpuRjDP+kttz2ZHmT1k0ofYiNhL+4KegOwx6r9sEYYxHQjAwpeLmpDubM1/sDTdyRIQ03wCyTe0UbLBmhVdGTuRvdxTPEPI+1TxQ1INUwYX8Mxnu4y4BPZg+bYXRKYLCp8MxfLCCDXhT1cNMCtz+VYen5pgcVAY2E3Fd5aHUBvmWYVQOd4xTwD3HIoBUWgkuZJaRPWHnvOt1ySKooakzMLQoQ= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 67d2d896-701b-4ac5-8ddf-08d514580b65 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:BN3PR07MB2484; x-ms-traffictypediagnostic: BN3PR07MB2484: x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(6041248)(20161123564025)(20161123560025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BN3PR07MB2484;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BN3PR07MB2484; x-forefront-prvs: 0462918D61 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(376002)(346002)(189002)(51914003)(377454003)(199003)(24454002)(2950100002)(36756003)(39060400002)(478600001)(81166006)(76176999)(6486002)(106356001)(72206003)(53546010)(110136005)(14454004)(77096006)(81156014)(8676002)(2501003)(6436002)(7736002)(6116002)(229853002)(2900100001)(50986999)(3846002)(102836003)(105586002)(189998001)(6506006)(54356999)(101416001)(5660300001)(2201001)(99286003)(66066001)(86362001)(305945005)(6512007)(25786009)(2906002)(68736007)(3280700002)(53936002)(8936002)(6246003)(316002)(97736004)(3660700001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR07MB2484;H:BN3PR07MB2483.namprd07.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Oct 2017 05:37:52.0394 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR07MB2484 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v9G5c3pm016911 On 14/10/17 5:47 PM, "Christos Gkekas" wrote: >Remove redundant variables in quedi_fw.c that are set but not used. > >Signed-off-by: Christos Gkekas >--- > drivers/scsi/qedi/qedi_fw.c | 17 +---------------- > 1 file changed, 1 insertion(+), 16 deletions(-) > >diff --git a/drivers/scsi/qedi/qedi_fw.c b/drivers/scsi/qedi/qedi_fw.c >index 93d54ac..bd302d3 100644 >--- a/drivers/scsi/qedi/qedi_fw.c >+++ b/drivers/scsi/qedi/qedi_fw.c >@@ -92,7 +92,6 @@ static void qedi_process_text_resp(struct qedi_ctx >*qedi, > struct iscsi_text_response_hdr *cqe_text_response; > struct qedi_cmd *cmd; > int pld_len; >- u32 *tmp; > > cmd = (struct qedi_cmd *)task->dd_data; > task_ctx = qedi_get_task_mem(&qedi->tasks, cmd->task_id); >@@ -108,7 +107,6 @@ static void qedi_process_text_resp(struct qedi_ctx >*qedi, > hton24(resp_hdr_ptr->dlength, > (cqe_text_response->hdr_second_dword & > ISCSI_TEXT_RESPONSE_HDR_DATA_SEG_LEN_MASK)); >- tmp = (u32 *)resp_hdr_ptr->dlength; > > resp_hdr_ptr->itt = build_itt(cqe->cqe_solicited.itid, > conn->session->age); >@@ -196,7 +194,6 @@ static void qedi_process_tmf_resp(struct qedi_ctx >*qedi, > struct iscsi_tm_rsp *resp_hdr_ptr; > struct iscsi_tm *tmf_hdr; > struct qedi_cmd *qedi_cmd = NULL; >- u32 *tmp; > > cqe_tmp_response = &cqe->cqe_common.iscsi_hdr.tmf_response; > >@@ -222,7 +219,6 @@ static void qedi_process_tmf_resp(struct qedi_ctx >*qedi, > hton24(resp_hdr_ptr->dlength, > (cqe_tmp_response->hdr_second_dword & > ISCSI_TMF_RESPONSE_HDR_DATA_SEG_LEN_MASK)); >- tmp = (u32 *)resp_hdr_ptr->dlength; > resp_hdr_ptr->itt = build_itt(cqe->cqe_solicited.itid, > conn->session->age); > resp_hdr_ptr->statsn = cpu_to_be32(cqe_tmp_response->stat_sn); >@@ -269,7 +265,6 @@ static void qedi_process_login_resp(struct qedi_ctx >*qedi, > struct iscsi_login_response_hdr *cqe_login_response; > struct qedi_cmd *cmd; > int pld_len; >- u32 *tmp; > > cmd = (struct qedi_cmd *)task->dd_data; > >@@ -286,7 +281,6 @@ static void qedi_process_login_resp(struct qedi_ctx >*qedi, > hton24(resp_hdr_ptr->dlength, > (cqe_login_response->hdr_second_dword & > ISCSI_LOGIN_RESPONSE_HDR_DATA_SEG_LEN_MASK)); >- tmp = (u32 *)resp_hdr_ptr->dlength; > resp_hdr_ptr->itt = build_itt(cqe->cqe_solicited.itid, > conn->session->age); > resp_hdr_ptr->tsih = cqe_login_response->tsih; >@@ -590,7 +584,6 @@ static void qedi_scsi_completion(struct qedi_ctx >*qedi, > int datalen = 0; > struct qedi_conn *qedi_conn; > u32 iscsi_cid; >- bool mark_cmd_node_deleted = false; > u8 cqe_err_bits = 0; > > iscsi_cid = cqe->cqe_common.conn_id; >@@ -674,7 +667,6 @@ static void qedi_scsi_completion(struct qedi_ctx >*qedi, > cmd->io_cmd_in_list = false; > list_del_init(&cmd->io_cmd); > qedi_conn->active_cmd_count--; >- mark_cmd_node_deleted = true; > } > spin_unlock(&qedi_conn->list_lock); > >@@ -763,7 +755,7 @@ static void qedi_process_cmd_cleanup_resp(struct >qedi_ctx *qedi, > u32 rtid = 0; > u32 iscsi_cid; > struct qedi_conn *qedi_conn; >- struct qedi_cmd *cmd_new, *dbg_cmd; >+ struct qedi_cmd *dbg_cmd; > struct iscsi_task *mtask; > struct iscsi_tm *tmf_hdr = NULL; > >@@ -856,7 +848,6 @@ static void qedi_process_cmd_cleanup_resp(struct >qedi_ctx *qedi, > } > qedi_conn->cmd_cleanup_cmpl++; > wake_up(&qedi_conn->wait_queue); >- cmd_new = task->dd_data; > > QEDI_INFO(&qedi->dbg_ctx, QEDI_LOG_TID, > "Freeing tid=0x%x for cid=0x%x\n", >@@ -1029,7 +1020,6 @@ int qedi_send_iscsi_login(struct qedi_conn >*qedi_conn, > struct iscsi_task_context *fw_task_ctx; > struct qedi_ctx *qedi = qedi_conn->qedi; > struct iscsi_login_req *login_hdr; >- struct scsi_sge *req_sge = NULL; > struct scsi_sge *resp_sge = NULL; > struct qedi_cmd *qedi_cmd; > struct qedi_endpoint *ep; >@@ -1037,7 +1027,6 @@ int qedi_send_iscsi_login(struct qedi_conn >*qedi_conn, > u16 sq_idx = 0; > int rval = 0; > >- req_sge = (struct scsi_sge *)qedi_conn->gen_pdu.req_bd_tbl; > resp_sge = (struct scsi_sge *)qedi_conn->gen_pdu.resp_bd_tbl; > qedi_cmd = (struct qedi_cmd *)task->dd_data; > ep = qedi_conn->ep; >@@ -1718,7 +1707,6 @@ int qedi_send_iscsi_nopout(struct qedi_conn >*qedi_conn, > struct qedi_ctx *qedi = qedi_conn->qedi; > struct iscsi_task_context *fw_task_ctx; > struct iscsi_nopout *nopout_hdr; >- struct scsi_sge *req_sge = NULL; > struct scsi_sge *resp_sge = NULL; > struct qedi_cmd *qedi_cmd; > struct qedi_endpoint *ep; >@@ -1727,7 +1715,6 @@ int qedi_send_iscsi_nopout(struct qedi_conn >*qedi_conn, > u16 sq_idx = 0; > int rval = 0; > >- req_sge = (struct scsi_sge *)qedi_conn->gen_pdu.req_bd_tbl; > resp_sge = (struct scsi_sge *)qedi_conn->gen_pdu.resp_bd_tbl; > qedi_cmd = (struct qedi_cmd *)task->dd_data; > nopout_hdr = (struct iscsi_nopout *)task->hdr; >@@ -1995,7 +1982,6 @@ void qedi_trace_io(struct qedi_ctx *qedi, struct >iscsi_task *task, > struct qedi_conn *qedi_conn = conn->dd_data; > struct scsi_cmnd *sc_cmd = task->sc; > unsigned long flags; >- u8 op; > > spin_lock_irqsave(&qedi->io_trace_lock, flags); > >@@ -2005,7 +1991,6 @@ void qedi_trace_io(struct qedi_ctx *qedi, struct >iscsi_task *task, > io_log->cid = qedi_conn->iscsi_conn_id; > io_log->lun = sc_cmd->device->lun; > io_log->op = sc_cmd->cmnd[0]; >- op = sc_cmd->cmnd[0]; > io_log->lba[0] = sc_cmd->cmnd[2]; > io_log->lba[1] = sc_cmd->cmnd[3]; > io_log->lba[2] = sc_cmd->cmnd[4]; >-- >2.7.4 Thanks for the patch. Acked-by: Manish Rangankar