From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mo4-p01-ob.smtp.rzone.de (mo4-p01-ob.smtp.rzone.de [85.215.255.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17A0F285CBA; Wed, 29 Oct 2025 05:50:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=85.215.255.52 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761717053; cv=pass; b=VMTTnMNImxw0M8JefBh5y+fB6Wx+yDV4Lxqz7InWrpFUfSSU+d5tMxIWqT019V9wExJEaiZUpAs0eNv/7/zUY9Lh1w8zRaAb0W6PBf9a4FIjpx9hsqPRASjnfoMdoOMoNm0D8S5R2AmoKmNNBwzA1NeDJr3TY0cI10EZOrvHbQw= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761717053; c=relaxed/simple; bh=Fjz5eSHd+wyBWouOH0/DeH6JtX4WfBf/A6g/bAoJCz4=; h=Content-Type:From:Mime-Version:Subject:Date:Message-Id:References: Cc:In-Reply-To:To; b=LMHtetJ8JyLLdlqbOv1smJOlu0m8kpZXfPcwU752QhmzZjxPy6RdKEC4gFHf7ZJ9PTviwVJ0WHef9/QBsS9j+kJsNWKzHzZieGKZfMdE1g4MoCq5WHtXqnwUe6WvPbF1Nibf8Reyw0PnP/YMkgZyjXjSNG8iWEvcXPUKbTad298= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=xenosoft.de; spf=none smtp.mailfrom=xenosoft.de; dkim=pass (2048-bit key) header.d=xenosoft.de header.i=@xenosoft.de header.b=oiQiwl21; arc=pass smtp.client-ip=85.215.255.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=xenosoft.de Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=xenosoft.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=xenosoft.de header.i=@xenosoft.de header.b="oiQiwl21" ARC-Seal: i=1; a=rsa-sha256; t=1761716850; cv=none; d=strato.com; s=strato-dkim-0002; b=LmyknPLfvLXZ7H52EM5uhqfvm1eK6WkbCWoIB/CW8zbmNGbdoS7oanTle64VMH8thK zD9iTzsMHVpezGEiB3u/kSIK7UQ9u9yYp1w6TSXv6MTJXX3BqzolaPL9TZ+jzBUXkgNa Wew8o9I6RHEsx9vLihi99BS8ohKFD7I2pVP/DYKWtVIdaI88YhO8ti8umbj9+6CjWEn1 DY1KT/xi5/0ycLtehOFwq2q//sZzj54lojYkP1u2NGUyOJ0Ho0RhGYsDL0HYbpy2blwD Y4CiOAugsAJfsXrPHMqfdkS1o+y6yIjDmTE13cb9RTv2VA3TokKLRWKEpX+Gn4TEwXy0 y3Ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1761716850; s=strato-dkim-0002; d=strato.com; h=To:In-Reply-To:Cc:References:Message-Id:Date:Subject:From:Cc:Date: From:Subject:Sender; bh=nD/A1p+RHILMKnhWKlqaPG26jSHuFQvORVwKQeVq9QM=; b=Q3FsSnYMK9Q2DprNlObuSZwhgle36gcihx0tUQIh5L9BuU4VAQfyPES38nVadP1/hp Rj5x5aAZXZvsY85c6SlLBVp95eklDRx2JZMRYEKztB9/jo8zJnMOa/YxcFHQVzIeaMm3 DhTOv22yO/RzjMjHtDEdyUohJf2ydAWsfJlZkbxP1t5bB/zr3UtGUiG5ywarCFLo+pK/ n1AvYYD/OwFDJ8ayuWMA35NM0haOdlq4rR0LrAQ81/5dz16aSpRsATaLIgbOY5UIV7Xd WHrOf/uMAsxIekSMD4kTdPtoQBnrRk4qFlFbUrPg94tzc7xY2xvoM7UjcYVWPNV0ixJe nxVw== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo01 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1761716850; s=strato-dkim-0002; d=xenosoft.de; h=To:In-Reply-To:Cc:References:Message-Id:Date:Subject:From:Cc:Date: From:Subject:Sender; bh=nD/A1p+RHILMKnhWKlqaPG26jSHuFQvORVwKQeVq9QM=; b=oiQiwl21GIHVb9ekxrdiMAzqgTpILqkbDIVX0SvRTe00Qh/KKHawOFY3gGT0Nkd6il P+5raq2zPaeDkAq7oioSkol1Y6KRkIbShLMjKXX3nlwIGd/FZrYDmsw3Xg7nX0crG96T SE7/6VQyUndnvh5lYWe6fcpPmh+bXyBKObqV1tXXYXTtB4hyRdag4sl+YepUdItuBwSL WLPUExPRznsT0AMpXocW84NDnjuIloT2kDzuzP5BDKC3xMEA8TTYZyjtmbGMvgizq2Tl kcS+H1JBeavYmjHcEIug6JlNMnCa7eOn3bwk5FuSI7k191qkpcg0DAGV4jA72RPgdALQ LSrA== X-RZG-AUTH: ":L2QefEenb+UdBJSdRCXu93KJ1bmSGnhMdmOod1DhGN0rBVhd9dFr6P1rfO5KiO55fErqkryEafkCftK8YxNMWLn7nZHB4Eq/hCSkR9o2/A==" Received: from smtpclient.apple by smtp.strato.de (RZmta 53.4.2 AUTH) with ESMTPSA id e2886619T5lTHFv (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Wed, 29 Oct 2025 06:47:29 +0100 (CET) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Christian Zigotzky Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] PCI/ASPM: Enable only L0s and L1 for devicetree platforms Date: Wed, 29 Oct 2025 06:47:19 +0100 Message-Id: References: <20251028233333.GA1467459@bhelgaas> Cc: Johan Hovold , linux-pci@vger.kernel.org, Manivannan Sadhasivam , Naoki FUKAUMI , Herve Codina , Diederik de Haas , Dragan Simic , linuxppc-dev@lists.ozlabs.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Shawn Lin , Frank Li , "R.T.Dickinson" , mad skateman , hypexed@yahoo.com.au, Christian Zigotzky In-Reply-To: <20251028233333.GA1467459@bhelgaas> To: Bjorn Helgaas X-Mailer: iPhone Mail (23A355) > On 29 October 2025 at 00:33 am, Bjorn Helgaas wrote: >=20 > =EF=BB=BFOn Mon, Oct 27, 2025 at 06:12:24PM +0100, Christian Zigotzky wrot= e: >> Hi All, >>=20 >> I activated CONFIG_PCIEASPM and CONFIG_PCIEASPM_DEFAULT again for the RC3= of >> kernel 6.18. Unfortunately my AMD Radeon HD6870 doesn't work with the lat= est >> patches. >>=20 >> But that doesn't matter because we disable the above kernel options by >> default. We don't need power management for PCI Express because of boot >> issues and performance issues. >=20 > If you have a chance, could you try the patch below on top of > v6.18-rc3 with CONFIG_PCIEASPM=3Dy? >=20 > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > index 214ed060ca1b..2b6d4e0958aa 100644 > --- a/drivers/pci/quirks.c > +++ b/drivers/pci/quirks.c > @@ -2524,6 +2524,7 @@ static void quirk_disable_aspm_l0s_l1(struct pci_dev= *dev) > * disable both L0s and L1 for now to be safe. > */ > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ASMEDIA, 0x1080, quirk_disable_aspm_= l0s_l1); > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_FREESCALE, 0x0451, quirk_disable_as= pm_l0s_l1); >=20 > /* > * Some Pericom PCIe-to-PCI bridges in reverse mode need the PCIe Retrain Thanks for the patch.=20 I will test it on my FSL Cyrus+ board over the weekend. BTW, I also tested my PASemi Nemo board with the RC3 of kernel 6.18 and with= power management for PCI Express enabled. Unfortunately, the installed AMD R= adeon HD5870 does not work with power management for PCI Express enabled eit= her. Power management for PCI Express is not interesting for our machines because= it is somewhat slower and we do not want power management to impair perform= ance. But it is a good thing for 24/7 servers. - Christian=