From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752219AbdKMIdr (ORCPT ); Mon, 13 Nov 2017 03:33:47 -0500 Received: from mail-dm3nam03on0070.outbound.protection.outlook.com ([104.47.41.70]:29536 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751124AbdKMIdp (ORCPT ); Mon, 13 Nov 2017 03:33:45 -0500 From: "Rangankar, Manish" To: "Gustavo A. R. Silva" , Dept-Eng QLogic Storage Upstream , "James E.J. Bottomley" , "Martin K. Petersen" CC: "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] scsi: bnx2i: bnx2i_hwi: use swap macro in bnx2i_send_iscsi_nopout Thread-Topic: [PATCH] scsi: bnx2i: bnx2i_hwi: use swap macro in bnx2i_send_iscsi_nopout Thread-Index: AQHTVN4qHSUtSmK9MUqot5OMj7qGGaMSZq0A Date: Mon, 13 Nov 2017 08:33:42 +0000 Message-ID: References: <20171103195839.GA23385@embeddedor.com> In-Reply-To: <20171103195839.GA23385@embeddedor.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Manish.Rangankar@cavium.com; x-originating-ip: [114.143.185.87] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BN3PR07MB2481;6:nF+VhtNN4D6Qds08ssYmvFXJKRQbLXPWRrdOTNXPIgFVjT/4p9gYjy+/hrbYI4sFdTtHk916VeMq566Hqw4pfzx76kDTCGmQzbojVuzvvY9lRavjdeSHfQ84w8PdH5WSjjc0qZiFpHctu3iDOiPBSQpIFQO898vKExshcAQncELTrA1ySx4C/XDNwhD5aN7mcai526WoJ6JEWxlIoZ/haicpq7L3FtlrALBC/c3p0s6zgguA3sCUDLcrjFKo3orAqclOVGB9Pg97UXWnoqZSayoC60Hz+ybupQ1rM4GL5xRt0yICWBEIcQwPTpG1TXV11QpSQYnqLRWS0fvXimTkrLGXPrbuOoG0m7UZO0hiJJw=;5:iYjqsdHU4uMtTzvftfh94DGfKZb0LTJ4Z0sRAq5WdbvmCt95LJLx9PBnEiszj5WdEXlFcOglCGVFoB3CTqQSSIGnNN0vZianXDvX2ARNyWBoP1Dh9YCwYAD7kONAc30i2EVwhbjQNn6lKRBATRHCg1fIfuh7a+DLuQwxGrZfJjk=;24:BcEBpER9o7/PzaZCveVxA6QiKm5e92jqAZFQk4Mi/YFQBl1vUQDpiXgCIN2Lx08VhPUOhZjSyrZ+gMmctK/vS1+bc3FukO4AiLJ1dkBYcRU=;7:eQ46we/GmBt8+qSwyssK1ZNTijKJFxZouPQ3zp8w9iXSK53Eyi4xD7A2Lef9JVc9vwhRo3L7BiZmixmt8yeBe2xBv7jYljsMqRxL2FaAd3Tb3GpM+zzZwZe2MONQO2BGBWHRwJsV35YNVGnh+yQFbqZt/kuIaS0bSOxxkGaN3nfVIdo3Yox3tGssZFve0GgbLQ+eWwQbHAtPXonV4f0jfo15k2bQkYqnykLM4IXtljkuFdXePC/NprtSSoLM0LeB x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 8e0ee23f-2d5d-4d28-9590-08d52a713f9d x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603258);SRVR:BN3PR07MB2481; x-ms-traffictypediagnostic: BN3PR07MB2481: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3231022)(3002001)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123555025)(20161123560025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BN3PR07MB2481;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BN3PR07MB2481; x-forefront-prvs: 0490BBA1F0 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(346002)(376002)(199003)(24454002)(189002)(5660300001)(15760500003)(6506006)(6512007)(2950100002)(53936002)(6246003)(53546010)(4326008)(66066001)(3280700002)(72206003)(6486002)(77096006)(229853002)(86362001)(2906002)(7736002)(3660700001)(478600001)(99286004)(25786009)(97736004)(305945005)(6436002)(81166006)(81156014)(8936002)(8676002)(6116002)(54906003)(189998001)(50986999)(54356999)(76176999)(110136005)(36756003)(2900100001)(3846002)(102836003)(14454004)(316002)(105586002)(106356001)(68736007)(101416001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR07MB2481;H:BN3PR07MB2483.namprd07.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <706E1877EA3D0445902206FD5CB865D8@namprd07.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e0ee23f-2d5d-4d28-9590-08d52a713f9d X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2017 08:33:42.7725 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR07MB2481 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vAD8XrQM025872 On 04/11/17 1:28 AM, "Gustavo A. R. Silva" wrote: >Make use of the swap macro and remove unnecessary variable tmp. >This makes the code easier to read and maintain. > >This code was detected with the help of Coccinelle. > >Signed-off-by: Gustavo A. R. Silva >--- > drivers/scsi/bnx2i/bnx2i_hwi.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > >diff --git a/drivers/scsi/bnx2i/bnx2i_hwi.c >b/drivers/scsi/bnx2i/bnx2i_hwi.c >index e0640e0..9e3bf53 100644 >--- a/drivers/scsi/bnx2i/bnx2i_hwi.c >+++ b/drivers/scsi/bnx2i/bnx2i_hwi.c >@@ -547,12 +547,9 @@ int bnx2i_send_iscsi_nopout(struct bnx2i_conn >*bnx2i_conn, > nopout_wqe->op_attr = ISCSI_FLAG_CMD_FINAL; > memcpy(nopout_wqe->lun, &nopout_hdr->lun, 8); > >- if (test_bit(BNX2I_NX2_DEV_57710, &ep->hba->cnic_dev_type)) { >- u32 tmp = nopout_wqe->lun[0]; >- /* 57710 requires LUN field to be swapped */ >- nopout_wqe->lun[0] = nopout_wqe->lun[1]; >- nopout_wqe->lun[1] = tmp; >- } >+ /* 57710 requires LUN field to be swapped */ >+ if (test_bit(BNX2I_NX2_DEV_57710, &ep->hba->cnic_dev_type)) >+ swap(nopout_wqe->lun[0], nopout_wqe->lun[1]); > > nopout_wqe->itt = ((u16)task->itt | > (ISCSI_TASK_TYPE_MPATH << >-- >2.7.4 Thanks, Acked-by: Manish Rangankar >