From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7A683201 for ; Thu, 12 Dec 2024 00:46:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733964401; cv=none; b=dFc10nCVQpCzQNez8COwAuQXznLQEmptLGb7qSHfxHyRhL2gBHZO+chukYN3De4rhyzaBnvKA7osJBpdcULcTmCQqbpIatxrVre5OYIsJjjbCsB70fz8H9+48OmJuv4zz2yJgOgiERgGZEVUq178dc/t+lEINEr0YXkVCoiGFlA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733964401; c=relaxed/simple; bh=YS324n3d0zCyweuCVOsAXOrw2hHW8jnoR0Fe0uJwpIU=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=BUVsvu544wF7ipEV9nf2Z0uhk42qUSxVi8U5EyYtFhR3qHE0ZoEiuNo3k/+a6JGVn4AjSQ8M62ZIb3JYD+N3t/+7A+b+fucXGSxepIyN5my37mXxbGvjnynfCjYXcLhHtufjndyBVoe4lNPRoKhBVJzxt5B5WYwXulWMVaPPtU0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=JXfSUy6P; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JXfSUy6P" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-385e27c75f4so11111f8f.2 for ; Wed, 11 Dec 2024 16:46:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733964398; x=1734569198; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=W17CG2GTV8JKUXeGnJwgV9wPZYIX0+hpf6sa4ld+5Nk=; b=JXfSUy6POPURyLBLq37slshbvFeWN4dfVrp8XL494JzIJB/ZRtK39JSd4SWXihhtn1 pYEr4ooRev87nJwsa79Kix8vaVY/ANxIc1hxzsR4BCR03+MKCWtCUCjabOM/3FqaBw9J vasjUr431y+GyFc9np7sjc+bnpMjiLKv5fOEVEDOrWFswTAiR9oem485ax+OE2lq6I23 yaJyKAIR6I8xG41I5yTMOsfyBVqCX5L7bJTndlUXYMNR67oJmAGJMPa09vK+K7e945XN kuy7yB9J132nXR4kDJPEpLI0ltdw7pbdLS8BY2y9f7GfiFwgzz5mVEnyHOCzEhrel+vp DjCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733964398; x=1734569198; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=W17CG2GTV8JKUXeGnJwgV9wPZYIX0+hpf6sa4ld+5Nk=; b=uw7cnUUo1QwiKvxPqp8axlM6jkLHkEYkMfyobX/2tjy5bHIqyUB20SoLNT/1gASwPd F3F+enIEHbYXQ9gdg/2QRiXJRi/pU6T3DK5NFbwVG3MPCB/Ah0WO03YEIiKlR61vv/Rp rbs+9FJyxSduC/+CvA3d8+JGDwxs9ghjs44VQS0k7qHBT++4ywVdABb723HEQgTimhXL yra2RTA/xb9IbW/ndt1DpUkUJAwDqhtUz0MAfm97R5HMTYHPzRO7sPVl5Dyg8CaZRc7X rLuCBzy2AKRB31HT6k3kUFreyKXMK3i9SY34vAyObpLCW+zPDiziNmG0byG0vikVQ1wf G66g== X-Forwarded-Encrypted: i=1; AJvYcCUlpxnBHlWRK/VDvHYLe+yyneTTJtwKhgS3Z8tYhFL85RP3YUKNYO7MIe+gAHq6j/ji9E5ISfEeX6N46bA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2EvTupl54HjGU9B87FwuIVx+TPCEck+wrWPfQpP+vTvlz/XQt eXttrBlDcMRy3V9F+sbZeQ/SGafo8NPT5fe2TKtYTtKpn1r8ZWsM4PULQpdY1po= X-Gm-Gg: ASbGncsMXKclaYihtDgErWqjqsdGIt+mvjUm1ZiZcDkG/XKlql1lTzEU8cCv2C9RrLT Ep/vqRR9MuHIW7MyHX3GNp5U+cg/bllEgX09AwTkLGEz+QzrBq2lElgTG6yNFmrxIVc6+M03MZy 1wo2SY+HChr5AQ0CfeYrSJNPwFWimE3V8O/UKsQR8QXDHOCGC9mdz8fbKc8A6dxbKsxOG18Df4Y B3E5IBHMNbDeqqCQmyu16shHWm3Z6PCLhEy6XZOgHq6iBGCBZuOvV1l X-Google-Smtp-Source: AGHT+IG/oETOt4H+tqPxItW6KT0fnyooyBtrlajq83xl8GbCXw88vPt0o39pURb6dfsB5qsKrcBpKw== X-Received: by 2002:a05:6000:1a86:b0:385:e4a7:df07 with SMTP id ffacd0b85a97d-3864cec38ddmr4347181f8f.42.1733964397937; Wed, 11 Dec 2024 16:46:37 -0800 (PST) Received: from localhost ([2.222.231.247]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38782514e54sm2494722f8f.85.2024.12.11.16.46.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Dec 2024 16:46:36 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 12 Dec 2024 00:46:35 +0000 Message-Id: Cc: , , , , , , , , , , , , , , , Subject: Re: [PATCH v1 08/10] arm64: dts: qcom: qrb4210-rb2: enable wsa881x amplifier From: "Alexey Klimov" To: "Krzysztof Kozlowski" X-Mailer: aerc 0.18.2 References: <20241101053154.497550-1-alexey.klimov@linaro.org> <20241101053154.497550-9-alexey.klimov@linaro.org> <5zkslmf7m5vphs2wjcdg3536eo7tuh3stjthh3ulkr7oic5i25@qtnsog5ladsb> In-Reply-To: <5zkslmf7m5vphs2wjcdg3536eo7tuh3stjthh3ulkr7oic5i25@qtnsog5ladsb> On Fri Nov 1, 2024 at 8:14 AM GMT, Krzysztof Kozlowski wrote: > On Fri, Nov 01, 2024 at 05:31:52AM +0000, Alexey Klimov wrote: > > One WSA881X amplifier is connected on QRB4210 RB2 board > > hence only mono speaker is supported. This amplifier is set > > to work in analog mode only. Also add required powerdown > > pins/gpios. > >=20 > > Cc: Srinivas Kandagatla > > Signed-off-by: Alexey Klimov > > --- > > arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 45 ++++++++++++++++++++++++ > > 1 file changed, 45 insertions(+) > >=20 > > diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot= /dts/qcom/qrb4210-rb2.dts > > index fc71f5930688..76b9ae1b0ebc 100644 > > --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > > +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > > @@ -63,6 +63,16 @@ hdmi_con: endpoint { [..] > > + wsa_en_sleep: wsa-en-sleep-state { > > + pins =3D "gpio106"; > > + function =3D "gpio"; > > + drive-strength =3D <2>; > > + bias-pull-down; > > + input-enable; > > Are you sure this passes dtbs_check? I think this was not allowed since > 1.5 years. I guess you were referring to thing that input-enable is not allowed and output-disable must be used instead introduced by: c4a48b0df8bf dt-bindings: pinctrl: qcom: tlmm should use output-disable, no= t input-enable Noted. This sleep state seems to be unused hence I will remove it. Also, I am going to use Konrad's suggestion about i2c gpio for now. Hope it is okay. Thanks, Alexey