From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E00791BDAB9 for ; Fri, 20 Dec 2024 10:11:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734689513; cv=none; b=OU37kHk99MWlVJihz/zIjropkGGBqG7eJ8EmywkUK8K917GpuM1UiUSDYiGAST1P+Kds/EQ30vrVT9bnEXV0MKyWo7p5+prLhYqy98AM3/dBXB/eMCo9fjDDIdxK15MC0kdpwzqTmQwHx1fSIaMNvxd8+huP9V1YL9IRoLZiUmM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734689513; c=relaxed/simple; bh=EaSdb8z72/Ef9LspwhXaWKy36z4KEu6sCzfALY8btEw=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=G87xtJm6RtJ3AQ4LjdtKR8Yw5kFvVqeUn4Zn6hRNDGtT1Efe6HvvKQfJkliJ6VYxGFlrMkjGuEzWw/hZ67m1S/bo/wsn6XsnfEjIagbLrvq8LxGqixvrRwSenfn1qIlpdJ/Jfzw4rcLjrwtcZ8v+UrCu3IUKSILv4c4kBFbjYEU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=xII7jMMJ; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="xII7jMMJ" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-37ed3bd6114so774174f8f.2 for ; Fri, 20 Dec 2024 02:11:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1734689508; x=1735294308; darn=vger.kernel.org; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=EaSdb8z72/Ef9LspwhXaWKy36z4KEu6sCzfALY8btEw=; b=xII7jMMJW/VkUuE+mnsE/e5LYak9IlvR/aBD49lVR3lumTHolxlrRMvAWx680e+80j 5PKSAeC37lnjwG0dmOw+Hy4gUGkf0TquWVq4g+m6JeNbdCon75NugK9h2dE3/jP/R0FQ a2EXpf6+4rp5Fyzub7TZj6/SrdhpWHGYB9CBOKpbt9XRBVO8D4rRIc9xDqOqIysHhiN9 2ztgytOwFn17mvo0hoDjy7wx8oEtZWmt1EQLVWhyi9KlfabYQXXP0Owzojvshj5B6U6h Q1wpW3Y4fc791mipeYi18MX41vssq/w38HOZYgQkRlr2K44p21eWocUMp1R7RiUeLFaD 6k1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734689508; x=1735294308; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=EaSdb8z72/Ef9LspwhXaWKy36z4KEu6sCzfALY8btEw=; b=WAA0EiuyQIVzl03yoMNvn2ypP4SAhrQsU8tmqGmqZpDTLYTd+oYAL26iAoxvKQhXQW ggR6R4Rj4na3LMz+88nCEHY//xZWfczxGd3Rxn0/iGoU7mcs/1kdBEzU6cwxc6cZSdTF fRzGssO9u9qyJS3STFuQ0mHyHquTL4+AAmtk1GYkiJZHTnIbsawrPZPJAEzOcrMvFcOP AjacQUuOqHeUQg5om4/GqApXo2ZsmcmII+wPohGXlQZq9dIPuS52M0unaSDVPzmh68g5 LYGtaJtLMM7U5MJLEATb2MM5IAMaepLYkyY9MFWJ1Q4JJi+WNLZDIpi0IHvAbe5+RGVY Ec8A== X-Forwarded-Encrypted: i=1; AJvYcCWTDnd5xWhUXpQ6MCZya/9c2sW13aKTbfnnIMPinKq8pmIbZJzH7HtZPwjbfkIQoMiyUUFDPs356CIWOQg=@vger.kernel.org X-Gm-Message-State: AOJu0YyQdX7n4ptq3RKStMHYWFrC0lWNw2OSBNEXUVJFfjiiX/58UcsG wYvYg6sAzaAzQU2bWuhf3X44C8uWuJ17s3djqTZ/GUuQpUKLBn2maNZ3tvmDvHE= X-Gm-Gg: ASbGncumgcsO4B90npkGaQqXxL1jfOmFbr2w7fSK2yPeO9RJgMKKQYfQzFtwSDhrwdd eO0xh10NkeIsClSE3eqw+WK1ryN33Ag1yEzCw3TlC3tFFBFyUt9ABLVu2tlViIr+L/zCQeoT12Z tsekcQ7SaIhFOpM+Kv48ht/rIsxsh/iNOmc5YUp/rFSlQrA5VNARTZcgL23305cr/2Ztbqd/dW6 JswG12LeGb5v9KEtLP+7SVWnAOp3Gx16mgoZ775ixxz50kKMKUvugSTqiiHP0l/6wwhNoL/gu7o I4USxIMCyCapj5O851KHURmMJA== X-Google-Smtp-Source: AGHT+IHYXbF5zEgptW9K6SaQDrYDWMjumw3skuuvDaqv7mt65+EQ9elAtWEo+20ASe35/lJk+bD6iw== X-Received: by 2002:a5d:5f4f:0:b0:386:391e:bc75 with SMTP id ffacd0b85a97d-38a221fa986mr1984788f8f.16.1734689508270; Fri, 20 Dec 2024 02:11:48 -0800 (PST) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4366112e780sm41626015e9.0.2024.12.20.02.11.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 02:11:47 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 20 Dec 2024 11:11:47 +0100 Message-Id: To: "Konrad Dybcio" , "Bjorn Andersson" , "Konrad Dybcio" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Luca Weiss" Cc: <~postmarketos/upstreaming@lists.sr.ht>, , , , Subject: Re: [PATCH] arm64: dts: qcom: sm7225-fairphone-fp4: Drop extra qcom,msm-id value From: "Luca Weiss" X-Mailer: aerc 0.18.2-0-ge037c095a049 References: <20241220-fp4-msm-id-v1-1-2b75af02032a@fairphone.com> In-Reply-To: On Fri Dec 20, 2024 at 10:36 AM CET, Konrad Dybcio wrote: > On 20.12.2024 9:55 AM, Luca Weiss wrote: > > The ID 434 is for SM6350 while 459 is for SM7225. Fairphone 4 is only > > SM7225, so drop the unused 434 entry. > >=20 > > Fixes: 4cbea668767d ("arm64: dts: qcom: sm7225: Add device tree for Fai= rphone 4") > > Signed-off-by: Luca Weiss > > --- > > Completely dropping these values also appears to work when using > > boot.img header version 2, but doing this change now would mean any > > tooling in the wild for packaging up the boot.img using header v0 would > > stop producing working without adjusting that mkbootimg invocation. > > --- > > It would be nice if you could start shifting that tooling to bootimgv2 > slowly, and when it trickles down to appropriate places, switch it up > upstream as well. Of course if that works for you. In postmarketOS for sure it's simple to switch, I know Mobian also has something for FP4, but apart from that I'm not sure if there's more build scripts floating around somewhere. > > Reviewed-by: Konrad Dybcio > > Konrad