From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 879591B393C for ; Fri, 3 Jan 2025 09:52:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735897960; cv=none; b=ZBU3lIZVtxO/jF1m2O2dYGjcMPhxNfXES7MCWXG1zXi6fdQxwWb/o30VMKGmqPvpHglPJ3EZLQYtJrSxAfeqn1N0jhRL9igIm/4Z+Isw2aNOh1tTBmahyC8h4dv10szBJrv5smcGJ4oHSc/7DkARrGINjVdLpWopBOFxANNQoPU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735897960; c=relaxed/simple; bh=GAEFu1xWo+vq9A7a78naTFeqfSW00xJQU0a2ijC81L8=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=CFE1uQSpDJW1CsEiX+xHL4KTH/JPOLzuL4nIREO1m/aje+wUodcssfas/makPueeY+tPUzazmV7MGorPcPZ6/bUAWEdntjzL1ExtAAWN+GbjKbXWOG3ialGojaSlOiI7QFZvel8zwaU7QSuc547KKK9c00AxqwTEXgguiT029GA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=nuu6TpXQ; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="nuu6TpXQ" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-aaf3c3c104fso861132366b.1 for ; Fri, 03 Jan 2025 01:52:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1735897956; x=1736502756; darn=vger.kernel.org; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5Bkg7Flo+OpiEi1p9H/02JXt2rT+BbZkhOhMB9gCKV0=; b=nuu6TpXQZUWMaRptwZ9mlxpNZSRaNE04Vt163B8QXXPRGu33ihdRhguFfFCTWRz+vh dhNB3kOMmLJCa2LYpaJeqH8+3Xy/mquu9gzaHdCg6AT9TnzL4+BB4pJf8lOUoU0+N2XS 8/SvIBeo07eB1UySICDSXHwDqUeHtpSfa00RKBYQSre8DPkZDT0ZoD8+pX0jbKjB+Hyh Abd7zY8rAiBT8YzHp5br6yNVAy/Sf+JTgVijdSl5Wtemjzm97mEeyJUMAoTHIpEZPwN9 eX+xJvz6nHUcSl0nBanC6JmxSbHZyNdpNoqfa8aozOXdzBLe7fix+Jv8ZzvlM3V9Titb h56Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735897956; x=1736502756; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=5Bkg7Flo+OpiEi1p9H/02JXt2rT+BbZkhOhMB9gCKV0=; b=fAYZY+1kmmmqKua82GPpshcF3utdaRbyPwTZ6OVJ+OY1AfHNU0MqRgmhw6UaK1QYNM SIakuE6je21o0eH1Z4vZJo1hfsiNCDPhNNOZbcOqWhwz4xy+I4BomSObzrOrnc9PQ05D 6XK6lB4It1GpX8RV9bh9GToA/sJZ4gUZfRiaVO4dG8dzKtOF/HOlFz660uuLbyVCRoJs St3VTXQa/9iGeiUTnepNSeQYDyyyQXu2NVWJE9GvoRBDidM19qcgNhdsuFJOKWpLBjIY +rNL9HXQt+8pP1TeHHhOa+tWesvM2iPEXWQK+oYXi5eCPUpf+QT7RrNd9qiYpTh07fWT OsAg== X-Forwarded-Encrypted: i=1; AJvYcCXMjix5Jfn7BzqdFNgoDTgUbAEweniTwa8ZYx+kJKqPNUzqEZo6FcuG+Wt3uFbdeg0wi+s3qvzSsZH87Qc=@vger.kernel.org X-Gm-Message-State: AOJu0YyPq5bI9QeHCDszEdwrF9N+Gjkr9JbTlTQ0wZ5jyS3+SzpZbnaW 1Vw7YfhAANmWXVvIE9vkGUY1fHGTkQxlRPIbiUs7oRoVVCKnr7shxTdjKF3wgBz73x6EmF+c2ij B X-Gm-Gg: ASbGncv53iGHvzUhzzmvCKhbluJo9cfT7+92RxCsGQcDZKSwOdSxhQB0j5IOE1cDJx2 ZixS3h7+5OqP/kb5EDbD3g6uI57jF99fvT417WxP8cQBBsqoXo71ciG3h9fuLRt5rk7U+MEKxyh v8S41zUNYDfQldJmOKblSs6tYHwPTfh1r7tN3pKSXDtkfrmbsGaOlyeFyh+aKGPtF8FEs01XGxl kqmtfU0YL+rVjRGD0o0HeUvyNGS+DM1BhcelwA8ZnPAs0+iEi8BjUYUbBnQUhCjXbsmKYMhBcyE aF9LVvqYRDTH3Hs= X-Google-Smtp-Source: AGHT+IG8YuxqFunIcm8OWjQjnqMCuQk4ESRUGe0Bz62boxuF4DFyE+YgKQ/UVpnkrUFDSFaE7ssBFw== X-Received: by 2002:a17:907:724b:b0:aa6:7737:1991 with SMTP id a640c23a62f3a-aac2702ae51mr4867844966b.2.1735897955707; Fri, 03 Jan 2025 01:52:35 -0800 (PST) Received: from localhost (31-151-138-250.dynamic.upc.nl. [31.151.138.250]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aaf697b1c27sm470866666b.122.2025.01.03.01.52.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jan 2025 01:52:35 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 03 Jan 2025 10:52:34 +0100 Message-Id: Subject: Re: [PATCH 2/2] Input: goodix-berlin - fix vddio regulator references From: "Luca Weiss" To: , "Bastien Nocera" , "Hans de Goede" , "Dmitry Torokhov" , "Jeff LaBundy" , "Charles Wang" , "Jens Reidel" Cc: <~postmarketos/upstreaming@lists.sr.ht>, , , , X-Mailer: aerc 0.18.2-0-ge037c095a049 References: <20250103-goodix-berlin-fixes-v1-0-b014737b08b2@fairphone.com> <20250103-goodix-berlin-fixes-v1-2-b014737b08b2@fairphone.com> <0233a087-67c4-482e-8ef1-9c8dc610f9fb@linaro.org> In-Reply-To: <0233a087-67c4-482e-8ef1-9c8dc610f9fb@linaro.org> On Fri Jan 3, 2025 at 10:27 AM CET, Neil Armstrong wrote: > Hi, > > On 03/01/2025 10:21, Luca Weiss wrote: > > As per dt-bindings the property is called vddio-supply, so use the > > correct name in the driver instead of iovdd. The datasheet also calls > > the supply 'VDDIO'. > > This is duplicate of https://lore.kernel.org/all/20240805155806.16203-1-d= anila@jiaxyga.com/ Oh, any idea why it wasn't picked up since August? > > But it's still valid: > > Reviewed-by: Neil Armstrong Thanks! Regards Luca > > >=20 > > Fixes: 44362279bdd4 ("Input: add core support for Goodix Berlin Touchsc= reen IC") > > Cc: stable@vger.kernel.org > > Signed-off-by: Luca Weiss > > --- > > drivers/input/touchscreen/goodix_berlin_core.c | 24 ++++++++++++-----= ------- > > 1 file changed, 12 insertions(+), 12 deletions(-) > >=20 > > diff --git a/drivers/input/touchscreen/goodix_berlin_core.c b/drivers/i= nput/touchscreen/goodix_berlin_core.c > > index e273fb8edc6b92bcbad0fd35223a841d7da7d671..7f8cfdd106fae03a6b19758= 2bca4eb61f80182c6 100644 > > --- a/drivers/input/touchscreen/goodix_berlin_core.c > > +++ b/drivers/input/touchscreen/goodix_berlin_core.c > > @@ -165,7 +165,7 @@ struct goodix_berlin_core { > > struct device *dev; > > struct regmap *regmap; > > struct regulator *avdd; > > - struct regulator *iovdd; > > + struct regulator *vddio; > > struct gpio_desc *reset_gpio; > > struct touchscreen_properties props; > > struct goodix_berlin_fw_version fw_version; > > @@ -248,19 +248,19 @@ static int goodix_berlin_power_on(struct goodix_b= erlin_core *cd) > > { > > int error; > > =20 > > - error =3D regulator_enable(cd->iovdd); > > + error =3D regulator_enable(cd->vddio); > > if (error) { > > - dev_err(cd->dev, "Failed to enable iovdd: %d\n", error); > > + dev_err(cd->dev, "Failed to enable vddio: %d\n", error); > > return error; > > } > > =20 > > - /* Vendor waits 3ms for IOVDD to settle */ > > + /* Vendor waits 3ms for VDDIO to settle */ > > usleep_range(3000, 3100); > > =20 > > error =3D regulator_enable(cd->avdd); > > if (error) { > > dev_err(cd->dev, "Failed to enable avdd: %d\n", error); > > - goto err_iovdd_disable; > > + goto err_vddio_disable; > > } > > =20 > > /* Vendor waits 15ms for AVDD to settle */ > > @@ -283,8 +283,8 @@ static int goodix_berlin_power_on(struct goodix_ber= lin_core *cd) > > err_dev_reset: > > gpiod_set_value_cansleep(cd->reset_gpio, 1); > > regulator_disable(cd->avdd); > > -err_iovdd_disable: > > - regulator_disable(cd->iovdd); > > +err_vddio_disable: > > + regulator_disable(cd->vddio); > > return error; > > } > > =20 > > @@ -292,7 +292,7 @@ static void goodix_berlin_power_off(struct goodix_b= erlin_core *cd) > > { > > gpiod_set_value_cansleep(cd->reset_gpio, 1); > > regulator_disable(cd->avdd); > > - regulator_disable(cd->iovdd); > > + regulator_disable(cd->vddio); > > } > > =20 > > static int goodix_berlin_read_version(struct goodix_berlin_core *cd) > > @@ -744,10 +744,10 @@ int goodix_berlin_probe(struct device *dev, int i= rq, const struct input_id *id, > > return dev_err_probe(dev, PTR_ERR(cd->avdd), > > "Failed to request avdd regulator\n"); > > =20 > > - cd->iovdd =3D devm_regulator_get(dev, "iovdd"); > > - if (IS_ERR(cd->iovdd)) > > - return dev_err_probe(dev, PTR_ERR(cd->iovdd), > > - "Failed to request iovdd regulator\n"); > > + cd->vddio =3D devm_regulator_get(dev, "vddio"); > > + if (IS_ERR(cd->vddio)) > > + return dev_err_probe(dev, PTR_ERR(cd->vddio), > > + "Failed to request vddio regulator\n"); > > =20 > > error =3D goodix_berlin_power_on(cd); > > if (error) { > >=20